[jira] [Commented] (SLING-10584) Warn if an invocation of a BindingsValuesProvider takes long

["Joerg Hoh (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SLING-10584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17375959#comment-17375959 ] 

Joerg Hoh commented on SLING-10584:
-----------------------------------

PR: https://github.com/apache/sling-org-apache-sling-scripting-core/pull/8

> Warn if an invocation of a BindingsValuesProvider takes long
> ------------------------------------------------------------
>
>                 Key: SLING-10584
>                 URL: https://issues.apache.org/jira/browse/SLING-10584
>             Project: Sling
>          Issue Type: Improvement
>          Components: Scripting
>    Affects Versions: Scripting Core 2.3.6
>            Reporter: Joerg Hoh
>            Assignee: Joerg Hoh
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> While analyzing a performance problem it took me quite a while to find out that the {{addBindings}} method of a specific BindingsValuesProvider took a significant amount of time, especially because this method was invoked quite often (many JSP snippets were included during the rendering).
> When the bindings are added, there should be an INFO log message if a BindingsValuesProvider takes more than 1msec to provide the bindings. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)