You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/01/03 15:39:53 UTC

[GitHub] [incubator-seatunnel] asdf2014 opened a new pull request #939: Simplify the initialization of ThreadLocal for Parseable

asdf2014 opened a new pull request #939:
URL: https://github.com/apache/incubator-seatunnel/pull/939


   <!--
   
   Thank you for contributing to SeaTunnel! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   ## Contribution Checklist
   
     - Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).
   
     - Name the pull request in the form "[SeaTunnel #XXXX] [component] Title of the pull request", where *SeaTunnel #XXXX* should be replaced by the actual issue number.
   
     - Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
   
   -->
   
   ## Purpose of this pull request
   
   <!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.-->
   
   We can simplify the initialization of `ThreadLocal` with lambda for `Parseable`.
   
   ## Check list
   
   * [x] Code changed are covered with tests, or it does not need tests for reason:
   * [x] Change does not need document change, or I will submit document change to https://github.com/apache/incubator-seatunnel-website later
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] asdf2014 closed pull request #939: Simplify the initialization of ThreadLocal for Parseable

Posted by GitBox <gi...@apache.org>.
asdf2014 closed pull request #939:
URL: https://github.com/apache/incubator-seatunnel/pull/939


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] asdf2014 commented on pull request #939: Simplify the initialization of ThreadLocal for Parseable

Posted by GitBox <gi...@apache.org>.
asdf2014 commented on pull request #939:
URL: https://github.com/apache/incubator-seatunnel/pull/939#issuecomment-1004613748


   Hi @dailidong . Thanks for your comment. However the whole `Parseable` class will be removed by https://github.com/apache/incubator-seatunnel/pull/906, so I will close this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] dailidong commented on pull request #939: Simplify the initialization of ThreadLocal for Parseable

Posted by GitBox <gi...@apache.org>.
dailidong commented on pull request #939:
URL: https://github.com/apache/incubator-seatunnel/pull/939#issuecomment-1004598558


   Please add unit test first, thanks
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org