You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "TherChenYang (via GitHub)" <gi...@apache.org> on 2024/04/02 03:18:43 UTC
[PR] Rename sharding to shardingsphere in seata.conf [shardingsphere]
TherChenYang opened a new pull request, #30741:
URL: https://github.com/apache/shardingsphere/pull/30741
Fixes #30672.
Changes proposed in this pull request:
- Currently Sharding has been renamed to ShardingSphere, but the configuration in Seata still retains related configurations with the prefix "Sharding".
- We need to Rename sharding to shardingsphere in seata.conf to keep consistent with shardingsphere,and make corresponding adjustments to the Test, Demo, and documentation.
---
Before committing this PR, I'm sure that I have checked the following options:
- [x] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [x] I have self-reviewed the commit code.
- [x] I have (or in comment I request) added corresponding labels for the pull request.
- [x] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [x] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Rename sharding to shardingsphere in seata.conf [shardingsphere]
Posted by "TherChenYang (via GitHub)" <gi...@apache.org>.
TherChenYang commented on code in PR #30741:
URL: https://github.com/apache/shardingsphere/pull/30741#discussion_r1547143049
##########
docs/document/content/user-manual/shardingsphere-jdbc/special-api/transaction/seata.cn.md:
##########
@@ -80,16 +80,16 @@ ALTER TABLE `undo_log` ADD INDEX `ix_log_created` (`log_created`);
`seata.conf` 存在四个属性，
-1. `sharding.transaction.seata.at.enable`，当此值为`true`时，开启 ShardingSphere 的 Seata AT 集成，存在默认值为 `true`
-2. `sharding.transaction.seata.tx.timeout`，全局事务超时（秒），存在默认值为 `60`
+1. `shardingSphere.transaction.seata.at.enable`，当此值为`true`时，开启 ShardingSphere 的 Seata AT 集成，存在默认值为 `true`
Review Comment:
Thank you very much for your review. I have made the corresponding adjustments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Rename sharding to shardingsphere in seata.conf [shardingsphere]
Posted by "strongduanmu (via GitHub)" <gi...@apache.org>.
strongduanmu merged PR #30741:
URL: https://github.com/apache/shardingsphere/pull/30741
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Rename sharding to shardingsphere in seata.conf [shardingsphere]
Posted by "strongduanmu (via GitHub)" <gi...@apache.org>.
strongduanmu commented on code in PR #30741:
URL: https://github.com/apache/shardingsphere/pull/30741#discussion_r1547102030
##########
docs/document/content/user-manual/shardingsphere-jdbc/special-api/transaction/seata.cn.md:
##########
@@ -80,16 +80,16 @@ ALTER TABLE `undo_log` ADD INDEX `ix_log_created` (`log_created`);
`seata.conf` 存在四个属性，
-1. `sharding.transaction.seata.at.enable`，当此值为`true`时，开启 ShardingSphere 的 Seata AT 集成，存在默认值为 `true`
-2. `sharding.transaction.seata.tx.timeout`，全局事务超时（秒），存在默认值为 `60`
+1. `shardingSphere.transaction.seata.at.enable`，当此值为`true`时，开启 ShardingSphere 的 Seata AT 集成，存在默认值为 `true`
Review Comment:
Please modify shardingSphere to shardingsphere
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org