You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@couchdb.apache.org by janl <gi...@git.apache.org> on 2014/11/03 09:52:39 UTC
[GitHub] couchdb-fauxton pull request: Goodbye Futon
GitHub user janl opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/126
Goodbye Futon
Needs to be merged together with https://github.com/apache/couchdb/pull/277
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/couchdb-fauxton goodbye-futon
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-fauxton/pull/126.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #126
----
commit 0ba06b3efc67f5efc66845b06e27bcd54cf5ab0f
Author: Jan Lehnardt <ja...@apache.org>
Date: 2014-10-10T18:52:21Z
build into main www dir
commit 591d3c3116bee2ce3957538cb3030e7f1f355132
Author: Jan Lehnardt <ja...@apache.org>
Date: 2014-10-10T19:33:25Z
update app root URL
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Goodbye Futon
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/126#issuecomment-61467673
really cool! i found two more occurences of the old path and it already works like charm with apache/couchdb#277 :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Goodbye Futon
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/126#issuecomment-61464833
I found the readme mentioning the old url: https://github.com/apache/couchdb-fauxton/blob/0ba06b3efc67f5efc66845b06e27bcd54cf5ab0f/readme.md#prepare-fauxton-release
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Goodbye Futon
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/126#issuecomment-64539916
+1 farewell futon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Goodbye Futon
Posted by wohali <gi...@git.apache.org>.
Github user wohali commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/126#issuecomment-63096546
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Goodbye Futon
Posted by janl <gi...@git.apache.org>.
Github user janl commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/126#discussion_r21446085
--- Diff: Gruntfile.js ---
@@ -319,11 +319,11 @@ module.exports = function(grunt) {
couchdb: {
files: [
// this gets built in the template task
- {src: "dist/release/index.html", dest: "../../share/www/fauxton/index.html"},
- {src: ["**"], dest: "../../share/www/fauxton/js/", cwd:'dist/release/js/', expand: true},
- {src: ["**"], dest: "../../share/www/fauxton/img/", cwd:'dist/release/img/', expand: true},
- {src: ["**"], dest: "../../share/www/fauxton/fonts/", cwd:'dist/release/fonts/', expand: true},
- {src: ["**"], dest: "../../share/www/fauxton/css/", cwd:"dist/release/css/", expand: true}
+ {src: "dist/release/index.html", dest: "../../share/www/index.html"},
+ {src: ["**"], dest: "../../share/www/js/", cwd:'dist/release/js/', expand: true},
+ {src: ["**"], dest: "../../share/www/img/", cwd:'dist/release/img/', expand: true},
+ {src: ["**"], dest: "../../share/www/fonts/", cwd:'dist/release/fonts/', expand: true},
+ {src: ["**"], dest: "../../share/www/css/", cwd:"dist/release/css/", expand: true}
--- End diff --
Yeah, see the hunk below :D
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Goodbye Futon
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/126#discussion_r19727531
--- Diff: Gruntfile.js ---
@@ -319,11 +319,11 @@ module.exports = function(grunt) {
couchdb: {
files: [
// this gets built in the template task
- {src: "dist/release/index.html", dest: "../../share/www/fauxton/index.html"},
- {src: ["**"], dest: "../../share/www/fauxton/js/", cwd:'dist/release/js/', expand: true},
- {src: ["**"], dest: "../../share/www/fauxton/img/", cwd:'dist/release/img/', expand: true},
- {src: ["**"], dest: "../../share/www/fauxton/fonts/", cwd:'dist/release/fonts/', expand: true},
- {src: ["**"], dest: "../../share/www/fauxton/css/", cwd:"dist/release/css/", expand: true}
+ {src: "dist/release/index.html", dest: "../../share/www/index.html"},
+ {src: ["**"], dest: "../../share/www/js/", cwd:'dist/release/js/', expand: true},
+ {src: ["**"], dest: "../../share/www/img/", cwd:'dist/release/img/', expand: true},
+ {src: ["**"], dest: "../../share/www/fonts/", cwd:'dist/release/fonts/', expand: true},
+ {src: ["**"], dest: "../../share/www/css/", cwd:"dist/release/css/", expand: true}
--- End diff --
There is also a debug target: https://github.com/apache/couchdb-fauxton/blob/0ba06b3efc67f5efc66845b06e27bcd54cf5ab0f/Gruntfile.js#L330-L336
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Goodbye Futon
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/126#issuecomment-66101913
Awesome. +1
> On 08 Dec 2014, at 1:04 PM, Jan Lehnardt <no...@github.com> wrote:
>
> @garrensmith <https://github.com/garrensmith> as far as I can tell I have that covered: https://github.com/apache/couchdb-fauxton/pull/126/files#diff-35b4a816e0441e6a375cd925af50752cR332 <https://github.com/apache/couchdb-fauxton/pull/126/files#diff-35b4a816e0441e6a375cd925af50752cR332>
> —
> Reply to this email directly or view it on GitHub <https://github.com/apache/couchdb-fauxton/pull/126#issuecomment-66101782>.
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Goodbye Futon
Posted by janl <gi...@git.apache.org>.
Github user janl commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/126#issuecomment-66100567
@robertkowalski Where are the other occurrences of the old path?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Goodbye Futon
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/couchdb-fauxton/pull/126
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Goodbye Futon
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/126#issuecomment-66101068
@janl the other occurrences of the old path are on line 332 of gruntfile.js
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Goodbye Futon
Posted by janl <gi...@git.apache.org>.
Github user janl commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/126#issuecomment-66101782
@garrensmith as far as I can tell I have that covered: https://github.com/apache/couchdb-fauxton/pull/126/files#diff-35b4a816e0441e6a375cd925af50752cR332
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---