You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by GitBox <gi...@apache.org> on 2019/04/04 16:59:27 UTC

[GitHub] [lucene-solr] b-pradeeprao opened a new pull request #636: SOLR-10409 - Added support for rows=x in /export to limit number of docs exported (With unit tests)

b-pradeeprao opened a new pull request #636: SOLR-10409 - Added support for rows=x in /export to limit number of docs exported (With unit tests)
URL: https://github.com/apache/lucene-solr/pull/636
 
 
   This lets user add rows=x  parameter to request to limit number of docs they get from /export query
   
   rows=x
   {
   x=0 => returns numFound=0 and no docs in results - this is existing behavior (I guess, unintended)
   x=undefined or x>=numFound => will not have any effect on existing behavior 
   x < numFound => will return first x docs only (in specified sorted order ) in results.
   }
   
   Note Reg. Unit Testing.
   Given **DOCUMENT_BATCH_SIZE = 30000;** in **ExportWriter.java:87** , ideal testing should be done on index with >30k docs. I have tested all edge cases with the batch_sizes to 100 and 1.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org