You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/03/03 02:18:51 UTC

[GitHub] [kafka] dengziming opened a new pull request #10250: MINOR: Fix null exception in coordinator log

dengziming opened a new pull request #10250:
URL: https://github.com/apache/kafka/pull/10250


   *More detailed description of your change*
   Found that the `fatalException` is always null when calling `log.info("xxx", fatalException)`, maybe we should first assign a value to it.
   
   
   *Summary of testing strategy (including rationale)*
   Test locally.
   
   from
   ```
   [2021-03-03 10:18:06,203] INFO FindCoordinator request hit fatal exception (org.apache.kafka.clients.consumer.internals.AbstractCoordinatorTest$DummyCoordinator:260)
   ```
   to
   
   ```
   [2021-03-03 10:17:37,123] INFO FindCoordinator request hit fatal exception (org.apache.kafka.clients.consumer.internals.AbstractCoordinatorTest$DummyCoordinator:260)
   org.apache.kafka.common.errors.AuthenticationException: Authentication failed
   ```
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] ableegoldman commented on pull request #10250: MINOR: Fix null exception in coordinator log

Posted by GitBox <gi...@apache.org>.
ableegoldman commented on pull request #10250:
URL: https://github.com/apache/kafka/pull/10250#issuecomment-789420651


   @chia7712 do you want to merge this? We should also cherrypick it all the way back to 2.6 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] ableegoldman commented on pull request #10250: MINOR: Fix null exception in coordinator log

Posted by GitBox <gi...@apache.org>.
ableegoldman commented on pull request #10250:
URL: https://github.com/apache/kafka/pull/10250#issuecomment-789420529


   One unrelated test failure which is known to be flaky: `TransactionsBounceTest.testWithGroupMetadata`


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] chia7712 merged pull request #10250: MINOR: Fix null exception in coordinator log

Posted by GitBox <gi...@apache.org>.
chia7712 merged pull request #10250:
URL: https://github.com/apache/kafka/pull/10250


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] dengziming commented on pull request #10250: MINOR: Fix null exception in coordinator log

Posted by GitBox <gi...@apache.org>.
dengziming commented on pull request #10250:
URL: https://github.com/apache/kafka/pull/10250#issuecomment-789374413


   @ableegoldman PTAL.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] chia7712 commented on pull request #10250: MINOR: Fix null exception in coordinator log

Posted by GitBox <gi...@apache.org>.
chia7712 commented on pull request #10250:
URL: https://github.com/apache/kafka/pull/10250#issuecomment-789420972


   >  do you want to merge this? We should also cherrypick it all the way back to 2.6
   
   Sure. will merge and backport this patch.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org