[GitHub] [karaf] awrb commented on a diff in pull request #1628: [KARAF-1381] - store karaf command history separately for each instance

[GitBox <gi...@apache.org>]

awrb commented on code in PR #1628:
URL: https://github.com/apache/karaf/pull/1628#discussion_r980253676


##########
shell/core/src/main/java/org/apache/karaf/shell/impl/console/ConsoleSessionImpl.java:
##########
@@ -299,7 +299,9 @@ public Object evaluate(LineReader reader, ParsedLine line, String func) throws E
      * @return the history file
      */
     protected Path getHistoryFile() {
-        String defaultHistoryPath = new File(System.getProperty("user.home"), ".karaf/karaf.history").toString();
+        String instanceName = System.getProperty("karaf.name", "root");

Review Comment:
   Might want to keep `karaf.history` filename for the root instance for retrocompatibility? If so there needs to be a condition here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@karaf.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org