You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by "potiuk (via GitHub)" <gi...@apache.org> on 2023/03/04 17:58:10 UTC

[GitHub] [airflow] potiuk commented on pull request #29782: Param argument accepts generic dict subtypes

potiuk commented on PR #29782:
URL: https://github.com/apache/airflow/pull/29782#issuecomment-1454822549

   > I wasn't sure about a test case given this is a typing change, so `mypy` should catch any errors and there are no functional changes. But I can add a test to ensure that a `ParamsDict` object is a valid input to a DAG, which should catch typing regressions
   
   Yeah. I kinda agree that no tests are needed in this case. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org