You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@gluten.apache.org by "yikf (via GitHub)" <gi...@apache.org> on 2024/12/10 07:59:56 UTC
[PR] [VL] Change the loadQuantum config if velox cache is enabled. [incubator-gluten]
yikf opened a new pull request, #8197:
URL: https://github.com/apache/incubator-gluten/pull/8197
## What changes were proposed in this pull request?
https://github.com/apache/incubator-gluten/pull/8186 followup, change the loadQuantum config if velox cache is enabled only.
## How was this patch tested?
manual tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] Change the loadQuantum config if velox cache is enabled. [incubator-gluten]
Posted by "Yohahaha (via GitHub)" <gi...@apache.org>.
Yohahaha commented on code in PR #8197:
URL: https://github.com/apache/incubator-gluten/pull/8197#discussion_r1877877336
##########
gluten-core/src/main/scala/org/apache/gluten/GlutenPlugin.scala:
##########
@@ -249,6 +249,18 @@ private[gluten] class GlutenDriverPlugin extends DriverPlugin with Logging {
s"${COLUMNAR_VELOX_CACHE_ENABLED.key} and " +
s"${COLUMNAR_VELOX_FILE_HANDLE_CACHE_ENABLED.key} should be enabled together.")
}
+
+ val maxLoadQuantumOfVeloxCache = 8 * 1024 * 1024
Review Comment:
nit: maxLoadQuantumForVeloxCache
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] Change the loadQuantum config if velox cache is enabled. [incubator-gluten]
Posted by "Yohahaha (via GitHub)" <gi...@apache.org>.
Yohahaha commented on code in PR #8197:
URL: https://github.com/apache/incubator-gluten/pull/8197#discussion_r1877880638
##########
gluten-core/src/main/scala/org/apache/gluten/GlutenPlugin.scala:
##########
@@ -249,6 +249,18 @@ private[gluten] class GlutenDriverPlugin extends DriverPlugin with Logging {
s"${COLUMNAR_VELOX_CACHE_ENABLED.key} and " +
s"${COLUMNAR_VELOX_FILE_HANDLE_CACHE_ENABLED.key} should be enabled together.")
}
+
+ val maxLoadQuantumOfVeloxCache = 8 * 1024 * 1024
+ val loadQuantum = conf.getSizeAsBytes(LOAD_QUANTUM.key, LOAD_QUANTUM.defaultValueString)
+ if (
+ conf.getBoolean(COLUMNAR_VELOX_CACHE_ENABLED.key, false) &&
+ loadQuantum > maxLoadQuantumOfVeloxCache
+ ) {
+ logWarning(
+ s"Velox currently only support up to 8MB load quantum size on SSD cache, change config " +
+ s"{$LOAD_QUANTUM.key} value from loadQuantum to $maxLoadQuantumOfVeloxCache")
+ conf.set(LOAD_QUANTUM.key, maxLoadQuantumOfVeloxCache.toString)
Review Comment:
I prefer to check load quantum in `VeloxBackend::initCache`, throws when load quantum larger than 8m when cache enabled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] Change the loadQuantum config if velox cache is enabled. [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8197:
URL: https://github.com/apache/incubator-gluten/pull/8197#issuecomment-2531479748
Run Gluten Clickhouse CI on x86
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] Change the loadQuantum config if velox cache is enabled. [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8197:
URL: https://github.com/apache/incubator-gluten/pull/8197#issuecomment-2535404154
Run Gluten Clickhouse CI on x86
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] Change the loadQuantum config if velox cache is enabled. [incubator-gluten]
Posted by "yikf (via GitHub)" <gi...@apache.org>.
yikf commented on PR #8197:
URL: https://github.com/apache/incubator-gluten/pull/8197#issuecomment-2530761606
@Yohahaha @PHILO-HE @jackylee-ch Could you please take a look, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] Change the loadQuantum config if velox cache is enabled. [incubator-gluten]
Posted by "yikf (via GitHub)" <gi...@apache.org>.
yikf commented on PR #8197:
URL: https://github.com/apache/incubator-gluten/pull/8197#issuecomment-2530762122
also cc @FelixYBW
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] Change the loadQuantum config if velox cache is enabled. [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8197:
URL: https://github.com/apache/incubator-gluten/pull/8197#issuecomment-2530721452
Run Gluten Clickhouse CI on x86
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] Change the loadQuantum config if velox cache is enabled. [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8197:
URL: https://github.com/apache/incubator-gluten/pull/8197#issuecomment-2535508866
Run Gluten Clickhouse CI on x86
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] Change the loadQuantum config if velox cache is enabled. [incubator-gluten]
Posted by "yikf (via GitHub)" <gi...@apache.org>.
yikf commented on code in PR #8197:
URL: https://github.com/apache/incubator-gluten/pull/8197#discussion_r1877994040
##########
gluten-core/src/main/scala/org/apache/gluten/GlutenPlugin.scala:
##########
@@ -249,6 +249,18 @@ private[gluten] class GlutenDriverPlugin extends DriverPlugin with Logging {
s"${COLUMNAR_VELOX_CACHE_ENABLED.key} and " +
s"${COLUMNAR_VELOX_FILE_HANDLE_CACHE_ENABLED.key} should be enabled together.")
}
+
+ val maxLoadQuantumOfVeloxCache = 8 * 1024 * 1024
+ val loadQuantum = conf.getSizeAsBytes(LOAD_QUANTUM.key, LOAD_QUANTUM.defaultValueString)
+ if (
+ conf.getBoolean(COLUMNAR_VELOX_CACHE_ENABLED.key, false) &&
+ loadQuantum > maxLoadQuantumOfVeloxCache
+ ) {
+ logWarning(
+ s"Velox currently only support up to 8MB load quantum size on SSD cache, change config " +
+ s"{$LOAD_QUANTUM.key} value from loadQuantum to $maxLoadQuantumOfVeloxCache")
+ conf.set(LOAD_QUANTUM.key, maxLoadQuantumOfVeloxCache.toString)
Review Comment:
@Yohahaha When users use the default values and enable velox cache, throws directly may not be a good choice.
VeloxBackend::initCache modifying the load quantum fundamentally also involves checking and modifying the backendConf_, which seems to make backendConf_ read-only for safety purposes.
I am fine with either approach.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] Change the loadQuantum config if velox cache is enabled. [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8197:
URL: https://github.com/apache/incubator-gluten/pull/8197#issuecomment-2530721003
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICEGJ-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
Could you open an issue for this pull request on Github Issues?
https://github.com/apache/incubator-gluten/issues
Then could you also rename ***commit message*** and ***pull request title*** in the following format?
[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}
See also:
* [Other pull requests](https://github.com/apache/incubator-gluten/pulls/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] Change the loadQuantum config if velox cache is enabled. [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8197:
URL: https://github.com/apache/incubator-gluten/pull/8197#issuecomment-2530792462
Run Gluten Clickhouse CI on x86
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] Change the loadQuantum config if velox cache is enabled. [incubator-gluten]
Posted by "PHILO-HE (via GitHub)" <gi...@apache.org>.
PHILO-HE commented on code in PR #8197:
URL: https://github.com/apache/incubator-gluten/pull/8197#discussion_r1877752826
##########
shims/common/src/main/scala/org/apache/gluten/GlutenConfig.scala:
##########
@@ -2097,13 +2097,12 @@ object GlutenConfig {
.intConf
.createWithDefault(1)
- // Velox currently only support up to 8MB load quantum size on SSD.
val LOAD_QUANTUM =
buildStaticConf("spark.gluten.sql.columnar.backend.velox.loadQuantum")
.internal()
.doc("Set the load quantum for velox file scan")
Review Comment:
It is worth adding more comments here. E.g., "Recommend to use the default value (256MB) for performance consideration. If Velox cache is enabled, it can be 8MB at most."
##########
gluten-core/src/main/scala/org/apache/gluten/GlutenPlugin.scala:
##########
@@ -249,6 +249,18 @@ private[gluten] class GlutenDriverPlugin extends DriverPlugin with Logging {
s"${COLUMNAR_VELOX_CACHE_ENABLED.key} and " +
s"${COLUMNAR_VELOX_FILE_HANDLE_CACHE_ENABLED.key} should be enabled together.")
}
+
+ val maxLoadQuantumOfVeloxCache = 8 * 1024 * 1024
+ val loadQuantum = conf.getSizeAsBytes(LOAD_QUANTUM.key, LOAD_QUANTUM.defaultValueString)
+ if (
+ conf.getBoolean(COLUMNAR_VELOX_CACHE_ENABLED.key, false) &&
+ loadQuantum > maxLoadQuantumOfVeloxCache
+ ) {
+ logWarning(
+ s"Velox currently only support up to 8MB load quantum size on SSD cache, change config " +
+ s"{$LOAD_QUANTUM.key} value from loadQuantum to $maxLoadQuantumOfVeloxCache")
+ conf.set(LOAD_QUANTUM.key, maxLoadQuantumOfVeloxCache.toString)
Review Comment:
I note this is a static config, Can it be really reset?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] Change the loadQuantum config if velox cache is enabled. [incubator-gluten]
Posted by "yikf (via GitHub)" <gi...@apache.org>.
yikf commented on code in PR #8197:
URL: https://github.com/apache/incubator-gluten/pull/8197#discussion_r1877995625
##########
gluten-core/src/main/scala/org/apache/gluten/GlutenPlugin.scala:
##########
@@ -249,6 +249,18 @@ private[gluten] class GlutenDriverPlugin extends DriverPlugin with Logging {
s"${COLUMNAR_VELOX_CACHE_ENABLED.key} and " +
s"${COLUMNAR_VELOX_FILE_HANDLE_CACHE_ENABLED.key} should be enabled together.")
}
+
+ val maxLoadQuantumOfVeloxCache = 8 * 1024 * 1024
+ val loadQuantum = conf.getSizeAsBytes(LOAD_QUANTUM.key, LOAD_QUANTUM.defaultValueString)
+ if (
+ conf.getBoolean(COLUMNAR_VELOX_CACHE_ENABLED.key, false) &&
+ loadQuantum > maxLoadQuantumOfVeloxCache
+ ) {
+ logWarning(
+ s"Velox currently only support up to 8MB load quantum size on SSD cache, change config " +
+ s"{$LOAD_QUANTUM.key} value from loadQuantum to $maxLoadQuantumOfVeloxCache")
+ conf.set(LOAD_QUANTUM.key, maxLoadQuantumOfVeloxCache.toString)
Review Comment:
@PHILO-HE It can be reset, which happens during the initialization stage of the SparkContext, before the initialization of the SparkSession.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] Change the loadQuantum config if velox cache is enabled. [incubator-gluten]
Posted by "jackylee-ch (via GitHub)" <gi...@apache.org>.
jackylee-ch commented on code in PR #8197:
URL: https://github.com/apache/incubator-gluten/pull/8197#discussion_r1878131446
##########
gluten-core/src/main/scala/org/apache/gluten/GlutenPlugin.scala:
##########
@@ -249,6 +249,18 @@ private[gluten] class GlutenDriverPlugin extends DriverPlugin with Logging {
s"${COLUMNAR_VELOX_CACHE_ENABLED.key} and " +
s"${COLUMNAR_VELOX_FILE_HANDLE_CACHE_ENABLED.key} should be enabled together.")
}
+
+ val maxLoadQuantumForVeloxCache = 8 * 1024 * 1024
+ val loadQuantum = conf.getSizeAsBytes(LOAD_QUANTUM.key, LOAD_QUANTUM.defaultValueString)
+ if (
+ conf.getBoolean(COLUMNAR_VELOX_CACHE_ENABLED.key, false) &&
+ loadQuantum > maxLoadQuantumForVeloxCache
+ ) {
+ logWarning(
+ s"Velox currently only support up to 8MB load quantum size on SSD cache, change config " +
+ s"{$LOAD_QUANTUM.key} value from loadQuantum to $maxLoadQuantumForVeloxCache")
Review Comment:
nit:
```scala
s"${LOAD_QUANTUM.key} value from ${loadQuantum} to $maxLoadQuantumForVeloxCache. " +
s"User can set ${LOAD_QUANTUM.key}=$maxLoadQuantumForVeloxCache to skip this warning."
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] Change the loadQuantum config if velox cache is enabled. [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8197:
URL: https://github.com/apache/incubator-gluten/pull/8197#issuecomment-2535512624
Run Gluten Clickhouse CI on x86
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] Change the loadQuantum config if velox cache is enabled. [incubator-gluten]
Posted by "Yohahaha (via GitHub)" <gi...@apache.org>.
Yohahaha merged PR #8197:
URL: https://github.com/apache/incubator-gluten/pull/8197
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] Change the loadQuantum config if velox cache is enabled. [incubator-gluten]
Posted by "yikf (via GitHub)" <gi...@apache.org>.
yikf commented on PR #8197:
URL: https://github.com/apache/incubator-gluten/pull/8197#issuecomment-2538340803
@Yohahaha @jackylee-ch @PHILO-HE thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] Change the loadQuantum config if velox cache is enabled. [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8197:
URL: https://github.com/apache/incubator-gluten/pull/8197#issuecomment-2531481894
Run Gluten Clickhouse CI on x86
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] Change the loadQuantum config if velox cache is enabled. [incubator-gluten]
Posted by "Yohahaha (via GitHub)" <gi...@apache.org>.
Yohahaha commented on code in PR #8197:
URL: https://github.com/apache/incubator-gluten/pull/8197#discussion_r1879196623
##########
gluten-core/src/main/scala/org/apache/gluten/GlutenPlugin.scala:
##########
@@ -249,6 +249,18 @@ private[gluten] class GlutenDriverPlugin extends DriverPlugin with Logging {
s"${COLUMNAR_VELOX_CACHE_ENABLED.key} and " +
s"${COLUMNAR_VELOX_FILE_HANDLE_CACHE_ENABLED.key} should be enabled together.")
}
+
+ val maxLoadQuantumOfVeloxCache = 8 * 1024 * 1024
+ val loadQuantum = conf.getSizeAsBytes(LOAD_QUANTUM.key, LOAD_QUANTUM.defaultValueString)
+ if (
+ conf.getBoolean(COLUMNAR_VELOX_CACHE_ENABLED.key, false) &&
+ loadQuantum > maxLoadQuantumOfVeloxCache
+ ) {
+ logWarning(
+ s"Velox currently only support up to 8MB load quantum size on SSD cache, change config " +
+ s"{$LOAD_QUANTUM.key} value from loadQuantum to $maxLoadQuantumOfVeloxCache")
+ conf.set(LOAD_QUANTUM.key, maxLoadQuantumOfVeloxCache.toString)
Review Comment:
> When users use the default values and enable velox cache, throws directly may not be a good choice.
it's a good choice, not all default values are fit velox cache.
Keep check in GlutenPlugin is ok, but modify config does not make sense to me, we could add load quantum check like `spark.gluten.sql.columnar.backend.velox.fileHandleCacheEnabled`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] Change the loadQuantum config if velox cache is enabled. [incubator-gluten]
Posted by "yikf (via GitHub)" <gi...@apache.org>.
yikf commented on code in PR #8197:
URL: https://github.com/apache/incubator-gluten/pull/8197#discussion_r1879215582
##########
gluten-core/src/main/scala/org/apache/gluten/GlutenPlugin.scala:
##########
@@ -249,6 +249,18 @@ private[gluten] class GlutenDriverPlugin extends DriverPlugin with Logging {
s"${COLUMNAR_VELOX_CACHE_ENABLED.key} and " +
s"${COLUMNAR_VELOX_FILE_HANDLE_CACHE_ENABLED.key} should be enabled together.")
}
+
+ val maxLoadQuantumOfVeloxCache = 8 * 1024 * 1024
+ val loadQuantum = conf.getSizeAsBytes(LOAD_QUANTUM.key, LOAD_QUANTUM.defaultValueString)
+ if (
+ conf.getBoolean(COLUMNAR_VELOX_CACHE_ENABLED.key, false) &&
+ loadQuantum > maxLoadQuantumOfVeloxCache
+ ) {
+ logWarning(
+ s"Velox currently only support up to 8MB load quantum size on SSD cache, change config " +
+ s"{$LOAD_QUANTUM.key} value from loadQuantum to $maxLoadQuantumOfVeloxCache")
+ conf.set(LOAD_QUANTUM.key, maxLoadQuantumOfVeloxCache.toString)
Review Comment:
@PHILO-HE @jackylee-ch have any thought on this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] Change the loadQuantum config if velox cache is enabled. [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8197:
URL: https://github.com/apache/incubator-gluten/pull/8197#issuecomment-2530752686
Run Gluten Clickhouse CI on x86
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org