You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2020/08/14 18:21:27 UTC

[GitHub] [phoenix] stoty commented on pull request #857: PHOENIX-5881 - Port PHOENIX-5645 (MaxLookbackAge) to 5.x

stoty commented on pull request #857:
URL: https://github.com/apache/phoenix/pull/857#issuecomment-674203202


   In 4.x we use org.apache.phoenix.compat.hbase.HbaseCompatCapabilities for the feature flags, It would be more consistent to move the feature flags there.
   
   I did not go through the code in detail, but it seems that extending BaseScannerRegionObserver from CompatBaseScannerRegionObserver would be a more elegant , and perhaps marginally faster solution than calling it explicitly.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org