[GitHub] [incubator-superset] etr2460 commented on a change in pull request #8104: [logging] add query id to SQL Lab logs

[GitBox <gi...@apache.org>]

etr2460 commented on a change in pull request #8104: [logging] add query id to SQL Lab logs
URL: https://github.com/apache/incubator-superset/pull/8104#discussion_r317308531
 
 

 ##########
 File path: superset/db_engine_specs/hive.py
 ##########
 @@ -253,8 +253,9 @@ def handle_cursor(cls, cursor, query, session):
         last_log_line = 0
         tracking_url = None
         job_id = None
+        query_id = query.id
 
 Review comment:
   minor nit: it might be easier to track stuff here if we use the query's client_id because that's how it's referred to on the client too.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org