You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2020/04/17 10:16:37 UTC
[GitHub] [mynewt-nimble] andrzej-kaczmarek opened a new pull request #800:
nimble/ll: Add common setting for SCA
andrzej-kaczmarek opened a new pull request #800: nimble/ll: Add common setting for SCA
URL: https://github.com/apache/mynewt-nimble/pull/800
Currently we have two separate SCA settings: actual SCA as ppm value and
enumerated one based on ranges of SCA value. This means user needs to
update both values and they ideally should be in sync.
To make our life easier, we can just have single BLE_LL_SCA setting to
provide ppm value and enumerated one can be easily determined at build
time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [mynewt-nimble] apache-mynewt-bot commented on issue #800:
nimble/ll: Add common setting for SCA
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on issue #800: nimble/ll: Add common setting for SCA
URL: https://github.com/apache/mynewt-nimble/pull/800#issuecomment-615166886
<!-- style-bot -->
## Style check summary
### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
#### nimble/controller/src/ble_ll_adv.c
<details>
```diff
@@ -4022,7 +4022,7 @@
/* SID, AType, SCA */
sync_ind[24] = (advsm->adi >> 12);
- sync_ind[24] |= !!(advsm->flags & BLE_LL_ADV_SM_FLAG_TX_ADD) << 4 ;
+ sync_ind[24] |= !!(advsm->flags & BLE_LL_ADV_SM_FLAG_TX_ADD) << 4;
sync_ind[24] |= BLE_LL_SCA_ENUM << 5;
/* PHY */
```
</details>
#### nimble/controller/src/ble_ll_sync.c
<details>
```diff
@@ -2091,7 +2092,7 @@
if (syncsm->flags & BLE_LL_SYNC_SM_FLAG_ADDR_RESOLVED) {
sync_ind[24] |= 1 << 4;
} else {
- sync_ind[24] |= (syncsm->adv_addr_type == BLE_ADDR_RANDOM) << 4 ;
+ sync_ind[24] |= (syncsm->adv_addr_type == BLE_ADDR_RANDOM) << 4;
}
sync_ind[24] |= BLE_LL_SCA_ENUM << 5;
```
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [mynewt-nimble] apache-mynewt-bot removed a comment on issue #800:
nimble/ll: Add common setting for SCA
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot removed a comment on issue #800: nimble/ll: Add common setting for SCA
URL: https://github.com/apache/mynewt-nimble/pull/800#issuecomment-615166886
<!-- style-bot -->
## Style check summary
### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
#### nimble/controller/src/ble_ll_adv.c
<details>
```diff
@@ -4022,7 +4022,7 @@
/* SID, AType, SCA */
sync_ind[24] = (advsm->adi >> 12);
- sync_ind[24] |= !!(advsm->flags & BLE_LL_ADV_SM_FLAG_TX_ADD) << 4 ;
+ sync_ind[24] |= !!(advsm->flags & BLE_LL_ADV_SM_FLAG_TX_ADD) << 4;
sync_ind[24] |= BLE_LL_SCA_ENUM << 5;
/* PHY */
```
</details>
#### nimble/controller/src/ble_ll_sync.c
<details>
```diff
@@ -2091,7 +2092,7 @@
if (syncsm->flags & BLE_LL_SYNC_SM_FLAG_ADDR_RESOLVED) {
sync_ind[24] |= 1 << 4;
} else {
- sync_ind[24] |= (syncsm->adv_addr_type == BLE_ADDR_RANDOM) << 4 ;
+ sync_ind[24] |= (syncsm->adv_addr_type == BLE_ADDR_RANDOM) << 4;
}
sync_ind[24] |= BLE_LL_SCA_ENUM << 5;
```
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [mynewt-nimble] rymanluk commented on a change in pull request
#800: nimble/ll: Add common setting for SCA
Posted by GitBox <gi...@apache.org>.
rymanluk commented on a change in pull request #800: nimble/ll: Add common setting for SCA
URL: https://github.com/apache/mynewt-nimble/pull/800#discussion_r410265923
##########
File path: nimble/controller/include/controller/ble_ll.h
##########
@@ -69,6 +69,29 @@ extern "C" {
/* Timing jitter as per spec is +/16 usecs */
#define BLE_LL_JITTER_USECS (16)
+
Review comment:
spare empty line
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [mynewt-nimble] apache-mynewt-bot commented on issue #800:
nimble/ll: Add common setting for SCA
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on issue #800: nimble/ll: Add common setting for SCA
URL: https://github.com/apache/mynewt-nimble/pull/800#issuecomment-615279948
<!-- style-bot -->
## Style check summary
#### No suggestions at this time!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services