You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/03/09 10:58:16 UTC
[GitHub] [apisix-helm-chart] anjia0532 opened a new pull request #248: feat: apisix add extraVolumeMounts and extraVolume
anjia0532 opened a new pull request #248:
URL: https://github.com/apache/apisix-helm-chart/pull/248
Signed-off-by: 赵安家 <an...@gmail.com>
1. extraVolumes: []
2. extraVolumeMounts: []
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] anjia0532 commented on a change in pull request #248: feat: apisix add extraVolumeMounts and extraVolume
Posted by GitBox <gi...@apache.org>.
anjia0532 commented on a change in pull request #248:
URL: https://github.com/apache/apisix-helm-chart/pull/248#discussion_r824354342
##########
File path: .gitignore
##########
@@ -1,2 +1,3 @@
.DS_Store
test_**.yaml
+.idea
Review comment:
OK,removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] tokers commented on a change in pull request #248: feat: apisix add extraVolumeMounts and extraVolume
Posted by GitBox <gi...@apache.org>.
tokers commented on a change in pull request #248:
URL: https://github.com/apache/apisix-helm-chart/pull/248#discussion_r823269360
##########
File path: charts/apisix/README.md
##########
@@ -76,6 +76,8 @@ The following tables lists the configurable parameters of the apisix chart and t
| `apisix.luaModuleHook.configMapRef.name` | Name of the ConfigMap where the lua module codes store | "" |
| `apisix.luaModuleHook.configMapRef.mounts[].key` | Name of the ConfigMap key, for setting the mapping relationship between ConfigMap key and the lua module code path. | `""` |
| `apisix.luaModuleHook.configMapRef.mounts[].path` | Filepath of the plugin code, for setting the mapping relationship between ConfigMap key and the lua module code path. | `""` |
+| `extraVolumes` | Additional `volume`. | `[]` |
Review comment:
Could you add the hyperlinks for the Kubernetes Volume and VolumeMount?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] anjia0532 commented on a change in pull request #248: feat: apisix add extraVolumeMounts and extraVolume
Posted by GitBox <gi...@apache.org>.
anjia0532 commented on a change in pull request #248:
URL: https://github.com/apache/apisix-helm-chart/pull/248#discussion_r824346995
##########
File path: .gitignore
##########
@@ -1,2 +1,3 @@
.DS_Store
test_**.yaml
+.idea
Review comment:
Idea and vscode is popular ide, `.idea` is jetbrains idea's project dir, Do I need to remove of it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] tokers commented on a change in pull request #248: feat: apisix add extraVolumeMounts and extraVolume
Posted by GitBox <gi...@apache.org>.
tokers commented on a change in pull request #248:
URL: https://github.com/apache/apisix-helm-chart/pull/248#discussion_r823510438
##########
File path: charts/apisix/README.md
##########
@@ -76,6 +76,8 @@ The following tables lists the configurable parameters of the apisix chart and t
| `apisix.luaModuleHook.configMapRef.name` | Name of the ConfigMap where the lua module codes store | "" |
| `apisix.luaModuleHook.configMapRef.mounts[].key` | Name of the ConfigMap key, for setting the mapping relationship between ConfigMap key and the lua module code path. | `""` |
| `apisix.luaModuleHook.configMapRef.mounts[].path` | Filepath of the plugin code, for setting the mapping relationship between ConfigMap key and the lua module code path. | `""` |
+| `extraVolumes` | Additional `volume`. | `[]` |
Review comment:
README is better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] tokers commented on a change in pull request #248: feat: apisix add extraVolumeMounts and extraVolume
Posted by GitBox <gi...@apache.org>.
tokers commented on a change in pull request #248:
URL: https://github.com/apache/apisix-helm-chart/pull/248#discussion_r824545489
##########
File path: charts/apisix/README.md
##########
@@ -76,6 +76,8 @@ The following tables lists the configurable parameters of the apisix chart and t
| `apisix.luaModuleHook.configMapRef.name` | Name of the ConfigMap where the lua module codes store | "" |
| `apisix.luaModuleHook.configMapRef.mounts[].key` | Name of the ConfigMap key, for setting the mapping relationship between ConfigMap key and the lua module code path. | `""` |
| `apisix.luaModuleHook.configMapRef.mounts[].path` | Filepath of the plugin code, for setting the mapping relationship between ConfigMap key and the lua module code path. | `""` |
+| `extraVolumes` | Additional `volume`, [k8s docs volumes](https://kubernetes.io/docs/concepts/storage/volumes/). | `[]` |
+| `extraVolumeMounts` | Additional `volumeMounts`, [k8s docs volumes](https://kubernetes.io/docs/concepts/storage/volumes/). | `[]` |
Review comment:
```suggestion
| `extraVolumeMounts` | Additional `volumeMounts`, See [Kubernetes Volumes](https://kubernetes.io/docs/concepts/storage/volumes/) for the detail. | `[]` |
```
##########
File path: charts/apisix/README.md
##########
@@ -76,6 +76,8 @@ The following tables lists the configurable parameters of the apisix chart and t
| `apisix.luaModuleHook.configMapRef.name` | Name of the ConfigMap where the lua module codes store | "" |
| `apisix.luaModuleHook.configMapRef.mounts[].key` | Name of the ConfigMap key, for setting the mapping relationship between ConfigMap key and the lua module code path. | `""` |
| `apisix.luaModuleHook.configMapRef.mounts[].path` | Filepath of the plugin code, for setting the mapping relationship between ConfigMap key and the lua module code path. | `""` |
+| `extraVolumes` | Additional `volume`, [k8s docs volumes](https://kubernetes.io/docs/concepts/storage/volumes/). | `[]` |
Review comment:
```suggestion
| `extraVolumes` | Additional `volume`, See [Kubernetes Volumes](https://kubernetes.io/docs/concepts/storage/volumes/) for the detail. | `[]` |
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] anjia0532 commented on a change in pull request #248: feat: apisix add extraVolumeMounts and extraVolume
Posted by GitBox <gi...@apache.org>.
anjia0532 commented on a change in pull request #248:
URL: https://github.com/apache/apisix-helm-chart/pull/248#discussion_r823314222
##########
File path: charts/apisix/README.md
##########
@@ -76,6 +76,8 @@ The following tables lists the configurable parameters of the apisix chart and t
| `apisix.luaModuleHook.configMapRef.name` | Name of the ConfigMap where the lua module codes store | "" |
| `apisix.luaModuleHook.configMapRef.mounts[].key` | Name of the ConfigMap key, for setting the mapping relationship between ConfigMap key and the lua module code path. | `""` |
| `apisix.luaModuleHook.configMapRef.mounts[].path` | Filepath of the plugin code, for setting the mapping relationship between ConfigMap key and the lua module code path. | `""` |
+| `extraVolumes` | Additional `volume`. | `[]` |
Review comment:
Added it to readme.md or values.yaml ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] tao12345666333 commented on a change in pull request #248: feat: apisix add extraVolumeMounts and extraVolume
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on a change in pull request #248:
URL: https://github.com/apache/apisix-helm-chart/pull/248#discussion_r824323020
##########
File path: .gitignore
##########
@@ -1,2 +1,3 @@
.DS_Store
test_**.yaml
+.idea
Review comment:
Was this added accidentally?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] anjia0532 commented on a change in pull request #248: feat: apisix add extraVolumeMounts and extraVolume
Posted by GitBox <gi...@apache.org>.
anjia0532 commented on a change in pull request #248:
URL: https://github.com/apache/apisix-helm-chart/pull/248#discussion_r824345956
##########
File path: charts/apisix/README.md
##########
@@ -76,6 +76,8 @@ The following tables lists the configurable parameters of the apisix chart and t
| `apisix.luaModuleHook.configMapRef.name` | Name of the ConfigMap where the lua module codes store | "" |
| `apisix.luaModuleHook.configMapRef.mounts[].key` | Name of the ConfigMap key, for setting the mapping relationship between ConfigMap key and the lua module code path. | `""` |
| `apisix.luaModuleHook.configMapRef.mounts[].path` | Filepath of the plugin code, for setting the mapping relationship between ConfigMap key and the lua module code path. | `""` |
+| `extraVolumes` | Additional `volume`. | `[]` |
Review comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] tao12345666333 merged pull request #248: feat: apisix add extraVolumeMounts and extraVolume
Posted by GitBox <gi...@apache.org>.
tao12345666333 merged pull request #248:
URL: https://github.com/apache/apisix-helm-chart/pull/248
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org