You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@thrift.apache.org by GitBox <gi...@apache.org> on 2022/04/13 07:51:54 UTC

[GitHub] [thrift] Jens-G commented on a diff in pull request #2562: THRIFT-5555: Java codegen and library to support future-returning client interface and implementation

Jens-G commented on code in PR #2562:
URL: https://github.com/apache/thrift/pull/2562#discussion_r849184597


##########
compiler/cpp/src/thrift/generate/t_java_generator.cc:
##########
@@ -5534,6 +5623,8 @@ THRIFT_REGISTER_GENERATOR(
     "                     Enable rethrow of unhandled exceptions and let them propagate further."
     " (Default behavior is to catch and log it.)\n"
     "    java5:           Generate Java 1.5 compliant code (includes android_legacy flag).\n"
+    "    generate_future_iface:\n"

Review Comment:
   Can we shorten that to "future_iface"? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org