You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@paimon.apache.org by "leaves12138 (via GitHub)" <gi...@apache.org> on 2025/12/16 09:38:39 UTC

[PR] [spark] Add custom topology builder for global index builder [paimon]

leaves12138 opened a new pull request, #6823:
URL: https://github.com/apache/paimon/pull/6823

   <!-- Please specify the module before the PR name: [core] ... or [flink] ... -->
   
   ### Purpose
   
   <!-- Linking this pull request to the issue -->
   Linked issue: close #xxx
   
   <!-- What is the purpose of the change -->
   
   ### Tests
   
   <!-- List UT and IT cases to verify this change -->
   
   ### API and Format
   
   <!-- Does this change affect API or storage format -->
   
   ### Documentation
   
   <!-- Does this change introduce a new feature -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [spark] Add custom topology builder for global index builder [paimon]

Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on PR #6823:
URL: https://github.com/apache/paimon/pull/6823#issuecomment-3659962264

   +1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [spark] Add custom topology builder for global index builder [paimon]

Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on code in PR #6823:
URL: https://github.com/apache/paimon/pull/6823#discussion_r2622550382


##########
paimon-common/src/main/java/org/apache/paimon/globalindex/GlobalIndexWriter.java:
##########
@@ -29,6 +29,10 @@ public interface GlobalIndexWriter {
 
     void write(@Nullable Object key);
 
+    default void write(@Nullable Object key, long rowId) {
+        write(key);

Review Comment:
   Do not write by default, it is wrong.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [spark] Add custom topology builder for global index builder [paimon]

Posted by "leaves12138 (via GitHub)" <gi...@apache.org>.
leaves12138 commented on code in PR #6823:
URL: https://github.com/apache/paimon/pull/6823#discussion_r2622557616


##########
paimon-common/src/main/java/org/apache/paimon/globalindex/GlobalIndexWriter.java:
##########
@@ -29,6 +29,10 @@ public interface GlobalIndexWriter {
 
     void write(@Nullable Object key);
 
+    default void write(@Nullable Object key, long rowId) {
+        write(key);

Review Comment:
   OK



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [spark] Add custom topology builder for global index builder [paimon]

Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi merged PR #6823:
URL: https://github.com/apache/paimon/pull/6823


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org