[GitHub] [tomcat] aooohan commented on a diff in pull request #590: Closing ExecutorService with try-with-resources and other

["aooohan (via GitHub)" <gi...@apache.org>]

aooohan commented on code in PR #590:
URL: https://github.com/apache/tomcat/pull/590#discussion_r1102455984


##########
java/org/apache/tomcat/util/http/fileupload/util/Streams.java:
##########
@@ -106,12 +106,12 @@ public static long copy(final InputStream inputStream,
             }
             if (out != null) {
                 if (closeOutputStream) {
-                    out.close();
+                    out.close(); //fixme will closing always with try

Review Comment:
   This package(`org.apache.tomcat.util.http.fileupload`) is internal fork of Commons File Upload.  Please do not modify any of the code in this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org