[jira] [Commented] (VCL-1013) Modernize parts of Windows code

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/VCL-1013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15852117#comment-15852117 ] 

ASF subversion and git services commented on VCL-1013:
------------------------------------------------------

Commit 1781597 from arkurth@apache.org in branch 'vcl/trunk'
[ https://svn.apache.org/r1781597 ]

VCL-1013
Removed code to delete specific file patterns from clean_hard_drive.

Moved cleanmgr.exe code to run_cleanmgr. Removed explicit registry key paths. Added code to query registry and build .reg file dynamically based on what features exist.

Removed call to defragment_hard_drive in Windows.pm::pre_capture.

Removed code that deleted VCL*.cmd scripts under Windows group policy directory. This was pre-2.1.

Cleaned up Windows.pm::delete_files_by_pattern.

> Modernize parts of Windows code
> -------------------------------
>
>                 Key: VCL-1013
>                 URL: https://issues.apache.org/jira/browse/VCL-1013
>             Project: VCL
>          Issue Type: Improvement
>          Components: vcld (backend)
>            Reporter: Andy Kurth
>            Assignee: Andy Kurth
>             Fix For: 2.5
>
>
> The Windows code does several cleanup actions during pre_capture.  Some of them are a bit crude and could cause problems with things such as Windows Update.  For example, the following are being deleted:
> * C:\Windows\ServicePackFiles\*
> * C:\SoftwareDistribution\Download\*
> It would be better to let dism.exe and cleanmgr.exe handle all of the cleanup unless there are files known to be 100% safe to delete.
> The cleanmgr.exe code has hard-coded registry entries for items to clean up.  These represent the checkboxes you see when you run _Disk Cleanup_.  The options vary based on version and which features are installed.  There are options for Windows 8 and later not being used.  This should be updated.
> There are other details which should be removed:
> * Defragment hard drive - I see no real advantage for this anymore.  It's detrimental for some VM images if the image is stored thin.  Under VMware/thin, if a file is created and deleted or moved to an empty location, the original space isn't reclaimed without special operations (sdelete/punchzero).  Bare metal use of VCL is rare these days and I don't see much of a benefit regardless.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)