You are viewing a plain text version of this content. The canonical link for it is here.
Posted to solr-commits@lucene.apache.org by yo...@apache.org on 2006/11/22 15:38:57 UTC

svn commit: r478173 - /incubator/solr/trunk/src/java/org/apache/solr/search/SolrIndexSearcher.java

Author: yonik
Date: Wed Nov 22 06:38:56 2006
New Revision: 478173

URL: http://svn.apache.org/viewvc?view=rev&rev=478173
Log:
clarify comments

Modified:
    incubator/solr/trunk/src/java/org/apache/solr/search/SolrIndexSearcher.java

Modified: incubator/solr/trunk/src/java/org/apache/solr/search/SolrIndexSearcher.java
URL: http://svn.apache.org/viewvc/incubator/solr/trunk/src/java/org/apache/solr/search/SolrIndexSearcher.java?view=diff&rev=478173&r1=478172&r2=478173
==============================================================================
--- incubator/solr/trunk/src/java/org/apache/solr/search/SolrIndexSearcher.java (original)
+++ incubator/solr/trunk/src/java/org/apache/solr/search/SolrIndexSearcher.java Wed Nov 22 06:38:56 2006
@@ -774,7 +774,9 @@
         public void collect(int doc, float score) {
           if (filt!=null && !filt.exists(doc)) return;
           if (numHits[0]++ < lastDocRequested || score >= minScore) {
-            // if docs are always delivered in order, we could use "score>minScore"
+            // TODO: if docs are always delivered in order, we could use "score>minScore"
+            // instead of "score>=minScore" and avoid tiebreaking scores
+            // in the priority queue.
             // but might BooleanScorer14 might still be used and deliver docs out-of-order?
             hq.insert(new ScoreDoc(doc, score));
             minScore = ((ScoreDoc)hq.top()).score;