[jira] [Assigned] (OPENNLP-1916) Improve Normalizer documentation and fail loud on chain

["Martin Wiesner (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/OPENNLP-1916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Wiesner reassigned OPENNLP-1916:
---------------------------------------

    Assignee: Kristian Rickert

> Improve Normalizer documentation and fail loud on chain
> -------------------------------------------------------
>
>                 Key: OPENNLP-1916
>                 URL: https://issues.apache.org/jira/browse/OPENNLP-1916
>             Project: OpenNLP
>          Issue Type: Improvement
>    Affects Versions: 3.0.0-M5
>            Reporter: Kristian Rickert
>            Assignee: Kristian Rickert
>            Priority: Minor
>             Fix For: 3.0.0-M6
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> 1. Minor: Replace the rung metaphor with "normalizer" wording.
> 2. Minor:
> Validate and copy the aggregate normalizer chain at construction: AggregateCharSequenceNormalizer stored the caller's varargs array as-is (null array or null element caused NPE mid-normalize, which cascaded into a changed aggregate). 
>  
> I changed it to fail loudly.
>  
> Now throws IllegalArgumentException on null, defensive copy, shadow gone, constructor javadoc added, plus a new 4-test AggregateCharSequenceNormalizerTest covering order, both null rejections, and array-mutation isolation.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)