[GitHub] [hudi] yihua commented on a diff in pull request #6366: add an option of the log file block size

[GitBox <gi...@apache.org>]

yihua commented on code in PR #6366:
URL: https://github.com/apache/hudi/pull/6366#discussion_r964187096


##########
hudi-common/src/main/java/org/apache/hudi/common/table/log/HoodieLogFormatWriter.java:
##########
@@ -230,8 +230,7 @@ private void rollOver() throws IOException {
   }
 
   private void createNewFile() throws IOException {
-    this.output =
-        fs.create(this.logFile.getPath(), false, bufferSize, replication, WriterBuilder.DEFAULT_SIZE_THRESHOLD, null);
+    this.output = fs.create(this.logFile.getPath(), false, bufferSize, replication, HoodieCommonConfig.LOG_FILE_BLOCK_SIZE.defaultValue(), null);

Review Comment:
   Should the actual configured value be passed in, instead of the default value?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org