You are viewing a plain text version of this content. The canonical link for it is here.
Posted to general@incubator.apache.org by Antoine Toulme <an...@toulme.name> on 2019/06/02 21:56:48 UTC

[DISCUSS] check LICENSE and NOTICE for Apache Tuweni

Folks,

Would you please kindly review the NOTICE [0] and LICENSE [1] files for Apache Tuweni?

Feedback is very welcome.

Thanks,

Antoine

[0]:https://github.com/apache/incubator-tuweni/blob/master/LICENSE <https://github.com/apache/incubator-tuweni/blob/master/LICENSE>
[1]:https://github.com/apache/incubator-tuweni/blob/master/NOTICE <https://github.com/apache/incubator-tuweni/blob/master/NOTICE>

Re: [DISCUSS] check LICENSE and NOTICE for Apache Tuweni

Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,

Sorry there’s been a lot going on in the last week and I’ve not been able to double check it. I will have some time this weekend if someone else can’t look before then. I had a quick look and it seems fine. I not you mention cryto code, you may need to apply for an export license. [1]

Thanks,
Justin

1. http://www.apache.org/licenses/exports/
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org


Re: [DISCUSS] check LICENSE and NOTICE for Apache Tuweni

Posted by Antoine Toulme <an...@toulme.name>.
I’m not sure what to do at this point. Should I make a new release candidate and hope for the best?

> On Jun 8, 2019, at 7:22 PM, Antoine Toulme <an...@toulme.name> wrote:
> 
> Is there anything else I need to get looked at?
> 
>> On Jun 6, 2019, at 8:45 AM, Antoine Toulme <an...@toulme.name> wrote:
>> 
>> Thanks Justin.
>> 
>>> On Jun 3, 2019, at 14:30, Justin Mclean <ju...@classsoftware.com> wrote:
>>> 
>>> Hi,
>>> 
>>>> If that’s no trouble, I’d rather have the text inlined and in the LICENSE file. Please let me know if that’s a problem.
>>> 
>>> No issue it can be done either way. I won’t be able to do a full check until later this week, so hopefully someone else can review it.
>>> 
>>> Thanks,
>>> Justin
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
>>> For additional commands, e-mail: general-help@incubator.apache.org
>>> 
>> 
>> 
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
>> For additional commands, e-mail: general-help@incubator.apache.org
>> 
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org


Re: [DISCUSS] check LICENSE and NOTICE for Apache Tuweni

Posted by Antoine Toulme <an...@toulme.name>.
Is there anything else I need to get looked at?

> On Jun 6, 2019, at 8:45 AM, Antoine Toulme <an...@toulme.name> wrote:
> 
> Thanks Justin.
> 
>> On Jun 3, 2019, at 14:30, Justin Mclean <ju...@classsoftware.com> wrote:
>> 
>> Hi,
>> 
>>> If that’s no trouble, I’d rather have the text inlined and in the LICENSE file. Please let me know if that’s a problem.
>> 
>> No issue it can be done either way. I won’t be able to do a full check until later this week, so hopefully someone else can review it.
>> 
>> Thanks,
>> Justin
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
>> For additional commands, e-mail: general-help@incubator.apache.org
>> 
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org


Re: [DISCUSS] check LICENSE and NOTICE for Apache Tuweni

Posted by Antoine Toulme <an...@toulme.name>.
Thanks Justin.

> On Jun 3, 2019, at 14:30, Justin Mclean <ju...@classsoftware.com> wrote:
> 
> Hi,
> 
>> If that’s no trouble, I’d rather have the text inlined and in the LICENSE file. Please let me know if that’s a problem.
> 
> No issue it can be done either way. I won’t be able to do a full check until later this week, so hopefully someone else can review it.
> 
> Thanks,
> Justin
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org


Re: [DISCUSS] check LICENSE and NOTICE for Apache Tuweni

Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,

> If that’s no trouble, I’d rather have the text inlined and in the LICENSE file. Please let me know if that’s a problem.

No issue it can be done either way. I won’t be able to do a full check until later this week, so hopefully someone else can review it.

Thanks,
Justin
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org


Re: [DISCUSS] check LICENSE and NOTICE for Apache Tuweni

Posted by Antoine Toulme <an...@toulme.name>.
If that’s no trouble, I’d rather have the text inlined and in the LICENSE file. Please let me know if that’s a problem.

I updated the LICENSE file. Please kindly review [0] and [1] and let me know if this is acceptable.

[0]:https://github.com/apache/incubator-tuweni/blob/master/LICENSE <https://github.com/apache/incubator-tuweni/blob/master/LICENSE> <https://github.com/apache/incubator-tuweni/blob/master/LICENSE <https://github.com/apache/incubator-tuweni/blob/master/LICENSE>>
[1]:https://github.com/apache/incubator-tuweni/blob/master/NOTICE <https://github.com/apache/incubator-tuweni/blob/master/NOTICE> <https://github.com/apache/incubator-tuweni/blob/master/NOTICE <https://github.com/apache/incubator-tuweni/blob/master/NOTICE>>

> On Jun 3, 2019, at 2:10 AM, Justin Mclean <ju...@classsoftware.com> wrote:
> 
> Hi,
> 
>> The CC0 dependencies are public domain. Do you have an example of dealing with public domain dependencies?
> 
> Treat it the same as other permissive licenses [1] i.e put a reference to the license text to a file containing the text in the release.
> 
> Thanks,
> Justin
> 
> 1. http://www.apache.org/dev/licensing-howto.html#permissive-deps
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
> 


Re: [DISCUSS] check LICENSE and NOTICE for Apache Tuweni

Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,

> The CC0 dependencies are public domain. Do you have an example of dealing with public domain dependencies?

Treat it the same as other permissive licenses [1] i.e put a reference to the license text to a file containing the text in the release.

Thanks,
Justin

1. http://www.apache.org/dev/licensing-howto.html#permissive-deps
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org


Re: [DISCUSS] check LICENSE and NOTICE for Apache Tuweni

Posted by Antoine Toulme <an...@toulme.name>.
OK, I inlined the MIT license texts from the various dependencies.

Does this look better?

The CC0 dependencies are public domain. Do you have an example of dealing with public domain dependencies?

> On Jun 2, 2019, at 3:15 PM, Justin Mclean <ju...@classsoftware.com> wrote:
> 
> Hi,
> 
> When use the short form of including a LICNSE, you need to include a link to the file containing license text not a URL. Some projects make a licenses directory and put the licenses in that. MIT requires you include the full text of the license and a URL doesn’t quite cover that.
> 
> There’s no needs for "consult the list of dependencies…” in the NOTICE file.
> 
> Thanks,
> Justin
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org


Re: [DISCUSS] check LICENSE and NOTICE for Apache Tuweni

Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,

When use the short form of including a LICNSE, you need to include a link to the file containing license text not a URL. Some projects make a licenses directory and put the licenses in that. MIT requires you include the full text of the license and a URL doesn’t quite cover that.

There’s no needs for "consult the list of dependencies…” in the NOTICE file.

Thanks,
Justin
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org