You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@giraph.apache.org by Nitay Joffe <ni...@apache.org> on 2013/03/28 05:03:40 UTC

Re: Review Request: Add ReuseObjectsPartition

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10148/
-----------------------------------------------------------

(Updated March 28, 2013, 4:03 a.m.)


Review request for giraph.


Changes
-------

Updated to latest. As you know we don't have the reuse-objects in the Hive readers anymore - so I'm not sure if we still want this or I should just abandon?


Summary (updated)
-----------------

Add ReuseObjectsPartition


Description
-------

https://issues.apache.org/jira/browse/GIRAPH-594


Diffs (updated)
-----

  giraph-core/src/main/java/org/apache/giraph/conf/GiraphClasses.java 23dab79374dac2bf18ffaac3cb2f289a61f0d2a8 
  giraph-core/src/main/java/org/apache/giraph/conf/GiraphConfiguration.java dee8e982aae23cd400c079964ecbfa6fd152ee54 
  giraph-core/src/main/java/org/apache/giraph/conf/ImmutableClassesGiraphConfiguration.java 0af8b9736b29f96cac11ed79e6b53652e2d4cf2d 
  giraph-core/src/main/java/org/apache/giraph/partition/ReusesObjectsPartition.java PRE-CREATION 
  giraph-hive/src/main/java/org/apache/giraph/hive/HiveGiraphRunner.java 0039dd6f29560b977d04e1f84a7e37c01fcb9c51 

Diff: https://reviews.apache.org/r/10148/diff/


Testing
-------


Thanks,

Nitay Joffe

Re: Review Request: Add ReuseObjectsPartition

Posted by Maja Kabiljo <ma...@fb.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10148/#review18458
-----------------------------------------------------------


Actually, I think I made a mistake, with edge input we can always reuse, but with vertex input currently we can't, right? So SimpleHiveToVertex needs this option. I can fix it, or you can put it back as part of this patch, let me know either way.

- Maja Kabiljo


On March 28, 2013, 4:03 a.m., Nitay Joffe wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10148/
> -----------------------------------------------------------
> 
> (Updated March 28, 2013, 4:03 a.m.)
> 
> 
> Review request for giraph.
> 
> 
> Description
> -------
> 
> https://issues.apache.org/jira/browse/GIRAPH-594
> 
> 
> Diffs
> -----
> 
>   giraph-core/src/main/java/org/apache/giraph/conf/GiraphClasses.java 23dab79374dac2bf18ffaac3cb2f289a61f0d2a8 
>   giraph-core/src/main/java/org/apache/giraph/conf/GiraphConfiguration.java dee8e982aae23cd400c079964ecbfa6fd152ee54 
>   giraph-core/src/main/java/org/apache/giraph/conf/ImmutableClassesGiraphConfiguration.java 0af8b9736b29f96cac11ed79e6b53652e2d4cf2d 
>   giraph-core/src/main/java/org/apache/giraph/partition/ReusesObjectsPartition.java PRE-CREATION 
>   giraph-hive/src/main/java/org/apache/giraph/hive/HiveGiraphRunner.java 0039dd6f29560b977d04e1f84a7e37c01fcb9c51 
> 
> Diff: https://reviews.apache.org/r/10148/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Nitay Joffe
> 
>