You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudberry.apache.org by "gfphoenix78 (via GitHub)" <gi...@apache.org> on 2024/11/28 03:26:16 UTC
[PR] Fix test cases for gp-style partition in single-node mode [cloudberry]
gfphoenix78 opened a new pull request, #736:
URL: https://github.com/apache/cloudberry/pull/736
The commit 782d9b799 fixes inheritance issue on gp-style partition table. The test cases for single-node are not fixed yet.
### What does this PR do?
<!-- Brief overview of the changes, including any major features or fixes -->
### Type of Change
- [ ] Bug fix (non-breaking change)
- [ ] New feature (non-breaking change)
- [ ] Breaking change (fix or feature with breaking changes)
- [ ] Documentation update
### Breaking Changes
<!-- Remove if not applicable. If yes, explain impact and migration path -->
### Test Plan
<!-- How did you test these changes? -->
- [ ] Unit tests added/updated
- [ ] Integration tests added/updated
- [ ] Passed `make installcheck`
- [ ] Passed `make -C src/test installcheck-cbdb-parallel`
### Impact
<!-- Remove sections that don't apply -->
**Performance:**
<!-- Any performance implications? -->
**User-facing changes:**
<!-- Any changes visible to users? -->
**Dependencies:**
<!-- New dependencies or version changes? -->
### Checklist
- [ ] Followed [contribution guide](https://cloudberry.apache.org/contribute/code)
- [ ] Added/updated documentation
- [ ] Reviewed code for security implications
- [ ] Requested review from [cloudberry committers](https://github.com/orgs/apache/teams/cloudberry-committers)
### Additional Context
<!-- Any other information that would help reviewers? Remove if none -->
⚠️ **To skip CI:** Add `[skip ci]` to your PR title. Only use when necessary! ⚠️
---
<!-- Join our community:
- Mailing list: [dev@cloudberry.apache.org](https://lists.apache.org/list.html?dev@cloudberry.apache.org) (subscribe: dev-subscribe@cloudberry.apache.org)
- Discussions: https://github.com/apache/cloudberry/discussions -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org
Re: [PR] Fix test cases for gp-style partition in single-node mode [cloudberry]
Posted by "gfphoenix78 (via GitHub)" <gi...@apache.org>.
gfphoenix78 commented on PR #736:
URL: https://github.com/apache/cloudberry/pull/736#issuecomment-2505494642
This PR should keep the two commits, please don't squash them. These two commits are independent, but both of them contribute to the pipeline. The second commit is to enable test pipeline for single-node mode, which will fail without the first commit.
In short, the first commit fixes test failures, and the second commit enables to run these tests and proves it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org
Re: [PR] Fix test cases for gp-style partition in single-node mode [cloudberry]
Posted by "edespino (via GitHub)" <gi...@apache.org>.
edespino commented on PR #736:
URL: https://github.com/apache/cloudberry/pull/736#issuecomment-2505318586
@gfphoenix78 - I will share the changes necessary to enable the singlenode tests with this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org
Re: [PR] Fix test cases for gp-style partition in single-node mode [cloudberry]
Posted by "edespino (via GitHub)" <gi...@apache.org>.
edespino commented on PR #736:
URL: https://github.com/apache/cloudberry/pull/736#issuecomment-2505361079
@gfphoenix78: I have a commit based on your PR branch that will enable the `singlenode` tests.
Branch: https://github.com/edespino/cloudberry/tree/refs/heads/pr-736-singlenode
Commit: https://github.com/edespino/cloudberry/commit/273c0a0d0d3b149c1ab2a05a6bf6892c82bccf69
Workflow shows the standalone test schedules have passed: https://github.com/edespino/cloudberry/actions/runs/12063579565
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org
Re: [PR] Fix test cases for gp-style partition in single-node mode [cloudberry]
Posted by "my-ship-it (via GitHub)" <gi...@apache.org>.
my-ship-it merged PR #736:
URL: https://github.com/apache/cloudberry/pull/736
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org
Re: [PR] Fix test cases for gp-style partition in single-node mode [cloudberry]
Posted by "edespino (via GitHub)" <gi...@apache.org>.
edespino commented on PR #736:
URL: https://github.com/apache/cloudberry/pull/736#issuecomment-2505438494
@gfphoenix78 Hey buddy ... the green singlenode tests are beautiful! 众人拾柴火焰高
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org