You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2019/12/11 12:15:32 UTC

[GitHub] [camel-kafka-connector] omarsmak edited a comment on issue #36: Adds support for ElasticSearch index operation + tests

omarsmak edited a comment on issue #36: Adds support for ElasticSearch index operation + tests
URL: https://github.com/apache/camel-kafka-connector/pull/36#issuecomment-564513448
 
 
   Well if there is a good use case for it, I don't think is bad idea. However for the naming, I'd vouch for something like `ConnectRecordToMapTransformer`. I know is kinda long :D. But in IMHO it serves the purpose of the transformer and clear to the user that it extracts the connect record either a key or value to a `Map`. However, also as result, we need also to make sure the schema that being set, reflects this transformation in order to make it compatible with non-camel kafka connectors as well. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services