You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by ps...@apache.org on 2011/01/01 22:45:36 UTC
svn commit: r1054298 - in /commons/proper/math:
branches/MATH_2_X/src/main/java/org/apache/commons/math/distribution/GammaDistributionImpl.java
trunk/src/main/java/org/apache/commons/math/distribution/GammaDistributionImpl.java
Author: psteitz
Date: Sat Jan 1 21:45:35 2011
New Revision: 1054298
URL: http://svn.apache.org/viewvc?rev=1054298&view=rev
Log:
Fixed checkstyle errors: hidden field, missing javadoc.
Modified:
commons/proper/math/branches/MATH_2_X/src/main/java/org/apache/commons/math/distribution/GammaDistributionImpl.java
commons/proper/math/trunk/src/main/java/org/apache/commons/math/distribution/GammaDistributionImpl.java
Modified: commons/proper/math/branches/MATH_2_X/src/main/java/org/apache/commons/math/distribution/GammaDistributionImpl.java
URL: http://svn.apache.org/viewvc/commons/proper/math/branches/MATH_2_X/src/main/java/org/apache/commons/math/distribution/GammaDistributionImpl.java?rev=1054298&r1=1054297&r2=1054298&view=diff
==============================================================================
--- commons/proper/math/branches/MATH_2_X/src/main/java/org/apache/commons/math/distribution/GammaDistributionImpl.java (original)
+++ commons/proper/math/branches/MATH_2_X/src/main/java/org/apache/commons/math/distribution/GammaDistributionImpl.java Sat Jan 1 21:45:35 2011
@@ -351,15 +351,21 @@ public class GammaDistributionImpl exten
*/
@Override
protected double calculateNumericalVariance() {
- final double beta = getBeta();
- return getAlpha() * beta * beta;
+ final double b = getBeta();
+ return getAlpha() * b * b;
}
+ /**
+ * {@inheritDoc}
+ */
@Override
public boolean isSupportLowerBoundInclusive() {
return true;
}
+ /**
+ * {@inheritDoc}
+ */
@Override
public boolean isSupportUpperBoundInclusive() {
return false;
Modified: commons/proper/math/trunk/src/main/java/org/apache/commons/math/distribution/GammaDistributionImpl.java
URL: http://svn.apache.org/viewvc/commons/proper/math/trunk/src/main/java/org/apache/commons/math/distribution/GammaDistributionImpl.java?rev=1054298&r1=1054297&r2=1054298&view=diff
==============================================================================
--- commons/proper/math/trunk/src/main/java/org/apache/commons/math/distribution/GammaDistributionImpl.java (original)
+++ commons/proper/math/trunk/src/main/java/org/apache/commons/math/distribution/GammaDistributionImpl.java Sat Jan 1 21:45:35 2011
@@ -288,15 +288,21 @@ public class GammaDistributionImpl exten
*/
@Override
protected double calculateNumericalVariance() {
- final double beta = getBeta();
- return getAlpha() * beta * beta;
+ final double b = getBeta();
+ return getAlpha() * b * b;
}
+ /**
+ * {@inheritDoc}
+ */
@Override
public boolean isSupportLowerBoundInclusive() {
return true;
}
+ /**
+ * {@inheritDoc}
+ */
@Override
public boolean isSupportUpperBoundInclusive() {
return false;
Re: svn commit: r1054298 - in /commons/proper/math:
branches/MATH_2_X/src/main/java/org/apache/commons/math/distribution/GammaDistributionImpl.java
trunk/src/main/java/org/apache/commons/math/distribution/GammaDistributionImpl.java
Posted by Phil Steitz <ph...@gmail.com>.
On Sat, Jan 1, 2011 at 5:04 PM, Mikkel Meyer Andersen <mi...@mikl.dk> wrote:
> Hi,
>
> Phil, thanks for all these corrections and sorry for all the checkstyle
> mistakes. I'll see to that it doesn't happen again. I'll try to fix trunk
> in
> the following days.
>
> No problem. Just trying to clean up for 2.2 release.
Phil
> Cheers, Mikkel.
> Den 01/01/2011 22.45 skrev <ps...@apache.org>:
> > Author: psteitz
> > Date: Sat Jan 1 21:45:35 2011
> > New Revision: 1054298
> >
> > URL: http://svn.apache.org/viewvc?rev=1054298&view=rev
> > Log:
> > Fixed checkstyle errors: hidden field, missing javadoc.
> >
> > Modified:
> >
>
> commons/proper/math/branches/MATH_2_X/src/main/java/org/apache/commons/math/distribution/GammaDistributionImpl.java
> >
>
> commons/proper/math/trunk/src/main/java/org/apache/commons/math/distribution/GammaDistributionImpl.java
> >
> > Modified:
>
> commons/proper/math/branches/MATH_2_X/src/main/java/org/apache/commons/math/distribution/GammaDistributionImpl.java
> > URL:
>
> http://svn.apache.org/viewvc/commons/proper/math/branches/MATH_2_X/src/main/java/org/apache/commons/math/distribution/GammaDistributionImpl.java?rev=1054298&r1=1054297&r2=1054298&view=diff
> >
>
> ==============================================================================
> > ---
>
> commons/proper/math/branches/MATH_2_X/src/main/java/org/apache/commons/math/distribution/GammaDistributionImpl.java
> (original)
> > +++
>
> commons/proper/math/branches/MATH_2_X/src/main/java/org/apache/commons/math/distribution/GammaDistributionImpl.java
> Sat Jan 1 21:45:35 2011
> > @@ -351,15 +351,21 @@ public class GammaDistributionImpl exten
> > */
> > @Override
> > protected double calculateNumericalVariance() {
> > - final double beta = getBeta();
> > - return getAlpha() * beta * beta;
> > + final double b = getBeta();
> > + return getAlpha() * b * b;
> > }
> >
> > + /**
> > + * {@inheritDoc}
> > + */
> > @Override
> > public boolean isSupportLowerBoundInclusive() {
> > return true;
> > }
> >
> > + /**
> > + * {@inheritDoc}
> > + */
> > @Override
> > public boolean isSupportUpperBoundInclusive() {
> > return false;
> >
> > Modified:
>
> commons/proper/math/trunk/src/main/java/org/apache/commons/math/distribution/GammaDistributionImpl.java
> > URL:
>
> http://svn.apache.org/viewvc/commons/proper/math/trunk/src/main/java/org/apache/commons/math/distribution/GammaDistributionImpl.java?rev=1054298&r1=1054297&r2=1054298&view=diff
> >
>
> ==============================================================================
> > ---
>
> commons/proper/math/trunk/src/main/java/org/apache/commons/math/distribution/GammaDistributionImpl.java
> (original)
> > +++
>
> commons/proper/math/trunk/src/main/java/org/apache/commons/math/distribution/GammaDistributionImpl.java
> Sat Jan 1 21:45:35 2011
> > @@ -288,15 +288,21 @@ public class GammaDistributionImpl exten
> > */
> > @Override
> > protected double calculateNumericalVariance() {
> > - final double beta = getBeta();
> > - return getAlpha() * beta * beta;
> > + final double b = getBeta();
> > + return getAlpha() * b * b;
> > }
> >
> > + /**
> > + * {@inheritDoc}
> > + */
> > @Override
> > public boolean isSupportLowerBoundInclusive() {
> > return true;
> > }
> >
> > + /**
> > + * {@inheritDoc}
> > + */
> > @Override
> > public boolean isSupportUpperBoundInclusive() {
> > return false;
> >
> >
>
Re: svn commit: r1054298 - in /commons/proper/math:
branches/MATH_2_X/src/main/java/org/apache/commons/math/distribution/GammaDistributionImpl.java
trunk/src/main/java/org/apache/commons/math/distribution/GammaDistributionImpl.java
Posted by Mikkel Meyer Andersen <mi...@mikl.dk>.
Hi,
Phil, thanks for all these corrections and sorry for all the checkstyle
mistakes. I'll see to that it doesn't happen again. I'll try to fix trunk in
the following days.
Cheers, Mikkel.
Den 01/01/2011 22.45 skrev <ps...@apache.org>:
> Author: psteitz
> Date: Sat Jan 1 21:45:35 2011
> New Revision: 1054298
>
> URL: http://svn.apache.org/viewvc?rev=1054298&view=rev
> Log:
> Fixed checkstyle errors: hidden field, missing javadoc.
>
> Modified:
>
commons/proper/math/branches/MATH_2_X/src/main/java/org/apache/commons/math/distribution/GammaDistributionImpl.java
>
commons/proper/math/trunk/src/main/java/org/apache/commons/math/distribution/GammaDistributionImpl.java
>
> Modified:
commons/proper/math/branches/MATH_2_X/src/main/java/org/apache/commons/math/distribution/GammaDistributionImpl.java
> URL:
http://svn.apache.org/viewvc/commons/proper/math/branches/MATH_2_X/src/main/java/org/apache/commons/math/distribution/GammaDistributionImpl.java?rev=1054298&r1=1054297&r2=1054298&view=diff
>
==============================================================================
> ---
commons/proper/math/branches/MATH_2_X/src/main/java/org/apache/commons/math/distribution/GammaDistributionImpl.java
(original)
> +++
commons/proper/math/branches/MATH_2_X/src/main/java/org/apache/commons/math/distribution/GammaDistributionImpl.java
Sat Jan 1 21:45:35 2011
> @@ -351,15 +351,21 @@ public class GammaDistributionImpl exten
> */
> @Override
> protected double calculateNumericalVariance() {
> - final double beta = getBeta();
> - return getAlpha() * beta * beta;
> + final double b = getBeta();
> + return getAlpha() * b * b;
> }
>
> + /**
> + * {@inheritDoc}
> + */
> @Override
> public boolean isSupportLowerBoundInclusive() {
> return true;
> }
>
> + /**
> + * {@inheritDoc}
> + */
> @Override
> public boolean isSupportUpperBoundInclusive() {
> return false;
>
> Modified:
commons/proper/math/trunk/src/main/java/org/apache/commons/math/distribution/GammaDistributionImpl.java
> URL:
http://svn.apache.org/viewvc/commons/proper/math/trunk/src/main/java/org/apache/commons/math/distribution/GammaDistributionImpl.java?rev=1054298&r1=1054297&r2=1054298&view=diff
>
==============================================================================
> ---
commons/proper/math/trunk/src/main/java/org/apache/commons/math/distribution/GammaDistributionImpl.java
(original)
> +++
commons/proper/math/trunk/src/main/java/org/apache/commons/math/distribution/GammaDistributionImpl.java
Sat Jan 1 21:45:35 2011
> @@ -288,15 +288,21 @@ public class GammaDistributionImpl exten
> */
> @Override
> protected double calculateNumericalVariance() {
> - final double beta = getBeta();
> - return getAlpha() * beta * beta;
> + final double b = getBeta();
> + return getAlpha() * b * b;
> }
>
> + /**
> + * {@inheritDoc}
> + */
> @Override
> public boolean isSupportLowerBoundInclusive() {
> return true;
> }
>
> + /**
> + * {@inheritDoc}
> + */
> @Override
> public boolean isSupportUpperBoundInclusive() {
> return false;
>
>