You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Erik Hatcher (JIRA)" <ji...@apache.org> on 2011/08/18 21:44:29 UTC
[jira] [Created] (SOLR-2718) Lazy load response writers
Lazy load response writers
--------------------------
Key: SOLR-2718
URL: https://issues.apache.org/jira/browse/SOLR-2718
Project: Solr
Issue Type: Improvement
Components: Response Writers
Reporter: Erik Hatcher
This stems from issues with SOLR-2588, moving the Velocity response writer back to contrib. We still want the example app to use the VelocityResponseWriter for the /browse interface. Many of Solr's core tests use the example Solr configuration. There are other contribs that are brought into the example app (extract, clustering, DIH, for examples) but these are request handlers that lazy load. Response writers don't currently lazy load, thus causing core tests that use the example config to fail unless "ant dist" is run.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (SOLR-2718) Lazy load response writers
Posted by "Erik Hatcher (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Erik Hatcher updated SOLR-2718:
-------------------------------
Fix Version/s: 4.0
Assignee: Erik Hatcher
> Lazy load response writers
> --------------------------
>
> Key: SOLR-2718
> URL: https://issues.apache.org/jira/browse/SOLR-2718
> Project: Solr
> Issue Type: Improvement
> Components: Response Writers
> Reporter: Erik Hatcher
> Assignee: Erik Hatcher
> Fix For: 4.0
>
> Attachments: SOLR-2718-velocity-test-cleanup.patch, SOLR-2718.patch
>
>
> This stems from issues with SOLR-2588, moving the Velocity response writer back to contrib. We still want the example app to use the VelocityResponseWriter for the /browse interface. Many of Solr's core tests use the example Solr configuration. There are other contribs that are brought into the example app (extract, clustering, DIH, for examples) but these are request handlers that lazy load. Response writers don't currently lazy load, thus causing core tests that use the example config to fail unless "ant dist" is run.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (SOLR-2718) Lazy load response writers
Posted by "Erik Hatcher (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Erik Hatcher updated SOLR-2718:
-------------------------------
Attachment: SOLR-2718.patch
Here's a patch that implements lazy loaded response writers, along with a test. A little bit of copy/paste/adapt from the request handler lazy loading, so perhaps worth implementing some common infrastructure for this pattern?
> Lazy load response writers
> --------------------------
>
> Key: SOLR-2718
> URL: https://issues.apache.org/jira/browse/SOLR-2718
> Project: Solr
> Issue Type: Improvement
> Components: Response Writers
> Reporter: Erik Hatcher
> Attachments: SOLR-2718.patch
>
>
> This stems from issues with SOLR-2588, moving the Velocity response writer back to contrib. We still want the example app to use the VelocityResponseWriter for the /browse interface. Many of Solr's core tests use the example Solr configuration. There are other contribs that are brought into the example app (extract, clustering, DIH, for examples) but these are request handlers that lazy load. Response writers don't currently lazy load, thus causing core tests that use the example config to fail unless "ant dist" is run.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-2718) Lazy load response writers
Posted by "Erik Hatcher (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13087247#comment-13087247 ]
Erik Hatcher commented on SOLR-2718:
------------------------------------
Another option is to adjust the tests to not use the example solr-home - there's not that many of them. I'll investigate. We still want example tested somehow, but more at an integration level than a unit level.
> Lazy load response writers
> --------------------------
>
> Key: SOLR-2718
> URL: https://issues.apache.org/jira/browse/SOLR-2718
> Project: Solr
> Issue Type: Improvement
> Components: Response Writers
> Reporter: Erik Hatcher
>
> This stems from issues with SOLR-2588, moving the Velocity response writer back to contrib. We still want the example app to use the VelocityResponseWriter for the /browse interface. Many of Solr's core tests use the example Solr configuration. There are other contribs that are brought into the example app (extract, clustering, DIH, for examples) but these are request handlers that lazy load. Response writers don't currently lazy load, thus causing core tests that use the example config to fail unless "ant dist" is run.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Resolved] (SOLR-2718) Lazy load response writers
Posted by "Erik Hatcher (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Erik Hatcher resolved SOLR-2718.
--------------------------------
Resolution: Fixed
> Lazy load response writers
> --------------------------
>
> Key: SOLR-2718
> URL: https://issues.apache.org/jira/browse/SOLR-2718
> Project: Solr
> Issue Type: Improvement
> Components: Response Writers
> Reporter: Erik Hatcher
> Assignee: Erik Hatcher
> Fix For: 4.0
>
> Attachments: SOLR-2718-velocity-test-cleanup.patch, SOLR-2718.patch
>
>
> This stems from issues with SOLR-2588, moving the Velocity response writer back to contrib. We still want the example app to use the VelocityResponseWriter for the /browse interface. Many of Solr's core tests use the example Solr configuration. There are other contribs that are brought into the example app (extract, clustering, DIH, for examples) but these are request handlers that lazy load. Response writers don't currently lazy load, thus causing core tests that use the example config to fail unless "ant dist" is run.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (SOLR-2718) Lazy load response writers
Posted by "Erik Hatcher (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Erik Hatcher updated SOLR-2718:
-------------------------------
Attachment: SOLR-2718-velocity-test-cleanup.patch
Here's a patch to clean up the hack made for SOLR-2588 due to the example configuration using the VelocityResponseWriter but it not (necessarily) built when tests are run. With lazy loaded response writers, no worries now.
> Lazy load response writers
> --------------------------
>
> Key: SOLR-2718
> URL: https://issues.apache.org/jira/browse/SOLR-2718
> Project: Solr
> Issue Type: Improvement
> Components: Response Writers
> Reporter: Erik Hatcher
> Attachments: SOLR-2718-velocity-test-cleanup.patch, SOLR-2718.patch
>
>
> This stems from issues with SOLR-2588, moving the Velocity response writer back to contrib. We still want the example app to use the VelocityResponseWriter for the /browse interface. Many of Solr's core tests use the example Solr configuration. There are other contribs that are brought into the example app (extract, clustering, DIH, for examples) but these are request handlers that lazy load. Response writers don't currently lazy load, thus causing core tests that use the example config to fail unless "ant dist" is run.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (SOLR-2718) Lazy load response writers
Posted by "Erik Hatcher (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Erik Hatcher updated SOLR-2718:
-------------------------------
Fix Version/s: 3.6
Fixed already on 4.0, but needs to be ported to 3.x too.
> Lazy load response writers
> --------------------------
>
> Key: SOLR-2718
> URL: https://issues.apache.org/jira/browse/SOLR-2718
> Project: Solr
> Issue Type: Improvement
> Components: Response Writers
> Reporter: Erik Hatcher
> Assignee: Erik Hatcher
> Fix For: 3.6, 4.0
>
> Attachments: SOLR-2718-velocity-test-cleanup.patch, SOLR-2718.patch
>
>
> This stems from issues with SOLR-2588, moving the Velocity response writer back to contrib. We still want the example app to use the VelocityResponseWriter for the /browse interface. Many of Solr's core tests use the example Solr configuration. There are other contribs that are brought into the example app (extract, clustering, DIH, for examples) but these are request handlers that lazy load. Response writers don't currently lazy load, thus causing core tests that use the example config to fail unless "ant dist" is run.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Reopened] (SOLR-2718) Lazy load response writers
Posted by "Erik Hatcher (Reopened) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Erik Hatcher reopened SOLR-2718:
--------------------------------
I've seen two reports from Solr 3.5 users today (via #solr in IRC) where they've deployed Solr into Tomcat and copied the example configuration. The lazy loading was not backported to 3.x and thus the registration of VRW causes a startup error when the libs aren't found.
This needs to be ported/adapted to 3.x to ensure 3.6 doesn't have this issue.
> Lazy load response writers
> --------------------------
>
> Key: SOLR-2718
> URL: https://issues.apache.org/jira/browse/SOLR-2718
> Project: Solr
> Issue Type: Improvement
> Components: Response Writers
> Reporter: Erik Hatcher
> Assignee: Erik Hatcher
> Fix For: 4.0
>
> Attachments: SOLR-2718-velocity-test-cleanup.patch, SOLR-2718.patch
>
>
> This stems from issues with SOLR-2588, moving the Velocity response writer back to contrib. We still want the example app to use the VelocityResponseWriter for the /browse interface. Many of Solr's core tests use the example Solr configuration. There are other contribs that are brought into the example app (extract, clustering, DIH, for examples) but these are request handlers that lazy load. Response writers don't currently lazy load, thus causing core tests that use the example config to fail unless "ant dist" is run.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Assigned] (SOLR-2718) Lazy load response writers
Posted by "Steven Rowe (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Steven Rowe reassigned SOLR-2718:
---------------------------------
Assignee: Steven Rowe (was: Erik Hatcher)
> Lazy load response writers
> --------------------------
>
> Key: SOLR-2718
> URL: https://issues.apache.org/jira/browse/SOLR-2718
> Project: Solr
> Issue Type: Improvement
> Components: Response Writers
> Reporter: Erik Hatcher
> Assignee: Steven Rowe
> Fix For: 3.6, 4.0
>
> Attachments: SOLR-2718-velocity-test-cleanup.patch, SOLR-2718.patch
>
>
> This stems from issues with SOLR-2588, moving the Velocity response writer back to contrib. We still want the example app to use the VelocityResponseWriter for the /browse interface. Many of Solr's core tests use the example Solr configuration. There are other contribs that are brought into the example app (extract, clustering, DIH, for examples) but these are request handlers that lazy load. Response writers don't currently lazy load, thus causing core tests that use the example config to fail unless "ant dist" is run.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Resolved] (SOLR-2718) Lazy load response writers
Posted by "Steven Rowe (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Steven Rowe resolved SOLR-2718.
-------------------------------
Resolution: Fixed
Backported to branch_3x and committed.
> Lazy load response writers
> --------------------------
>
> Key: SOLR-2718
> URL: https://issues.apache.org/jira/browse/SOLR-2718
> Project: Solr
> Issue Type: Improvement
> Components: Response Writers
> Reporter: Erik Hatcher
> Assignee: Steven Rowe
> Fix For: 3.6, 4.0
>
> Attachments: SOLR-2718-velocity-test-cleanup.patch, SOLR-2718.patch
>
>
> This stems from issues with SOLR-2588, moving the Velocity response writer back to contrib. We still want the example app to use the VelocityResponseWriter for the /browse interface. Many of Solr's core tests use the example Solr configuration. There are other contribs that are brought into the example app (extract, clustering, DIH, for examples) but these are request handlers that lazy load. Response writers don't currently lazy load, thus causing core tests that use the example config to fail unless "ant dist" is run.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org