RE: checkstyle patches

[Vincent Massol <vm...@pivolis.com>]

Hi Thomas,

- I have applied the patch for issue 1. 
- I don't understand issue 2.
- For issues 3 and 4 you seem to be modifying the checkstyle framework
itself? If this is so your patch should be sent to the checkstyle dev
mailing list. There is no java source code in the checkstyle plugin.

Thanks
-Vincent

-----Original Message-----
From: Diesler,Thomas [mailto:Thomas.Diesler@softcon.de] 
Sent: 04 June 2003 13:30
To: 'vmassol@pivolis.com'
Subject: checkstyle patches

Hi Vincent,
 
here some feedback on the latest checkstyle plugin for maven.
 
Cheers
-tomsk
 
Issues
------
1. ignores ${maven.checkstyle.excludes}
2. cannot handle multiple include/exclude patters
3. local variables and parameters in static methods do not hide members
4. RedundantThrows cannot find class defs for application exceptions
 
P A T C H E S
-------------
 
plugin.jelly:131 
 
        <ant:fileset dir="${pom.build.sourceDirectory}">
          <ant:include name="${maven.checkstyle.includes}"/>
          <ant:include name="${maven.checkstyle.excludes}"/>
        </ant:fileset>
should be
 
        <ant:fileset dir="${pom.build.sourceDirectory}" 
            includes="${maven.checkstyle.includes}" 
            excludes="${maven.checkstyle.excludes}"/>
 
************************************************************************
************************************
 
HiddenFieldCheck.java:136
 
   if (!ScopeUtils.inInterfaceBlock(aAST) && !inStaticMethod(aAST)) {
 
   /**
    * Return true if the local variable or parameter is used within a
static method
    * @param aAST a local variable or parameter
    * @return true if used in static method
    */
   private boolean inStaticMethod(DetailAST aAST) {
 
      // find method def
      DetailAST methodAST = aAST.getParent();
      while (methodAST != null && methodAST.getType() !=
TokenTypes.METHOD_DEF) {
         methodAST = methodAST.getParent();
      }
 
      if (methodAST != null) {
         DetailAST modifierAST =
methodAST.findFirstToken(TokenTypes.MODIFIERS);
         DetailAST staticAST =
modifierAST.findFirstToken(TokenTypes.LITERAL_STATIC);
         return staticAST != null;
      }
 
      return false;
   }

InputHiddenField.java:85
 
    public static void shadowStatic()
    {
        int hidden = 0; // not an error
    }
 
************************************************************************
************************************
 
The compiler finds the classes. First statement is not true.
 
Redundant throws: 'ServletException' is subclass of 'ParseException'.
Redundant throws: 'IOException' is subclass of
'ServiceDelegateException'.
Unable to get class information for ServiceDelegateException.
----------------------------------------------------------
Softcon Internet Technologies GmbH
Thomas Diesler
email: thomas.diesler@softcon-itec.de
 
 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org