You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Brock Noland <br...@cloudera.com> on 2013/11/18 17:49:48 UTC
Review Request 15649: HIVE-5842 - Fix issues with new paths to jar in
hcatalog
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15649/
-----------------------------------------------------------
Review request for hive.
Bugs: HIVE-5842
https://issues.apache.org/jira/browse/HIVE-5842
Repository: hive-git
Description
-------
Fixes path issues with hcatalog in maven tarball post mavenization.
Also removes a comical amount of trailing whitespace in hcat scripts.
Diffs
-----
hcatalog/bin/hcat b4d4226
hcatalog/bin/hcat.py 53fc387
hcatalog/bin/hcat_server.py 51a11e6
hcatalog/bin/hcat_server.sh bf3c3f1
hcatalog/bin/hcatcfg.py 47a56d8
hcatalog/webhcat/svr/src/main/bin/webhcat_config.sh 6b0b578
hcatalog/webhcat/svr/src/main/bin/webhcat_server.sh 600c16d
Diff: https://reviews.apache.org/r/15649/diff/
Testing
-------
Tested hcat scripts manually
Thanks,
Brock Noland
Re: Review Request 15649: HIVE-5842 - Fix issues with new paths to jar in
hcatalog
Posted by Brock Noland <br...@cloudera.com>.
> On Nov. 19, 2013, 12:36 a.m., Mohammad Islam wrote:
> > +1 (with minor comments)
Thank you for the review! I noted many cleanup opportunities as well... I have created HIVE-5852 to track that issue.
- Brock
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15649/#review29087
-----------------------------------------------------------
On Nov. 18, 2013, 4:49 p.m., Brock Noland wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15649/
> -----------------------------------------------------------
>
> (Updated Nov. 18, 2013, 4:49 p.m.)
>
>
> Review request for hive.
>
>
> Bugs: HIVE-5842
> https://issues.apache.org/jira/browse/HIVE-5842
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Fixes path issues with hcatalog in maven tarball post mavenization.
>
> Also removes a comical amount of trailing whitespace in hcat scripts.
>
>
> Diffs
> -----
>
> hcatalog/bin/hcat b4d4226
> hcatalog/bin/hcat.py 53fc387
> hcatalog/bin/hcat_server.py 51a11e6
> hcatalog/bin/hcat_server.sh bf3c3f1
> hcatalog/bin/hcatcfg.py 47a56d8
> hcatalog/webhcat/svr/src/main/bin/webhcat_config.sh 6b0b578
> hcatalog/webhcat/svr/src/main/bin/webhcat_server.sh 600c16d
>
> Diff: https://reviews.apache.org/r/15649/diff/
>
>
> Testing
> -------
>
> Tested hcat scripts manually
>
>
> Thanks,
>
> Brock Noland
>
>
Re: Review Request 15649: HIVE-5842 - Fix issues with new paths to jar in
hcatalog
Posted by Mohammad Islam <mi...@yahoo.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15649/#review29087
-----------------------------------------------------------
+1 (with minor comments)
hcatalog/bin/hcat
<https://reviews.apache.org/r/15649/#comment56209>
Same as above: Create a new variable and use it.
hcatalog/bin/hcat.py
<https://reviews.apache.org/r/15649/#comment56208>
If possible, creating a variable and use the variable would make it much better.|
- Mohammad Islam
On Nov. 18, 2013, 4:49 p.m., Brock Noland wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15649/
> -----------------------------------------------------------
>
> (Updated Nov. 18, 2013, 4:49 p.m.)
>
>
> Review request for hive.
>
>
> Bugs: HIVE-5842
> https://issues.apache.org/jira/browse/HIVE-5842
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Fixes path issues with hcatalog in maven tarball post mavenization.
>
> Also removes a comical amount of trailing whitespace in hcat scripts.
>
>
> Diffs
> -----
>
> hcatalog/bin/hcat b4d4226
> hcatalog/bin/hcat.py 53fc387
> hcatalog/bin/hcat_server.py 51a11e6
> hcatalog/bin/hcat_server.sh bf3c3f1
> hcatalog/bin/hcatcfg.py 47a56d8
> hcatalog/webhcat/svr/src/main/bin/webhcat_config.sh 6b0b578
> hcatalog/webhcat/svr/src/main/bin/webhcat_server.sh 600c16d
>
> Diff: https://reviews.apache.org/r/15649/diff/
>
>
> Testing
> -------
>
> Tested hcat scripts manually
>
>
> Thanks,
>
> Brock Noland
>
>
Re: Review Request 15649: HIVE-5842 - Fix issues with new paths to jar in
hcatalog
Posted by Prasad Mujumdar <pr...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15649/#review29122
-----------------------------------------------------------
Ship it!
+1
LGTM.
- Prasad Mujumdar
On Nov. 18, 2013, 4:49 p.m., Brock Noland wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15649/
> -----------------------------------------------------------
>
> (Updated Nov. 18, 2013, 4:49 p.m.)
>
>
> Review request for hive.
>
>
> Bugs: HIVE-5842
> https://issues.apache.org/jira/browse/HIVE-5842
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Fixes path issues with hcatalog in maven tarball post mavenization.
>
> Also removes a comical amount of trailing whitespace in hcat scripts.
>
>
> Diffs
> -----
>
> hcatalog/bin/hcat b4d4226
> hcatalog/bin/hcat.py 53fc387
> hcatalog/bin/hcat_server.py 51a11e6
> hcatalog/bin/hcat_server.sh bf3c3f1
> hcatalog/bin/hcatcfg.py 47a56d8
> hcatalog/webhcat/svr/src/main/bin/webhcat_config.sh 6b0b578
> hcatalog/webhcat/svr/src/main/bin/webhcat_server.sh 600c16d
>
> Diff: https://reviews.apache.org/r/15649/diff/
>
>
> Testing
> -------
>
> Tested hcat scripts manually
>
>
> Thanks,
>
> Brock Noland
>
>