[jira] [Commented] (WICKET-6890) Render debug setting 'outputMarkupContainerClassName` as an attribute

["ASF subversion and git services (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/WICKET-6890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17353122#comment-17353122 ] 

ASF subversion and git services commented on WICKET-6890:
---------------------------------------------------------

Commit 8bbf158ebc4d12f3b317c0d607200441c0767162 in wicket's branch refs/heads/master from Martin Tzvetanov Grigorov
[ https://gitbox.apache.org/repos/asf?p=wicket.git;h=8bbf158 ]

WICKET-6890 Render debug setting 'outputMarkupContainerClassName` as an attribute


> Render debug setting 'outputMarkupContainerClassName` as an attribute
> ---------------------------------------------------------------------
>
>                 Key: WICKET-6890
>                 URL: https://issues.apache.org/jira/browse/WICKET-6890
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket-core
>            Reporter: Martin Tzvetanov Grigorov
>            Assignee: Martin Tzvetanov Grigorov
>            Priority: Major
>
> As discussed at [https://markmail.org/message/uoxxlnbz56ex7vuk] when org.apache.wicket.settings.DebugSettings#isOutputMarkupContainerClassName() returns true then the MarkupContainer class name should be rendered as an attribute of the component tag instead of as an HTML comment because an HTML comment may break a CSS rule, e.g. by appearing between two sibling HTML elements
> {code:java}
> p + p {color: red;} {code}
>  
> The CSS rule above will change the text color of any paragraph that follows another paragraph. But if an HTML comment appears between them then the rule won't apply.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)