You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/03/14 09:02:10 UTC
[GitHub] [cloudstack] weizhouapache opened a new pull request #6113: travis: run nosetests-2.7
weizhouapache opened a new pull request #6113:
URL: https://github.com/apache/cloudstack/pull/6113
### Description
This PR fixes #6097
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on a change in pull request #6113: travis: run nosetests-2.7
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on a change in pull request #6113:
URL: https://github.com/apache/cloudstack/pull/6113#discussion_r825746098
##########
File path: tools/travis/script.sh
##########
@@ -30,7 +30,7 @@ set -e
for suite in "${TESTS[@]}" ; do
echo "Currently running test: $suite"
- time nosetests --with-xunit --xunit-file=integration-test-results/$suite.xml --with-marvin --marvin-config=setup/dev/advanced.cfg test/integration/$suite.py -s -a tags=advanced,required_hardware=false --zone=Sandbox-simulator --hypervisor=simulator || true ;
+ time nosetests-2.7 --with-xunit --xunit-file=integration-test-results/$suite.xml --with-marvin --marvin-config=setup/dev/advanced.cfg test/integration/$suite.py -s -a tags=advanced,required_hardware=false --zone=Sandbox-simulator --hypervisor=simulator || true ;
Review comment:
@weizhouapache should this be nosetests-3.4? We moved to python3, so we should ensure to install dependencies via pip3 and run tests using nosetests-3.4?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on a change in pull request #6113: travis: run nosetests-2.7
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on a change in pull request #6113:
URL: https://github.com/apache/cloudstack/pull/6113#discussion_r825755133
##########
File path: tools/travis/script.sh
##########
@@ -30,7 +30,7 @@ set -e
for suite in "${TESTS[@]}" ; do
echo "Currently running test: $suite"
- time nosetests --with-xunit --xunit-file=integration-test-results/$suite.xml --with-marvin --marvin-config=setup/dev/advanced.cfg test/integration/$suite.py -s -a tags=advanced,required_hardware=false --zone=Sandbox-simulator --hypervisor=simulator || true ;
+ time nosetests-2.7 --with-xunit --xunit-file=integration-test-results/$suite.xml --with-marvin --marvin-config=setup/dev/advanced.cfg test/integration/$suite.py -s -a tags=advanced,required_hardware=false --zone=Sandbox-simulator --hypervisor=simulator || true ;
Review comment:
@rohityadavcloud
yes, the travis test still failed. it should be nosetest-3.4
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez closed pull request #6113: travis: run nosetests-3.4
Posted by GitBox <gi...@apache.org>.
nvazquez closed pull request #6113:
URL: https://github.com/apache/cloudstack/pull/6113
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #6113: travis: run nosetests-3.4
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #6113:
URL: https://github.com/apache/cloudstack/pull/6113#issuecomment-1066684684
looks good now
```
$ travis_wait 40 ./tools/travis/script.sh ${TESTS}
Still running (1 of 40): ./tools/travis/script.sh smoke/test_certauthority_root
The command ./tools/travis/script.sh smoke/test_certauthority_root exited with 0.
Log:
Running tests: smoke/test_certauthority_root
Currently running test: smoke/test_certauthority_root
==== Marvin Init Started ====
=== Marvin Parse Config Successful ===
=== Marvin Setting TestData Successful===
==== Log Folder Path: /tmp/MarvinLogs/Mar_14_2022_10_19_30_A4ODM8 All logs will be available here ====
=== Marvin Init Logging Successful===
==== Marvin Init Successful ====
=== TestName: test_issue_certificate_with_csr | Status : SUCCESS ===
=== TestName: test_issue_certificate_without_csr | Status : SUCCESS ===
=== TestName: test_list_ca_certificate | Status : SUCCESS ===
=== TestName: test_list_ca_providers | Status : SUCCESS ===
=== TestName: test_revoke_certificate | Status : SUCCESS ===
=== Final results are now copied to: /tmp/MarvinLogs/test_certauthority_root_XXWD3Y ===
real 0m4.441s
user 0m0.833s
sys 0m0.075s
+------+--------+------+-----------+
| Test | Result | Time | Test file |
+======+========+======+===========+
+------+--------+------+-----------+
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez merged pull request #6113: travis: run nosetests-3.4
Posted by GitBox <gi...@apache.org>.
nvazquez merged pull request #6113:
URL: https://github.com/apache/cloudstack/pull/6113
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #6113: travis: run nosetests-3.4
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #6113:
URL: https://github.com/apache/cloudstack/pull/6113#issuecomment-1066699626
Thanks @weizhouapache - had closed/opened to kick Travis again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache edited a comment on pull request #6113: travis: run nosetests-3.4
Posted by GitBox <gi...@apache.org>.
weizhouapache edited a comment on pull request #6113:
URL: https://github.com/apache/cloudstack/pull/6113#issuecomment-1066812747
@nvazquez
travis test still failed - but it is NOT related to this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #6113: travis: run nosetests-3.4
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #6113:
URL: https://github.com/apache/cloudstack/pull/6113#issuecomment-1066812747
@nvazquez
travis test still failed - but it is related to this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org