Re: svn commit: rev 1700 - trunk/subversion/clients/cmdline

[Branko Čibej <br...@xbc.nu>]

striker@tigris.org wrote:

>Author: striker
>Date: 2002-04-14 09:14 GMT
>New Revision: 1700
>
>Modified:
>   trunk/subversion/clients/cmdline/main.c
>Log:
>Wow, it took a lot of people to come up with something simple
>like this ;)
>
>Submitted by:   C. Micheal Pilato
>Suggestions by: Karl Fogel, Peter Mathiasson <pe...@mathiasson.nu>
>Tweaked by:     Sander Striker
>
>* subversion/clients/cmdline/main.c
>
>  (format_option): Add a comment.  Neatly line up the
>    doc strings.
>
>
>Modified: trunk/subversion/clients/cmdline/main.c
>==============================================================================
>--- trunk/subversion/clients/cmdline/main.c	(original)
>+++ trunk/subversion/clients/cmdline/main.c	Sun Apr 14 04:14:12 2002
>@@ -358,6 +358,8 @@
>       return;
>     }
> 
>+  /* We have a valid option which may or may not have a "short
>+     name" (a single-character alias for the long option). */
>   if (opt->optch <= 255)  
>     opts = apr_psprintf (pool, "-%c [--%s]", opt->optch, opt->name);
>   else
>@@ -365,9 +367,9 @@
> 
>   if (opt->has_arg)
>     opts = apr_pstrcat (pool, opts, " arg", NULL);
>-  
>+
>   if (doc)
>-    opts = apr_pstrcat (pool, opts, ":\t", opt->description, NULL);
>+    opts = apr_psprintf (pool, "%-24s : %s", opts, opt->description);
> 
>   *string = opts;
> }
>

Which broke getopt-test.py. What-s with our famous "make check" policy, 
then? :-)

/me is putting up a nightly make-check cron job tomorrow


-- 
Brane Čibej   <br...@xbc.nu>   http://www.xbc.nu/brane/




---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

RE: svn commit: rev 1700 - trunk/subversion/clients/cmdline

[Sander Striker <st...@apache.org>]

> From: Branko Cibej [mailto:brane@xbc.nu]
> Sent: 14 April 2002 21:10

>>Author: striker
>>Date: 2002-04-14 09:14 GMT
>>New Revision: 1700
>>
>>Modified:
>>   trunk/subversion/clients/cmdline/main.c
>>Log:
>>Wow, it took a lot of people to come up with something simple
>>like this ;)
>>
>>Submitted by:   C. Micheal Pilato
>>Suggestions by: Karl Fogel, Peter Mathiasson <pe...@mathiasson.nu>
>>Tweaked by:     Sander Striker
>>
>>* subversion/clients/cmdline/main.c
>>
>>  (format_option): Add a comment.  Neatly line up the
>>    doc strings.
[...]

> 
> Which broke getopt-test.py. What-s with our famous "make check" policy, 
> then? :-)

*grin*  I deemed this so harmless that I didn't run the test suite
for this :(

Damn, make check is thourough ;)

> /me is putting up a nightly make-check cron job tomorrow

Ah, great!


Sander


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org