You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Michael Smith (Code Review)" <ge...@cloudera.org> on 2024/03/06 22:18:52 UTC
[Impala-ASF-CR] IMPALA-12878: Report invalid query if finalized
Michael Smith has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21110
Change subject: IMPALA-12878: Report invalid query if finalized
......................................................................
IMPALA-12878: Report invalid query if finalized
Fixes a case introduced by IMPALA-12493 where a query is closed again in
the middle of unregistering - which appears to be possible with
cancel_query_and_validate_state - returns "Query not yet running"
instead of "Invalid or unknown query handle".
IMPALA-12493 moved checks for whether a query is inflight before an
atomic CompareAndSwap to mark a QueryDriver as finalized. As part of
that change, a query that was Finalized and removed from
inflight_queries - but not yet removed from query_driver_map_ - could
report "Query not yet running". Updates the check for that error to also
verify the query has not been finalized; if it has, we let the next
conditional handle that case and return "Invalid or unknown query
handle".
Also ensures cancelled queries are closed in test_web_pages tests so
assertions that num_in_flight_queries == 0 at the start of tests are
valid when running the whole suite serially. This doesn't come up in
automated tests because the cases that care about that assertion are
marked execute_serially, while the cases that failed to close a query
were not.
Change-Id: I3bf910f499147a09352f9dcb755037b0d8616dfd
---
M be/src/runtime/query-driver.cc
M tests/webserver/test_web_pages.py
2 files changed, 5 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/10/21110/1
--
To view, visit http://gerrit.cloudera.org:8080/21110
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3bf910f499147a09352f9dcb755037b0d8616dfd
Gerrit-Change-Number: 21110
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-12878: Report invalid query if finalized
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21110 )
Change subject: IMPALA-12878: Report invalid query if finalized
......................................................................
Patch Set 7: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/21110
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3bf910f499147a09352f9dcb755037b0d8616dfd
Gerrit-Change-Number: 21110
Gerrit-PatchSet: 7
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 07 Mar 2024 19:58:35 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12878: Report invalid query if finalized
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21110 )
Change subject: IMPALA-12878: Report invalid query if finalized
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/21110/1/be/src/runtime/query-driver.cc
File be/src/runtime/query-driver.cc:
http://gerrit.cloudera.org:8080/#/c/21110/1/be/src/runtime/query-driver.cc@502
PS1, Line 502: }
:
Can inject SLEEP using debug_actions option or flag here after L502 to deterministically test the returned error message?
--
To view, visit http://gerrit.cloudera.org:8080/21110
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3bf910f499147a09352f9dcb755037b0d8616dfd
Gerrit-Change-Number: 21110
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Wed, 06 Mar 2024 22:25:01 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12878: Report invalid query if finalized
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21110 )
Change subject: IMPALA-12878: Report invalid query if finalized
......................................................................
Patch Set 4:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/15443/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/21110
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3bf910f499147a09352f9dcb755037b0d8616dfd
Gerrit-Change-Number: 21110
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 07 Mar 2024 18:34:31 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12878: Report invalid query if finalized
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21110 )
Change subject: IMPALA-12878: Report invalid query if finalized
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/15426/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/21110
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3bf910f499147a09352f9dcb755037b0d8616dfd
Gerrit-Change-Number: 21110
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Wed, 06 Mar 2024 22:45:25 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12878: Report invalid query if finalized
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Hello Riza Suminto, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21110
to look at the new patch set (#4).
Change subject: IMPALA-12878: Report invalid query if finalized
......................................................................
IMPALA-12878: Report invalid query if finalized
Fixes a case introduced by IMPALA-12493 where a query is closed again in
the middle of unregistering - which appears to be possible with
cancel_query_and_validate_state - returns "Query not yet running"
instead of "Invalid or unknown query handle".
IMPALA-12493 moved checks for whether a query is inflight before an
atomic CompareAndSwap to mark a QueryDriver as finalized. As part of
that change, a query that was Finalized and removed from
inflight_queries - but not yet removed from query_driver_map_ - could
report "Query not yet running". Updates the check for that error to also
verify the query has not been finalized; if it has, we let the next
conditional handle that case and return "Invalid or unknown query
handle".
Also ensures cancelled queries are closed in test_web_pages tests so
assertions that num_in_flight_queries == 0 at the start of tests are
valid when running the whole suite serially. This doesn't come up in
automated tests because the cases that care about that assertion are
marked execute_serially, while the cases that failed to close a query
were not.
Testing: adds a test to test_cancellation that ensures we get the
expected "Invalid or unknown query handle" when close() is delayed in
calling QueryDriver::Finalize.
Change-Id: I3bf910f499147a09352f9dcb755037b0d8616dfd
---
M be/src/runtime/query-driver.cc
M be/src/service/impala-server.cc
M tests/query_test/test_cancellation.py
M tests/webserver/test_web_pages.py
4 files changed, 34 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/10/21110/4
--
To view, visit http://gerrit.cloudera.org:8080/21110
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3bf910f499147a09352f9dcb755037b0d8616dfd
Gerrit-Change-Number: 21110
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
[Impala-ASF-CR] IMPALA-12878: Report invalid query if finalized
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21110 )
Change subject: IMPALA-12878: Report invalid query if finalized
......................................................................
Patch Set 6:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/15448/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/21110
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3bf910f499147a09352f9dcb755037b0d8616dfd
Gerrit-Change-Number: 21110
Gerrit-PatchSet: 6
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 07 Mar 2024 19:54:45 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12878: Report invalid query if finalized
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21110 )
Change subject: IMPALA-12878: Report invalid query if finalized
......................................................................
Patch Set 5:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/21110/4/tests/query_test/test_cancellation.py
File tests/query_test/test_cancellation.py:
http://gerrit.cloudera.org:8080/#/c/21110/4/tests/query_test/test_cancellation.py@279
PS4, Line 279:
> flake8: E302 expected 2 blank lines, found 1
Done
http://gerrit.cloudera.org:8080/#/c/21110/4/tests/query_test/test_cancellation.py@291
PS4, Line 291:
> flake8: W504 line break after binary operator
Done
--
To view, visit http://gerrit.cloudera.org:8080/21110
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3bf910f499147a09352f9dcb755037b0d8616dfd
Gerrit-Change-Number: 21110
Gerrit-PatchSet: 5
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 07 Mar 2024 18:13:15 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12878: Report invalid query if finalized
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21110 )
Change subject: IMPALA-12878: Report invalid query if finalized
......................................................................
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/21110/3/tests/query_test/test_cancellation.py
File tests/query_test/test_cancellation.py:
http://gerrit.cloudera.org:8080/#/c/21110/3/tests/query_test/test_cancellation.py@108
PS3, Line 108: cls.ImpalaTestMatrix.add_dimension(
> I think that is a good idea. Create separate test class with DELAY_FINALIZE
Done
--
To view, visit http://gerrit.cloudera.org:8080/21110
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3bf910f499147a09352f9dcb755037b0d8616dfd
Gerrit-Change-Number: 21110
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 07 Mar 2024 18:08:19 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12878: Report invalid query if finalized
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21110 )
Change subject: IMPALA-12878: Report invalid query if finalized
......................................................................
Patch Set 3:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/21110/3/tests/query_test/test_cancellation.py
File tests/query_test/test_cancellation.py:
http://gerrit.cloudera.org:8080/#/c/21110/3/tests/query_test/test_cancellation.py@108
PS3, Line 108: ImpalaTestDimension('delay_finalize_action', *DELAY_FINALIZE_ACTIONS))
> This matrix runs so many tests. I'm tempted to create a special test for th
I think that is a good idea. Create separate test class with DELAY_FINALIZE_ACTIONS fixed to 'FINALIZE_INFLIGHT_QUERY:SLEEP@10' and other dimensions constrained to single value.
http://gerrit.cloudera.org:8080/#/c/21110/3/tests/query_test/test_cancellation.py@287
PS3, Line 287: cls.ImpalaTestMatrix.add_constraint(
: lambda v: v.get_value('fail_rpc_action') == FAIL_RPC_ACTIONS[0])
> I don't get that. Not sure what's happening.
Nevermind, its a mistake on my code tree.
--
To view, visit http://gerrit.cloudera.org:8080/21110
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3bf910f499147a09352f9dcb755037b0d8616dfd
Gerrit-Change-Number: 21110
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 07 Mar 2024 01:16:12 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12878: Report invalid query if finalized
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Hello Riza Suminto, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21110
to look at the new patch set (#6).
Change subject: IMPALA-12878: Report invalid query if finalized
......................................................................
IMPALA-12878: Report invalid query if finalized
Fixes a case introduced by IMPALA-12493 where a query is closed again in
the middle of unregistering - which appears to be possible with
cancel_query_and_validate_state - returns "Query not yet running"
instead of "Invalid or unknown query handle".
IMPALA-12493 moved checks for whether a query is inflight before an
atomic CompareAndSwap to mark a QueryDriver as finalized. As part of
that change, a query that was Finalized and removed from
inflight_queries - but not yet removed from query_driver_map_ - could
report "Query not yet running". Updates the check for that error to also
verify the query has not been finalized; if it has, we let the next
conditional handle that case and return "Invalid or unknown query
handle".
Also ensures cancelled queries are closed in test_web_pages tests so
assertions that num_in_flight_queries == 0 at the start of tests are
valid when running the whole suite serially. This doesn't come up in
automated tests because the cases that care about that assertion are
marked execute_serially, while the cases that failed to close a query
were not.
Testing: adds a test to test_cancellation that ensures we get the
expected "Invalid or unknown query handle" when close() is delayed in
calling QueryDriver::Finalize.
Change-Id: I3bf910f499147a09352f9dcb755037b0d8616dfd
---
M be/src/runtime/query-driver.cc
M be/src/service/impala-server.cc
M tests/query_test/test_cancellation.py
M tests/webserver/test_web_pages.py
4 files changed, 37 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/10/21110/6
--
To view, visit http://gerrit.cloudera.org:8080/21110
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3bf910f499147a09352f9dcb755037b0d8616dfd
Gerrit-Change-Number: 21110
Gerrit-PatchSet: 6
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
[Impala-ASF-CR] IMPALA-12878: Report invalid query if finalized
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21110 )
Change subject: IMPALA-12878: Report invalid query if finalized
......................................................................
Patch Set 5:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/21110/5/tests/query_test/test_cancellation.py
File tests/query_test/test_cancellation.py:
http://gerrit.cloudera.org:8080/#/c/21110/5/tests/query_test/test_cancellation.py@288
PS5, Line 288:
> Can add the following here:
Done
--
To view, visit http://gerrit.cloudera.org:8080/21110
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3bf910f499147a09352f9dcb755037b0d8616dfd
Gerrit-Change-Number: 21110
Gerrit-PatchSet: 5
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 07 Mar 2024 19:32:21 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12878: Report invalid query if finalized
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21110 )
Change subject: IMPALA-12878: Report invalid query if finalized
......................................................................
Patch Set 6: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/21110
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3bf910f499147a09352f9dcb755037b0d8616dfd
Gerrit-Change-Number: 21110
Gerrit-PatchSet: 6
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 07 Mar 2024 19:40:15 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12878: Report invalid query if finalized
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Hello Riza Suminto, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21110
to look at the new patch set (#5).
Change subject: IMPALA-12878: Report invalid query if finalized
......................................................................
IMPALA-12878: Report invalid query if finalized
Fixes a case introduced by IMPALA-12493 where a query is closed again in
the middle of unregistering - which appears to be possible with
cancel_query_and_validate_state - returns "Query not yet running"
instead of "Invalid or unknown query handle".
IMPALA-12493 moved checks for whether a query is inflight before an
atomic CompareAndSwap to mark a QueryDriver as finalized. As part of
that change, a query that was Finalized and removed from
inflight_queries - but not yet removed from query_driver_map_ - could
report "Query not yet running". Updates the check for that error to also
verify the query has not been finalized; if it has, we let the next
conditional handle that case and return "Invalid or unknown query
handle".
Also ensures cancelled queries are closed in test_web_pages tests so
assertions that num_in_flight_queries == 0 at the start of tests are
valid when running the whole suite serially. This doesn't come up in
automated tests because the cases that care about that assertion are
marked execute_serially, while the cases that failed to close a query
were not.
Testing: adds a test to test_cancellation that ensures we get the
expected "Invalid or unknown query handle" when close() is delayed in
calling QueryDriver::Finalize.
Change-Id: I3bf910f499147a09352f9dcb755037b0d8616dfd
---
M be/src/runtime/query-driver.cc
M be/src/service/impala-server.cc
M tests/query_test/test_cancellation.py
M tests/webserver/test_web_pages.py
4 files changed, 35 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/10/21110/5
--
To view, visit http://gerrit.cloudera.org:8080/21110
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3bf910f499147a09352f9dcb755037b0d8616dfd
Gerrit-Change-Number: 21110
Gerrit-PatchSet: 5
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
[Impala-ASF-CR] IMPALA-12878: Report invalid query if finalized
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21110 )
Change subject: IMPALA-12878: Report invalid query if finalized
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/21110/1/be/src/runtime/query-driver.cc
File be/src/runtime/query-driver.cc:
http://gerrit.cloudera.org:8080/#/c/21110/1/be/src/runtime/query-driver.cc@502
PS1, Line 502: }
:
> Can inject SLEEP using debug_actions option or flag here after L502 to dete
I had to add it before line 500, and only if check_inflight is true.
What happens in the failing case is that UnregisterQuery is called twice, once due to close() and once as part of CloseSessionInternal. The sequence of events is:
1. close() invokes UnregisterQuery(check_inflight=true); it gets the active query handle from query_driver_map_, then for some reason pauses.
2. CloseSessionInternal sees the query is still inflight and calls UnregisterQuery(check_inflight=false). It executes completely, and FinishUnregisterQuery runs on another thread at least as far as CloseClientRequestState (to remove the query from inflight_queries). If it goes further that doesn't matter because (1) already has a shared_ptr<QueryDriver>.
3. The 1st UnregisterQuery resumes and calls Finalize, which then sees check_inflight=true and is_inflight()=false, so it returns "Query not yet running".
--
To view, visit http://gerrit.cloudera.org:8080/21110
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3bf910f499147a09352f9dcb755037b0d8616dfd
Gerrit-Change-Number: 21110
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Wed, 06 Mar 2024 22:50:18 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12878: Report invalid query if finalized
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21110 )
Change subject: IMPALA-12878: Report invalid query if finalized
......................................................................
Patch Set 7:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/10362/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/21110
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3bf910f499147a09352f9dcb755037b0d8616dfd
Gerrit-Change-Number: 21110
Gerrit-PatchSet: 7
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 07 Mar 2024 19:58:36 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12878: Report invalid query if finalized
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21110 )
Change subject: IMPALA-12878: Report invalid query if finalized
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/21110/3/tests/query_test/test_cancellation.py
File tests/query_test/test_cancellation.py:
http://gerrit.cloudera.org:8080/#/c/21110/3/tests/query_test/test_cancellation.py@287
PS3, Line 287: cls.ImpalaTestMatrix.add_constraint(
: lambda v: v.get_value('fail_rpc_action') == FAIL_RPC_ACTIONS[0])
> Not related with this patch, but I see this when I run exhaustive test over
I don't get that. Not sure what's happening.
--
To view, visit http://gerrit.cloudera.org:8080/21110
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3bf910f499147a09352f9dcb755037b0d8616dfd
Gerrit-Change-Number: 21110
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 07 Mar 2024 01:01:57 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12878: Report invalid query if finalized
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21110 )
Change subject: IMPALA-12878: Report invalid query if finalized
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/21110/3/tests/query_test/test_cancellation.py
File tests/query_test/test_cancellation.py:
http://gerrit.cloudera.org:8080/#/c/21110/3/tests/query_test/test_cancellation.py@108
PS3, Line 108: ImpalaTestDimension('delay_finalize_action', *DELAY_FINALIZE_ACTIONS))
This matrix runs so many tests. I'm tempted to create a special test for this case instead of adding to this. Right now exhaustive has 58292 items.
--
To view, visit http://gerrit.cloudera.org:8080/21110
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3bf910f499147a09352f9dcb755037b0d8616dfd
Gerrit-Change-Number: 21110
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 07 Mar 2024 01:01:28 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12878: Report invalid query if finalized
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21110 )
Change subject: IMPALA-12878: Report invalid query if finalized
......................................................................
Patch Set 3:
(1 comment)
Do you mind testing by running exhaustive test in your local machine?
impala-py.test --exploration=exhaustive query_test/test_cancellation.py
http://gerrit.cloudera.org:8080/#/c/21110/3/tests/query_test/test_cancellation.py
File tests/query_test/test_cancellation.py:
http://gerrit.cloudera.org:8080/#/c/21110/3/tests/query_test/test_cancellation.py@287
PS3, Line 287: cls.ImpalaTestMatrix.add_constraint(
: lambda v: v.get_value('fail_rpc_action') == FAIL_RPC_ACTIONS[0])
Not related with this patch, but I see this when I run exhaustive test over this test_cancellation.py
WARNING MainThread: No test vectors generated for test 'test_cancel_sort'. Check constraints and input vectors
Is this a bug because fail_rpc_action dimention is not specified?
--
To view, visit http://gerrit.cloudera.org:8080/21110
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3bf910f499147a09352f9dcb755037b0d8616dfd
Gerrit-Change-Number: 21110
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 07 Mar 2024 00:11:20 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12878: Report invalid query if finalized
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Hello Riza Suminto, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21110
to look at the new patch set (#3).
Change subject: IMPALA-12878: Report invalid query if finalized
......................................................................
IMPALA-12878: Report invalid query if finalized
Fixes a case introduced by IMPALA-12493 where a query is closed again in
the middle of unregistering - which appears to be possible with
cancel_query_and_validate_state - returns "Query not yet running"
instead of "Invalid or unknown query handle".
IMPALA-12493 moved checks for whether a query is inflight before an
atomic CompareAndSwap to mark a QueryDriver as finalized. As part of
that change, a query that was Finalized and removed from
inflight_queries - but not yet removed from query_driver_map_ - could
report "Query not yet running". Updates the check for that error to also
verify the query has not been finalized; if it has, we let the next
conditional handle that case and return "Invalid or unknown query
handle".
Also ensures cancelled queries are closed in test_web_pages tests so
assertions that num_in_flight_queries == 0 at the start of tests are
valid when running the whole suite serially. This doesn't come up in
automated tests because the cases that care about that assertion are
marked execute_serially, while the cases that failed to close a query
were not.
Testing: adds a test dimension for test_cancellation that ensures we get
the expected "Invalid or unknown query handle" when close() is delayed
in calling QueryDriver::Finalize.
Change-Id: I3bf910f499147a09352f9dcb755037b0d8616dfd
---
M be/src/runtime/query-driver.cc
M be/src/service/impala-server.cc
M tests/query_test/test_cancellation.py
M tests/webserver/test_web_pages.py
4 files changed, 27 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/10/21110/3
--
To view, visit http://gerrit.cloudera.org:8080/21110
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3bf910f499147a09352f9dcb755037b0d8616dfd
Gerrit-Change-Number: 21110
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
[Impala-ASF-CR] IMPALA-12878: Report invalid query if finalized
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Hello Riza Suminto, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21110
to look at the new patch set (#2).
Change subject: IMPALA-12878: Report invalid query if finalized
......................................................................
IMPALA-12878: Report invalid query if finalized
Fixes a case introduced by IMPALA-12493 where a query is closed again in
the middle of unregistering - which appears to be possible with
cancel_query_and_validate_state - returns "Query not yet running"
instead of "Invalid or unknown query handle".
IMPALA-12493 moved checks for whether a query is inflight before an
atomic CompareAndSwap to mark a QueryDriver as finalized. As part of
that change, a query that was Finalized and removed from
inflight_queries - but not yet removed from query_driver_map_ - could
report "Query not yet running". Updates the check for that error to also
verify the query has not been finalized; if it has, we let the next
conditional handle that case and return "Invalid or unknown query
handle".
Also ensures cancelled queries are closed in test_web_pages tests so
assertions that num_in_flight_queries == 0 at the start of tests are
valid when running the whole suite serially. This doesn't come up in
automated tests because the cases that care about that assertion are
marked execute_serially, while the cases that failed to close a query
were not.
Testing: adds a test dimension for test_cancellation that ensures we get
the expected "Invalid or unknown query handle" when close() is delayed
in calling QueryDriver::Finalize.
Change-Id: I3bf910f499147a09352f9dcb755037b0d8616dfd
---
M be/src/runtime/query-driver.cc
M be/src/service/impala-server.cc
M tests/query_test/test_cancellation.py
M tests/webserver/test_web_pages.py
4 files changed, 26 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/10/21110/2
--
To view, visit http://gerrit.cloudera.org:8080/21110
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3bf910f499147a09352f9dcb755037b0d8616dfd
Gerrit-Change-Number: 21110
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
[Impala-ASF-CR] IMPALA-12878: Report invalid query if finalized
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21110 )
Change subject: IMPALA-12878: Report invalid query if finalized
......................................................................
Patch Set 5:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/15444/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/21110
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3bf910f499147a09352f9dcb755037b0d8616dfd
Gerrit-Change-Number: 21110
Gerrit-PatchSet: 5
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 07 Mar 2024 18:39:09 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12878: Report invalid query if finalized
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21110 )
Change subject: IMPALA-12878: Report invalid query if finalized
......................................................................
IMPALA-12878: Report invalid query if finalized
Fixes a case introduced by IMPALA-12493 where a query is closed again in
the middle of unregistering - which appears to be possible with
cancel_query_and_validate_state - returns "Query not yet running"
instead of "Invalid or unknown query handle".
IMPALA-12493 moved checks for whether a query is inflight before an
atomic CompareAndSwap to mark a QueryDriver as finalized. As part of
that change, a query that was Finalized and removed from
inflight_queries - but not yet removed from query_driver_map_ - could
report "Query not yet running". Updates the check for that error to also
verify the query has not been finalized; if it has, we let the next
conditional handle that case and return "Invalid or unknown query
handle".
Also ensures cancelled queries are closed in test_web_pages tests so
assertions that num_in_flight_queries == 0 at the start of tests are
valid when running the whole suite serially. This doesn't come up in
automated tests because the cases that care about that assertion are
marked execute_serially, while the cases that failed to close a query
were not.
Testing: adds a test to test_cancellation that ensures we get the
expected "Invalid or unknown query handle" when close() is delayed in
calling QueryDriver::Finalize.
Change-Id: I3bf910f499147a09352f9dcb755037b0d8616dfd
Reviewed-on: http://gerrit.cloudera.org:8080/21110
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/runtime/query-driver.cc
M be/src/service/impala-server.cc
M tests/query_test/test_cancellation.py
M tests/webserver/test_web_pages.py
4 files changed, 37 insertions(+), 1 deletion(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/21110
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I3bf910f499147a09352f9dcb755037b0d8616dfd
Gerrit-Change-Number: 21110
Gerrit-PatchSet: 8
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
[Impala-ASF-CR] IMPALA-12878: Report invalid query if finalized
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21110 )
Change subject: IMPALA-12878: Report invalid query if finalized
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/15429/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/21110
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3bf910f499147a09352f9dcb755037b0d8616dfd
Gerrit-Change-Number: 21110
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 07 Mar 2024 00:08:53 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12878: Report invalid query if finalized
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21110 )
Change subject: IMPALA-12878: Report invalid query if finalized
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/15430/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/21110
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3bf910f499147a09352f9dcb755037b0d8616dfd
Gerrit-Change-Number: 21110
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 07 Mar 2024 00:19:20 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12878: Report invalid query if finalized
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21110 )
Change subject: IMPALA-12878: Report invalid query if finalized
......................................................................
Patch Set 5:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/21110/5/tests/query_test/test_cancellation.py
File tests/query_test/test_cancellation.py:
http://gerrit.cloudera.org:8080/#/c/21110/5/tests/query_test/test_cancellation.py@288
PS5, Line 288:
Can add the following here:
add_mandatory_exec_option(cls, 'debug_action', 'FINALIZE_INFLIGHT_QUERY:SLEEP@10')
Then L299 can be removed.
--
To view, visit http://gerrit.cloudera.org:8080/21110
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3bf910f499147a09352f9dcb755037b0d8616dfd
Gerrit-Change-Number: 21110
Gerrit-PatchSet: 5
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 07 Mar 2024 18:48:35 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12878: Report invalid query if finalized
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21110 )
Change subject: IMPALA-12878: Report invalid query if finalized
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/21110/2/tests/query_test/test_cancellation.py
File tests/query_test/test_cancellation.py:
http://gerrit.cloudera.org:8080/#/c/21110/2/tests/query_test/test_cancellation.py@138
PS2, Line 138: o
flake8: W504 line break after binary operator
http://gerrit.cloudera.org:8080/#/c/21110/2/tests/query_test/test_cancellation.py@139
PS2, Line 139: (
flake8: E131 continuation line unaligned for hanging indent
--
To view, visit http://gerrit.cloudera.org:8080/21110
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3bf910f499147a09352f9dcb755037b0d8616dfd
Gerrit-Change-Number: 21110
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Wed, 06 Mar 2024 23:44:00 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12878: Report invalid query if finalized
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21110 )
Change subject: IMPALA-12878: Report invalid query if finalized
......................................................................
Patch Set 4:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/21110/4/tests/query_test/test_cancellation.py
File tests/query_test/test_cancellation.py:
http://gerrit.cloudera.org:8080/#/c/21110/4/tests/query_test/test_cancellation.py@279
PS4, Line 279: class TestCancellationFinalizeDelayed(ImpalaTestSuite):
flake8: E302 expected 2 blank lines, found 1
http://gerrit.cloudera.org:8080/#/c/21110/4/tests/query_test/test_cancellation.py@291
PS4, Line 291: a
flake8: W504 line break after binary operator
--
To view, visit http://gerrit.cloudera.org:8080/21110
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3bf910f499147a09352f9dcb755037b0d8616dfd
Gerrit-Change-Number: 21110
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 07 Mar 2024 18:09:12 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12878: Report invalid query if finalized
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21110 )
Change subject: IMPALA-12878: Report invalid query if finalized
......................................................................
Patch Set 7: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/21110
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3bf910f499147a09352f9dcb755037b0d8616dfd
Gerrit-Change-Number: 21110
Gerrit-PatchSet: 7
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Fri, 08 Mar 2024 00:36:03 +0000
Gerrit-HasComments: No