You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/03/02 22:36:27 UTC

[GitHub] [beam] iemejia opened a new pull request #14132: [BEAM-11213] Instantiate SparkListenerApplicationStart in a Spark 3 compatible way

iemejia opened a new pull request #14132:
URL: https://github.com/apache/beam/pull/14132


   R: @ibzib 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] iemejia commented on pull request #14132: [BEAM-11213] Instantiate SparkListenerApplicationStart in a Spark 3 compatible way

Posted by GitBox <gi...@apache.org>.
iemejia commented on pull request #14132:
URL: https://github.com/apache/beam/pull/14132#issuecomment-789617050


   Run Java Spark PortableValidatesRunner Batch


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] iemejia commented on a change in pull request #14132: [BEAM-11213] Instantiate SparkListenerApplicationStart in a Spark 3 compatible way

Posted by GitBox <gi...@apache.org>.
iemejia commented on a change in pull request #14132:
URL: https://github.com/apache/beam/pull/14132#discussion_r585960827



##########
File path: runners/spark/src/main/java/org/apache/beam/runners/spark/SparkPipelineRunner.java
##########
@@ -163,8 +160,6 @@ public PortablePipelineResult run(RunnerApi.Pipeline pipeline, JobInfo jobInfo)
       }
     }
 
-    LOG.info(String.format("Running job %s on Spark master %s", jobInfo.jobId(), jsc.master()));

Review comment:
       This one is removed because it is repeated twice, see some lines below in the file for the same log.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] iemejia removed a comment on pull request #14132: [BEAM-11213] Instantiate SparkListenerApplicationStart in a Spark 3 compatible way

Posted by GitBox <gi...@apache.org>.
iemejia removed a comment on pull request #14132:
URL: https://github.com/apache/beam/pull/14132#issuecomment-789275269


   Run Java Spark PortableValidatesRunner Batch
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] iemejia merged pull request #14132: [BEAM-11213] Instantiate SparkListenerApplicationStart in a Spark 3 compatible way

Posted by GitBox <gi...@apache.org>.
iemejia merged pull request #14132:
URL: https://github.com/apache/beam/pull/14132


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] iemejia commented on pull request #14132: [BEAM-11213] Instantiate SparkListenerApplicationStart in a Spark 3 compatible way

Posted by GitBox <gi...@apache.org>.
iemejia commented on pull request #14132:
URL: https://github.com/apache/beam/pull/14132#issuecomment-790871613


   Thanks Kyle, actually that class is marked as `@DeveloperApi` that's the Spark equivalent of Beam's `@Internal` so no guarantees. Also in Scala that change makes more sense because of optional method parameters.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] iemejia edited a comment on pull request #14132: [BEAM-11213] Instantiate SparkListenerApplicationStart in a Spark 3 compatible way

Posted by GitBox <gi...@apache.org>.
iemejia edited a comment on pull request #14132:
URL: https://github.com/apache/beam/pull/14132#issuecomment-790871613


   Thanks Kyle, actually that class is marked as `@DeveloperApi` that's the Spark equivalent of Beam's `@Internal` so no guarantees. Also in Scala that change makes more sense because of optional method parameters with default values.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] iemejia commented on pull request #14132: [BEAM-11213] Instantiate SparkListenerApplicationStart in a Spark 3 compatible way

Posted by GitBox <gi...@apache.org>.
iemejia commented on pull request #14132:
URL: https://github.com/apache/beam/pull/14132#issuecomment-789275269


   Run Java Spark PortableValidatesRunner Batch
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org