You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2020/04/26 14:30:10 UTC
[GitHub] [maven-compiler-plugin] pzygielo opened a new pull request #31: Prevent possible NPEx
pzygielo opened a new pull request #31:
URL: https://github.com/apache/maven-compiler-plugin/pull/31
[LGTM finding](https://lgtm.com/projects/g/apache/maven-compiler-plugin/snapshot/6ae46d1998fadaea491e445edb966bbb44addc6b/files/src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java#x13d75285f448c7a2:1)
- [X] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-compiler-plugin] rfscholte commented on pull request #31: Prevent possible NPEx
Posted by GitBox <gi...@apache.org>.
rfscholte commented on pull request #31:
URL: https://github.com/apache/maven-compiler-plugin/pull/31#issuecomment-619565958
We prefer a style where Collections and Maps are never `null`, so you can loop without extra null-check.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-compiler-plugin] pzygielo edited a comment on pull request #31: Prevent possible NPEx
Posted by GitBox <gi...@apache.org>.
pzygielo edited a comment on pull request #31:
URL: https://github.com/apache/maven-compiler-plugin/pull/31#issuecomment-619567176
Is it safe to remove null-check in https://github.com/apache/maven-compiler-plugin/blob/0d1e77325d8dfb55f1a12068bbcc4be304c33b85/src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java#L1347 then?
It seems that https://github.com/apache/maven-compiler-plugin/blob/0d1e77325d8dfb55f1a12068bbcc4be304c33b85/src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java#L1466 indeed returns at least empty, non-null `Set`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-compiler-plugin] pzygielo commented on pull request #31: Prevent possible NPEx
Posted by GitBox <gi...@apache.org>.
pzygielo commented on pull request #31:
URL: https://github.com/apache/maven-compiler-plugin/pull/31#issuecomment-619568549
Replaced with #32
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-compiler-plugin] pzygielo commented on pull request #31: Prevent possible NPEx
Posted by GitBox <gi...@apache.org>.
pzygielo commented on pull request #31:
URL: https://github.com/apache/maven-compiler-plugin/pull/31#issuecomment-619567176
Is it safe to remove null-check in https://github.com/apache/maven-compiler-plugin/blob/0d1e77325d8dfb55f1a12068bbcc4be304c33b85/src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java#L1347 then?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org