You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Padma Priya N <pa...@gmail.com> on 2017/02/10 07:19:20 UTC
Review Request 56532: AMBARI-19954:Workflow designer is getting hung
while importing the workflow
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56532/
-----------------------------------------------------------
Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha.
Bugs: AMBARI-19954
https://issues.apache.org/jira/browse/AMBARI-19954
Repository: ambari
Description
-------
Fixed by adding batch rendering in cytoscape and by using cytoscape APIs to find the descendent nodes rather than traversing the workflow DAG.
Diffs
-----
contrib/views/wfmanager/src/main/resources/ui/app/components/decision-add-branch.js e4b2224
contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js fd7a258
contrib/views/wfmanager/src/main/resources/ui/app/components/transition-config.js ca45b1f
contrib/views/wfmanager/src/main/resources/ui/app/domain/cytoscape-flow-renderer.js 17fb4a0
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/flow-designer.hbs b9ecb11
Diff: https://reviews.apache.org/r/56532/diff/
Testing
-------
Manual Testing
Thanks,
Padma Priya N
Re: Review Request 56532: AMBARI-19954:Workflow designer is getting
hung while importing the workflow
Posted by Gaurav Nagar <gn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56532/#review165072
-----------------------------------------------------------
Ship it!
Ship It!
- Gaurav Nagar
On Feb. 10, 2017, 7:19 a.m., Padma Priya N wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56532/
> -----------------------------------------------------------
>
> (Updated Feb. 10, 2017, 7:19 a.m.)
>
>
> Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha.
>
>
> Bugs: AMBARI-19954
> https://issues.apache.org/jira/browse/AMBARI-19954
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Fixed by adding batch rendering in cytoscape and by using cytoscape APIs to find the descendent nodes rather than traversing the workflow DAG.
>
>
> Diffs
> -----
>
> contrib/views/wfmanager/src/main/resources/ui/app/components/decision-add-branch.js e4b2224
> contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js fd7a258
> contrib/views/wfmanager/src/main/resources/ui/app/components/transition-config.js ca45b1f
> contrib/views/wfmanager/src/main/resources/ui/app/domain/cytoscape-flow-renderer.js 17fb4a0
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/flow-designer.hbs b9ecb11
>
> Diff: https://reviews.apache.org/r/56532/diff/
>
>
> Testing
> -------
>
> Manual Testing
>
>
> Thanks,
>
> Padma Priya N
>
>
Re: Review Request 56532: AMBARI-19954:Workflow designer is getting
hung while importing the workflow
Posted by belliraj hb <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56532/#review165065
-----------------------------------------------------------
Ship it!
Ship It!
- belliraj hb
On Feb. 10, 2017, 7:19 a.m., Padma Priya N wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56532/
> -----------------------------------------------------------
>
> (Updated Feb. 10, 2017, 7:19 a.m.)
>
>
> Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha.
>
>
> Bugs: AMBARI-19954
> https://issues.apache.org/jira/browse/AMBARI-19954
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Fixed by adding batch rendering in cytoscape and by using cytoscape APIs to find the descendent nodes rather than traversing the workflow DAG.
>
>
> Diffs
> -----
>
> contrib/views/wfmanager/src/main/resources/ui/app/components/decision-add-branch.js e4b2224
> contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js fd7a258
> contrib/views/wfmanager/src/main/resources/ui/app/components/transition-config.js ca45b1f
> contrib/views/wfmanager/src/main/resources/ui/app/domain/cytoscape-flow-renderer.js 17fb4a0
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/flow-designer.hbs b9ecb11
>
> Diff: https://reviews.apache.org/r/56532/diff/
>
>
> Testing
> -------
>
> Manual Testing
>
>
> Thanks,
>
> Padma Priya N
>
>