You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by uce <gi...@git.apache.org> on 2016/05/04 08:43:11 UTC

[GitHub] flink pull request: [FLINK-3860] [connector-wikiedits] Add retry l...

GitHub user uce opened a pull request:

    https://github.com/apache/flink/pull/1964

    [FLINK-3860] [connector-wikiedits] Add retry loop to WikipediaEditsSourceTest

    Add a retry loop to `WikipediaEditsSourceTest` and checks connection to IRC server before running the test. The test is only executed, if a connection can be established. Otherwise, the test is ignored.
    
    Waiting for Travis before merging this...
    
    Example output:
    ```
    WikipediaEditsSourceTest  - Failed to connect to IRC server (1/5). Retrying in 2000 ms.
    WikipediaEditsSourceTest  - Failed to connect to IRC server (2/5). Retrying in 2000 ms.
    WikipediaEditsSourceTest  - Failed to connect to IRC server (3/5). Retrying in 2000 ms.
    WikipediaEditsSourceTest  - Failed to connect to IRC server (4/5). Retrying in 2000 ms.
    WikipediaEditsSourceTest  - Failed to connect to IRC server (5/5). Retrying in 2000 ms.
    WikipediaEditsSourceTest  - Skipped test, because not able to connect to IRC server
    ```
    
    ```
    WikipediaEditsSourceTest  - Failed to connect to IRC server (1/5). Retrying in 2000 ms.
    ...
    WikipediaEditsSourceTest  - Successfully ran test.
    ```

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/uce/flink 3860-wiki_retry

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/1964.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1964
    
----
commit 9cbe5a57e397f6a8921d07df2ed6b15261ea74a6
Author: Ufuk Celebi <uc...@apache.org>
Date:   2016-05-04T08:38:04Z

    [FLINK-3860] [connector-wikiedits] Add retry loop to WikipediaEditsSourceTest

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-3860] [connector-wikiedits] Add retry l...

Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the pull request:

    https://github.com/apache/flink/pull/1964#issuecomment-216830662
  
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-3860] [connector-wikiedits] Add retry l...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/1964


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---