Fix for 44323

["Vallon, Justin" <jv...@bear.com>]

I noticed 1.7.1 is coming up.

How do I get this patch committed?  Is this something that I am supposed
to do myself?

-Justin
office 8-383-6725, 212-272-6725; cell 917-861-6042
-----Original Message-----
From: Vallon, Justin 
Sent: Thursday, February 14, 2008 1:23 PM
To: Ant Developers List
Subject: Re: import re-imports top-level build.xml

Peter Reilly wrote:
> On Jan 28, 2008 10:55 PM, Vallon, Justin <jv...@bear.com> wrote:
>  >  if <import> is given a path to the original (top-level) 
> build-file,
>  > it does not consider it a duplicate import, and imports it (again)
...
> 
> That does sound like a bug!.
> 
> Please file a bugzilla report.

Filed as 44323.

I have attached a patch against ant_20080130114915.tar.gz.  It calls 
FileUtils.normalize on the buildFile in Main.

Who can commit this?

Test case:

build.xml:
	<project name="test">
		<echo message="start test" />
		<import file="./build.xml" />
		<echo message="end test" />
	</project>

'ant' should show "start test", "end test".  Without the patch it shows 
"start test"*2, "end test"*2.

-Justin
jvallon@bear.com

Re: Fix for 44323

[Kevin Jackson <fo...@gmail.com>]

Hi,

> I noticed 1.7.1 is coming up.
>
>  How do I get this patch committed?  Is this something that I am supposed
>  to do myself?

I can commit the patch to trunk (1.8.x), but I won't let further
changes go into 1.7.1
You mention a workaround in your bug report of using the complete path
when calling ant, so I think that this is a non-blocking bug

>  I have attached a patch against ant_20080130114915.tar.gz.  It calls
>  FileUtils.normalize on the buildFile in Main.

Could you attach patch and testcase build.xml to the bug report on
bugzilla?  Attachments are stripped from mails sent to the mailing
list.

Thanks for the report, but I'm not accepting any further changes for
this branch (it will never see the light of day otherwise!)

Kev

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org