You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/10/31 16:36:18 UTC
[GitHub] [skywalking-swck] hanahmily opened a new pull request #41: Fix issues for releasing 0.4.0
hanahmily opened a new pull request #41:
URL: https://github.com/apache/skywalking-swck/pull/41
Storage controller:
* Introduce readiness probe to statefulset
* Apply authorization to controller
* Opt to parrelle pod management strategy
* Add init container to increase "vm.max_map_count"
* Add password to pks12 key/cert
Java agent injector:
* Fix backend services validation
UI:
* Add "http" schema to the backend service URL
cc @dashanji @ESonata
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-swck] dashanji commented on a change in pull request #41: Fix issues for releasing 0.4.0
Posted by GitBox <gi...@apache.org>.
dashanji commented on a change in pull request #41:
URL: https://github.com/apache/skywalking-swck/pull/41#discussion_r739923422
##########
File path: docs/examples/java-agent-injector-usage.md
##########
@@ -34,7 +34,7 @@ spec:
spec:
containers:
- name: demo1
- image: dashanji/swck-spring-demo:v0.0.3
+ image: ghcr.io/apache/skywalking-swck-spring-demo:v0.0.1
Review comment:
Sorry for not giving instructions，the demo use the port `8085`，we can create a service and use `curl http://localhost:(port-forward IP)/hello` to access it. Next , I will add an e2e test based on `skywalking-infra-e2e`, i think it's more convenient to test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-swck] hanahmily commented on a change in pull request #41: Fix issues for releasing 0.4.0
Posted by GitBox <gi...@apache.org>.
hanahmily commented on a change in pull request #41:
URL: https://github.com/apache/skywalking-swck/pull/41#discussion_r739849246
##########
File path: docs/examples/java-agent-injector-usage.md
##########
@@ -34,7 +34,7 @@ spec:
spec:
containers:
- name: demo1
- image: dashanji/swck-spring-demo:v0.0.3
+ image: ghcr.io/apache/skywalking-swck-spring-demo:v0.0.1
Review comment:
@dashanji I renamed this demo image and push it to GitHub container repository.
BTW, What paths we could access in this app? I got a `404` on the root path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-swck] wu-sheng merged pull request #41: Fix issues for releasing 0.4.0
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #41:
URL: https://github.com/apache/skywalking-swck/pull/41
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-swck] dashanji commented on a change in pull request #41: Fix issues for releasing 0.4.0
Posted by GitBox <gi...@apache.org>.
dashanji commented on a change in pull request #41:
URL: https://github.com/apache/skywalking-swck/pull/41#discussion_r739923422
##########
File path: docs/examples/java-agent-injector-usage.md
##########
@@ -34,7 +34,7 @@ spec:
spec:
containers:
- name: demo1
- image: dashanji/swck-spring-demo:v0.0.3
+ image: ghcr.io/apache/skywalking-swck-spring-demo:v0.0.1
Review comment:
Sorry for not giving instructions，we could use `curl http://localhost:(port-forward IP)/hello` to access it. Next , I will add an e2e test based on `skywalking-infra-e2e`, i think it's more convenient to test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org