[jira] [Commented] (TEZ-3665) TestATSV15HistoryLoggingService should use mocked TimelineClient

["Harish Jaiprakash (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TEZ-3665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15935710#comment-15935710 ] 

Harish Jaiprakash commented on TEZ-3665:
----------------------------------------

Thanks, [~aplusplus]. The patch looks good, 1 minor comment.

bq. {code}groupEntities.add((TimelineEntity) args[firstEntityIdx]);{code}

Should be: {code} groupEntities.add((TimelineEntity) args[i]); {code} It does not affect the counts, but just for correctness.

> TestATSV15HistoryLoggingService should use mocked TimelineClient
> ----------------------------------------------------------------
>
>                 Key: TEZ-3665
>                 URL: https://issues.apache.org/jira/browse/TEZ-3665
>             Project: Apache Tez
>          Issue Type: Sub-task
>            Reporter: Zhiyuan Yang
>            Assignee: Zhiyuan Yang
>         Attachments: TEZ-3665.1.patch
>
>
> Currently it's extending TimelineClient and won't build on hadoop3. WIth mocked TimelineClient, we will be able to build against both hadoop2 and hadoop3.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)