[GitHub] nvazquez opened a new pull request #3095: Prevent corner case for infinite PrepareForMaintenance

[GitBox <gi...@apache.org>]

nvazquez opened a new pull request #3095: Prevent corner case for infinite PrepareForMaintenance
URL: https://github.com/apache/cloudstack/pull/3095
 
 
   ## Description
   A corner case was found on 4.11.2 for #2493 leading to an infinite loop in state `PrepareForMaintenance`
   
   To prevent such cases, in which failed migrations are detected but still running on the host, this feature adds a new cluster setting `host.maintenance.retries` which is the number of retries before marking the host as `ErrorInMaintenance` if migration errors persist.
   
   ## Types of changes
   <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [x] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## Screenshots (if appropriate):
   
   ## How Has This Been Tested?
   - 2 KVM hosts, pick one which has running VMs as H
   - Block migrations ports on H to simulate failures on migrations:
   `
   iptables -I OUTPUT -j REJECT -m state --state NEW -m tcp -p tcp --dport 49152:49215 -m comment --comment 'test block migrations'
   iptables -I OUTPUT -j REJECT -m state --state NEW -m tcp -p tcp --dport 16509 -m comment --comment 'test block migrations
   `
   - Put host H in Maintenance
   - Observe that host is indefinitely in `PrepareForMaintenance` state (after this fix it goes into `ErrorInMaintenance` after retrying `host.maintenance.retries` times)
    
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services