You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Stefan Küng <to...@gmail.com> on 2011/04/05 19:56:13 UTC
svn info fails
Hi,
Just discovered that 'svn info' fails with a very unhelpful error message:
svn.exe info http://svn.webdav.org/repos/projects/neon@1832 -r1833
svn: E200004: Could not convert '' into a number
This used to work before, but with my build of the svn client from trunk
it now fails.
Using a build from r1088319.
Stefan
--
___
oo // \\ "De Chelonian Mobile"
(_,\/ \_/ \ TortoiseSVN
\ \_/_\_/> The coolest Interface to (Sub)Version Control
/_/ \_\ http://tortoisesvn.net
Re: svn info fails
Posted by Ivan Zhakov <iv...@visualsvn.com>.
On Tue, Apr 5, 2011 at 22:17, Philip Martin <ph...@wandisco.com> wrote:
> Ivan Zhakov <iv...@visualsvn.com> writes:
>
>> On Tue, Apr 5, 2011 at 22:07, Philip Martin <ph...@wandisco.com> wrote:
>>> Philip Martin <ph...@wandisco.com> writes:
>>>
>>>> Stefan Küng <to...@gmail.com> writes:
>>>>
>>>>> Just discovered that 'svn info' fails with a very unhelpful error message:
>>>>>
>>>>> svn.exe info http://svn.webdav.org/repos/projects/neon@1832 -r1833
>>>>> svn: E200004: Could not convert '' into a number
>>>>
>>>> Not with neon, serf only:
>>>>
>>>> ../src/subversion/svn/info-cmd.c:581: (apr_err=200004)
>>>> ../src/subversion/libsvn_client/info.c:609: (apr_err=200004)
>>>> ../src/subversion/libsvn_ra_serf/serf.c:852: (apr_err=200004)
>>>> ../src/subversion/libsvn_ra_serf/property.c:732: (apr_err=200004)
>>>> ../src/subversion/libsvn_ra_serf/serf.c:679: (apr_err=200004)
>>>> ../src/subversion/libsvn_subr/svn_string.c:775: (apr_err=200004)
>>>> ../src/subversion/libsvn_subr/svn_string.c:775: (apr_err=200004)
>>>> ../src/subversion/libsvn_subr/svn_string.c:775: (apr_err=200004)
>>>> svn: E200004: Could not convert '' into a number
>>>
>>> The relevant code is:
>>>
>>> if(strcmp(name, "deadprop-count") == 0)
>>> {
>>> apr_int64_t deadprop_count;
>>> SVN_ERR(svn_cstring_atoi64(&deadprop_count, val->data));
>>> entry->has_props = deadprop_count > 0;
>>> }
>>>
>> It seems to be my fault. I'll take a look to it tomorrow. Sorry.
>
> Neon uses:
>
> apr_int64_t prop_count = svn__atoui64(propval->data);
> entry->has_props = (prop_count > 0);
>
> So it treats '' as 0. I don't know whether that's a neon bug :)
>
In this particular case ra_serf should behave little bit different:
empty deadprop-count means that server doesn't support this property
at all, so we've to fallback and requesting all properties.
--
Ivan Zhakov
Re: svn info fails
Posted by Philip Martin <ph...@wandisco.com>.
Ivan Zhakov <iv...@visualsvn.com> writes:
> On Tue, Apr 5, 2011 at 22:07, Philip Martin <ph...@wandisco.com> wrote:
>> Philip Martin <ph...@wandisco.com> writes:
>>
>>> Stefan Küng <to...@gmail.com> writes:
>>>
>>>> Just discovered that 'svn info' fails with a very unhelpful error message:
>>>>
>>>> svn.exe info http://svn.webdav.org/repos/projects/neon@1832 -r1833
>>>> svn: E200004: Could not convert '' into a number
>>>
>>> Not with neon, serf only:
>>>
>>> ../src/subversion/svn/info-cmd.c:581: (apr_err=200004)
>>> ../src/subversion/libsvn_client/info.c:609: (apr_err=200004)
>>> ../src/subversion/libsvn_ra_serf/serf.c:852: (apr_err=200004)
>>> ../src/subversion/libsvn_ra_serf/property.c:732: (apr_err=200004)
>>> ../src/subversion/libsvn_ra_serf/serf.c:679: (apr_err=200004)
>>> ../src/subversion/libsvn_subr/svn_string.c:775: (apr_err=200004)
>>> ../src/subversion/libsvn_subr/svn_string.c:775: (apr_err=200004)
>>> ../src/subversion/libsvn_subr/svn_string.c:775: (apr_err=200004)
>>> svn: E200004: Could not convert '' into a number
>>
>> The relevant code is:
>>
>> if(strcmp(name, "deadprop-count") == 0)
>> {
>> apr_int64_t deadprop_count;
>> SVN_ERR(svn_cstring_atoi64(&deadprop_count, val->data));
>> entry->has_props = deadprop_count > 0;
>> }
>>
> It seems to be my fault. I'll take a look to it tomorrow. Sorry.
Neon uses:
apr_int64_t prop_count = svn__atoui64(propval->data);
entry->has_props = (prop_count > 0);
So it treats '' as 0. I don't know whether that's a neon bug :)
--
Philip
Re: svn info fails
Posted by Ivan Zhakov <iv...@visualsvn.com>.
On Tue, Apr 5, 2011 at 22:07, Philip Martin <ph...@wandisco.com> wrote:
> Philip Martin <ph...@wandisco.com> writes:
>
>> Stefan Küng <to...@gmail.com> writes:
>>
>>> Just discovered that 'svn info' fails with a very unhelpful error message:
>>>
>>> svn.exe info http://svn.webdav.org/repos/projects/neon@1832 -r1833
>>> svn: E200004: Could not convert '' into a number
>>
>> Not with neon, serf only:
>>
>> ../src/subversion/svn/info-cmd.c:581: (apr_err=200004)
>> ../src/subversion/libsvn_client/info.c:609: (apr_err=200004)
>> ../src/subversion/libsvn_ra_serf/serf.c:852: (apr_err=200004)
>> ../src/subversion/libsvn_ra_serf/property.c:732: (apr_err=200004)
>> ../src/subversion/libsvn_ra_serf/serf.c:679: (apr_err=200004)
>> ../src/subversion/libsvn_subr/svn_string.c:775: (apr_err=200004)
>> ../src/subversion/libsvn_subr/svn_string.c:775: (apr_err=200004)
>> ../src/subversion/libsvn_subr/svn_string.c:775: (apr_err=200004)
>> svn: E200004: Could not convert '' into a number
>
> The relevant code is:
>
> if(strcmp(name, "deadprop-count") == 0)
> {
> apr_int64_t deadprop_count;
> SVN_ERR(svn_cstring_atoi64(&deadprop_count, val->data));
> entry->has_props = deadprop_count > 0;
> }
>
It seems to be my fault. I'll take a look to it tomorrow. Sorry.
--
Ivan Zhakov
Re: svn info fails
Posted by Philip Martin <ph...@wandisco.com>.
Philip Martin <ph...@wandisco.com> writes:
> Stefan Küng <to...@gmail.com> writes:
>
>> Just discovered that 'svn info' fails with a very unhelpful error message:
>>
>> svn.exe info http://svn.webdav.org/repos/projects/neon@1832 -r1833
>> svn: E200004: Could not convert '' into a number
>
> Not with neon, serf only:
>
> ../src/subversion/svn/info-cmd.c:581: (apr_err=200004)
> ../src/subversion/libsvn_client/info.c:609: (apr_err=200004)
> ../src/subversion/libsvn_ra_serf/serf.c:852: (apr_err=200004)
> ../src/subversion/libsvn_ra_serf/property.c:732: (apr_err=200004)
> ../src/subversion/libsvn_ra_serf/serf.c:679: (apr_err=200004)
> ../src/subversion/libsvn_subr/svn_string.c:775: (apr_err=200004)
> ../src/subversion/libsvn_subr/svn_string.c:775: (apr_err=200004)
> ../src/subversion/libsvn_subr/svn_string.c:775: (apr_err=200004)
> svn: E200004: Could not convert '' into a number
The relevant code is:
if(strcmp(name, "deadprop-count") == 0)
{
apr_int64_t deadprop_count;
SVN_ERR(svn_cstring_atoi64(&deadprop_count, val->data));
entry->has_props = deadprop_count > 0;
}
--
Philip
Re: svn info fails
Posted by Philip Martin <ph...@wandisco.com>.
Stefan Küng <to...@gmail.com> writes:
> Just discovered that 'svn info' fails with a very unhelpful error message:
>
> svn.exe info http://svn.webdav.org/repos/projects/neon@1832 -r1833
> svn: E200004: Could not convert '' into a number
Not with neon, serf only:
../src/subversion/svn/info-cmd.c:581: (apr_err=200004)
../src/subversion/libsvn_client/info.c:609: (apr_err=200004)
../src/subversion/libsvn_ra_serf/serf.c:852: (apr_err=200004)
../src/subversion/libsvn_ra_serf/property.c:732: (apr_err=200004)
../src/subversion/libsvn_ra_serf/serf.c:679: (apr_err=200004)
../src/subversion/libsvn_subr/svn_string.c:775: (apr_err=200004)
../src/subversion/libsvn_subr/svn_string.c:775: (apr_err=200004)
../src/subversion/libsvn_subr/svn_string.c:775: (apr_err=200004)
svn: E200004: Could not convert '' into a number
--
Philip