[GitHub] dubee commented on a change in pull request #3616: Use ‘docker.host’ java property as a way to set Docker access for Runtime unit tests

[GitBox <gi...@apache.org>]

dubee commented on a change in pull request #3616: Use ‘docker.host’ java property as a way to set Docker access for Runtime unit tests
URL: https://github.com/apache/incubator-openwhisk/pull/3616#discussion_r187661875
 
 

 ##########
 File path: tests/src/test/scala/actionContainers/ActionContainer.scala
 ##########
 @@ -145,8 +169,7 @@ object ActionContainer {
 
     // ...find out its IP address...
     val (ip, port) =
-      if (WhiskProperties.getProperty("whisk.version.name") == "local" &&
-          WhiskProperties.onMacOSX()) {
+      if (System.getProperty("os.name").toLowerCase().contains("mac")) {
 
 Review comment:
   @csantanapr, said to check if `DOCKER_HOST` is set here to determine if `docker-machine` is being used on a Mac.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services