You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by robert burrell donkin <ro...@gmail.com> on 2007/07/17 22:58:47 UTC

Re: svn commit: r556668 - in /james/mime4j/trunk/src/main: javacc/org/apache/james/mime4j/field/contenttype/ContentTypeParser.jj javacc/org/apache/james/mime4j/field/datetime/DateTimeParser.jj jjtree/org/apache/james/mime4j/field/address/AddressListP

On 7/16/07, Stefano Bagnara <ap...@bago.org> wrote:
> Nice catch, thank you!
> Is this caught by RAT?

probably not - the source files are never distributed. they don't
really need headers since they are generated.

- robert

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


Re: svn commit: r556668 - in /james/mime4j/trunk/src/main: javacc/org/apache/james/mime4j/field/contenttype/ContentTypeParser.jj javacc/org/apache/james/mime4j/field/datetime/DateTimeParser.jj jjtree/org/apache/james/mime4j/field/address/AddressListP

Posted by Stefano Bagnara <ap...@bago.org>.
robert burrell donkin ha scritto:
> On 7/16/07, Stefano Bagnara <ap...@bago.org> wrote:
>> Nice catch, thank you!
>> Is this caught by RAT?
> 
> probably not - the source files are never distributed. they don't
> really need headers since they are generated.
> 
> - robert

http://people.apache.org/repo/m2-ibiblio-rsync-repository/org/apache/james/apache-mime4j/0.3/

We publish in the maven repository apache-mime4j-0.3-source.jar and
apache-mime4j-0.3-sources.jar containing generated sources.

Unfortunately this is not exactly the expected result: what I intended
when I wrote the poms (after succesfully proposing this to the list) was
to have one source.jar including only real sources and one sources.jar
including only java files (both generated and original).

I see that both file contain both the jj and generated files: the
difference is that the "sources" one has some file in the wrong place
(and I think this is related to a known bug of the javacc plugin for
maven that required some special configuration to have generated files
in the right folder).

This to say that I think that your change is welcome!
I added a JIRA to remember this issue for 0.4.
https://issues.apache.org/jira/browse/MIME4J-20

Thank you again,
Stefano


---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org