You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@netbeans.apache.org by "Laszlo Kishalmi (JIRA)" <ji...@apache.org> on 2018/04/30 23:06:00 UTC

[jira] [Resolved] (NETBEANS-85) Unify and decide about license header in freemarker templates

     [ https://issues.apache.org/jira/browse/NETBEANS-85?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Laszlo Kishalmi resolved NETBEANS-85.
-------------------------------------
    Resolution: Fixed

Reading trough the comments of PR #52, I have the feeling that this issue has been resolved, as the PR has been merged. Checked the License functionality set to a project to GPL 2.0. There were no "scary" part displayed, and the template worked well.

> Unify and decide about license header in freemarker templates
> -------------------------------------------------------------
>
>                 Key: NETBEANS-85
>                 URL: https://issues.apache.org/jira/browse/NETBEANS-85
>             Project: NetBeans
>          Issue Type: Bug
>            Reporter: Matthias Bläsing
>            Priority: Major
>             Fix For: 9.0
>
>
> There are files in the netbeans codebase that are used as template in netbeans. These templates are combined with property sets and used to generate code in users projects.
> With the first iteration of [PR #52|https://github.com/apache/incubator-netbeans/pull/52] on github the apache license headers were added. This was remarked as a bad idea. The reasoning:
> - The user can see the content of the template when opening the file in the template editor. And the user might be offended by seeing the license.
> As counter points it was raised:
> - a license header can be trivially added and won't end up in the generated file (freemarker supports comments)
> - it makes license review easier
> This should be decided centrally.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@netbeans.apache.org
For additional commands, e-mail: commits-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists