[GitHub] [hive] pvary commented on a change in pull request #2315: HIVE-25160: Automatically pass on iceberg-handler jar as job dependency

[GitBox <gi...@apache.org>]

pvary commented on a change in pull request #2315:
URL: https://github.com/apache/hive/pull/2315#discussion_r638616249



##########
File path: iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java
##########
@@ -158,6 +164,37 @@ public void configureJobConf(TableDesc tableDesc, JobConf jobConf) {
         jobConf.set(InputFormatConfig.TABLE_CATALOG_PREFIX + tableName, catalogName);
       }
     }
+    try {
+      addDependencyJars(jobConf, HiveIcebergStorageHandler.class);
+    } catch (IOException e) {
+      Throwables.propagate(e);
+    }
+  }
+
+  // Copied from the KuduStorageHandler :)

Review comment:
       Maybe refactor it to somewhere common?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org