You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@perl.apache.org by Eric Cholet <ch...@logilune.com> on 2001/04/12 13:43:01 UTC
Re: cvs commit: modperl-2.0/src/modules/perl mod_perl.c
--On 12/04/01 01:03 +0000 dougm@apache.org wrote:
> dougm 01/04/11 18:03:14
>
> Modified: src/modules/perl mod_perl.c
> Log:
> i swear eric did this already
>
> Revision Changes Path
> 1.45 +1 -1 modperl-2.0/src/modules/perl/mod_perl.c
>
> Index: mod_perl.c
> ===================================================================
> RCS file: /home/cvs/modperl-2.0/src/modules/perl/mod_perl.c,v
> retrieving revision 1.44
> retrieving revision 1.45
> diff -u -r1.44 -r1.45
> --- mod_perl.c 2001/04/10 13:55:51 1.44
> +++ mod_perl.c 2001/04/12 01:03:14 1.45
> @@ -14,7 +14,7 @@
> perl_destruct(perl);
> perl_free(perl);
>
> - if (handles = modperl_xs_dl_handles_get(cdata->pool)) {
> + if ((handles = modperl_xs_dl_handles_get(cdata->pool))) {
> modperl_xs_dl_handles_close(handles);
I did fixed unbalanced parens, you just added another level of parens,
I wonder why?
> }
>
>
>
>
--
Eric Cholet
B995 E519 1594 10D0 4271 1EA5 8DF3 8004
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: cvs commit: modperl-2.0/src/modules/perl mod_perl.c
Posted by Eric Cholet <ch...@logilune.com>.
--On 12/04/01 09:20 -0400 Vivek Khera wrote:
>>>>>> "EC" == Eric Cholet <ch...@logilune.com> writes:
>
>>> - if (handles = modperl_xs_dl_handles_get(cdata->pool)) {
>>> + if ((handles = modperl_xs_dl_handles_get(cdata->pool))) {
>>> modperl_xs_dl_handles_close(handles);
>
> EC> I did fixed unbalanced parens, you just added another level of parens,
> EC> I wonder why?
>
> The extra parens shut up gcc's extra warnings, telling it that you
> know it is an assignment, not a typo of == comparison.
Ah yes of course, thanks. I'll switch to maintainer-mode to catch those.
--
Eric Cholet
B995 E519 1594 10D0 4271 1EA5 8DF3 8004
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: cvs commit: modperl-2.0/src/modules/perl mod_perl.c
Posted by Doug MacEachern <do...@covalent.net>.
On Thu, 12 Apr 2001, Vivek Khera wrote:
> >>>>> "EC" == Eric Cholet <ch...@logilune.com> writes:
>
> >> - if (handles = modperl_xs_dl_handles_get(cdata->pool)) {
> >> + if ((handles = modperl_xs_dl_handles_get(cdata->pool))) {
> >> modperl_xs_dl_handles_close(handles);
>
> EC> I did fixed unbalanced parens, you just added another level of parens,
> EC> I wonder why?
>
> The extra parens shut up gcc's extra warnings, telling it that you
> know it is an assignment, not a typo of == comparison.
exactly. looking closer at the change eric made, he's right, there were
unbalanced parens:
diff -u -r1.43 -r1.44
--- src/modules/perl/mod_perl.c 2001/04/09 23:57:22 1.43
+++ src/modules/perl/mod_perl.c 2001/04/10 13:55:51 1.44
@@ -14,7 +14,7 @@
perl_destruct(perl);
perl_free(perl);
- if ((handles = modperl_xs_dl_handles_get(cdata->pool)) {
+ if (handles = modperl_xs_dl_handles_get(cdata->pool)) {
modperl_xs_dl_handles_close(handles);
}
not sure how that happened. but in any case, to we needed an extra paren
on the right hand side, not to remove the one on the left.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: cvs commit: modperl-2.0/src/modules/perl mod_perl.c
Posted by Vivek Khera <kh...@kciLink.com>.
>>>>> "EC" == Eric Cholet <ch...@logilune.com> writes:
>> - if (handles = modperl_xs_dl_handles_get(cdata->pool)) {
>> + if ((handles = modperl_xs_dl_handles_get(cdata->pool))) {
>> modperl_xs_dl_handles_close(handles);
EC> I did fixed unbalanced parens, you just added another level of parens,
EC> I wonder why?
The extra parens shut up gcc's extra warnings, telling it that you
know it is an assignment, not a typo of == comparison.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org