You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by "Kevin A. McGrail" <KM...@PCCC.com> on 2013/01/01 02:21:59 UTC
3.4.0-pre1 available for Testing, Review & Input
I expect we have so more bugs to push forward for 3.4.0's release but I
am happy to report that 3.4.0-pre1 is available at
http://people.apache.org/~kmcgrail/devel/
A draft of the announcement is attached.
Here are some of the issues I am working on if anyone has any input.
SpamAssassin 3.4.0-pre1 questions:
1 - Anyone know what the made-doc-stamp file does?
2 - Should a prelease version still include the svn revision?
SpamAssassin 3.4.0-pre1-r1406273. This is during the testing as part of
the build process.
3 - Is revision 1149751 the right version to use to create the Changes file?
4 - Should Changes file be word-wrapped or left as-is?
5 - Need to add Devel-SawAmpersand installation to the docs or something
in the Build information
6 - Need to document process to upload new release to Cpan preferably
tagged as a development release for some testing.
7 - There is a task in the build README to run prove -v xt which I've
never run. However, it seems to fail with errors.
For example, I have Devel::SawAmpersand installed but it doesn't work:
xt/20_saw_ampersand.................cannot open test suite configuration
file 'config.dist': No such file or directory at ../t/SATest.pm line 827.
dubious
Test returned status 2 (wstat 512, 0x200)
8 - Run prove -v xt 2>&1 | tee xt-output-2012-12-31.log
Failures are:
xt/20_saw_ampersand.t 2 512 ?? ?? % ??
xt/50_dcc.t 4 2 50.00% 2 4
xt/50_razor2.t 2 1 50.00% 1
Razor2 worked the second time (seen this many times)
I don't have DCC configured so that's likely the issue for that test.
Finally, cd t; prove -v ../xt/20_saw_ampersand.t appeared to allow
config.dist to be located and the sawampersand xt test to be proven.
9 - Fix the jmason hard coding's in xt files?
Happy New Year,
KAM
Re: 3.4.0-pre1 available for Testing, Review & Input
Posted by "Kevin A. McGrail" <KM...@PCCC.com>.
On 1/3/2013 7:50 PM, Mark Martinec wrote:
>> 1 - Anyone know what the made-doc-stamp file does?
> no idea
I'll leave it. There is a code and svn propedits related to it so maybe
it's something used with the website or CPAN or something.
> I'd leave out all the 'promotions validated' and 'auto-generated rules'.
I might get around to that but it's pretty low priority for a Changes
file. Do you have an automated command that could do that so we can
update the build/README file for the "Create the Changes" file?
>> 4 - Should Changes file be word-wrapped or left as-is?
> Wrapped would be my choice.
Added to the instructions to do so.
>> 5 - Need to add Devel-SawAmpersand installation to the docs or something
>> in the Build information
> I wouldn't worry much about Devel-SawAmpersand, it was
> intended for developers only. Starting with perl 5.17.7
> it became irrelevant:
Good to know but 5.17.7 is pretty far off from being the ubiquitous
minimum version for the project so I'll add this to the sawampersand xt
test as a comment and condition for running. And I found
Devel::SawAmpersand referenced in the fREADME so that should be good
enough.
>> 7 - There is a task in the build README to run prove -v xt which I've
>> never run.
> The t/README suggests:
> make test TEST_FILES="t/spam*.t"
> so this would make a:
> make test TEST_FILES="xt/*.t"
make test TEST_FILES="xt/20_saw_ampersand.t" doesn't work either. It's a
pathing issue to find config.dist
I'll add symlinks for config,config.dist and data. Seems to work now.
svn commit -m 'Cleaning up xt dir so that 20_saw_ampersand works'
Sending xt
Sending xt/20_saw_ampersand.t
Adding xt/config
Adding xt/config.dist
Adding xt/data
Transmitting file data ....
Committed revision 1430432.
>
>> However, it seems to fail with errors.
>> For example, I have Devel::SawAmpersand installed but it doesn't work:
>> xt/20_saw_ampersand.................cannot open test suite configuration
>> file 'config.dist': No such file or directory at ../t/SATest.pm line 827.
>> dubious
>> Test returned status 2 (wstat 512, 0x200)
> Indeed. I also had to make a link in xt to the t/data directory:
> cd t; ln -s ../t/data ./
>
> After that it completes successfully here (perl 5.16.2, FreeBSD 9.1),
> but not in 5.17.7 where it always returns a value 7 (all three bits set),
> probably because nobody cares about it any longer.
Can you try the new version on both 5.16 and 5.17?
>> 8 - Run prove -v xt 2>&1 | tee xt-output-2012-12-31.log
>>
>> Failures are:
>> xt/20_saw_ampersand.t 2 512 ?? ?? % ??
>> xt/50_dcc.t 4 2 50.00% 2 4
>> xt/50_razor2.t 2 1 50.00% 1
>>
>> Razor2 worked the second time (seen this many times)
>> I don't have DCC configured so that's likely the issue for that test.
> xt/50_dcc.t and xt/50_razor2.t run successfully here.
Thanks.
>> 9 - Fix the jmason hard coding's in xt files?
> Perhaps change the:
> system('sudo chown -R jmason t/log');
> into:
> my $uid = (stat("t"))[4];
> system("sudo chown -R $uid t/log") if $uid;
>
Agreed. I'm fixing a lot of things in xt at the same time
svn commit -m 'Added the ability to override more than one variable'
t/SATest.pm
Sending t/SATest.pm
Transmitting file data .
Committed revision 1431037.
svn commit -m 'Tweaks for xt tests in prep for 3.4.0 including adding
more override variables for tests to not be skipped and removing some
hardcoded usernames' xt
Sending xt/50_root_spamd.t
Sending xt/50_root_spamd_tell.t
Sending xt/50_root_spamd_tell_paranoid.t
Sending xt/50_root_spamd_tell_x.t
Sending xt/50_root_spamd_tell_x_paranoid.t
Sending xt/50_root_spamd_u.t
Sending xt/50_root_spamd_u_dcc.t
Sending xt/50_root_spamd_virtual.t
Sending xt/50_root_spamd_x.t
Sending xt/50_root_spamd_x_paranoid.t
Sending xt/50_root_spamd_x_u.t
Sending xt/50_spamd_prefork_stress_3.t
Sending xt/50_spamd_prefork_stress_4.t
Sending xt/50_spf.t
Transmitting file data ..............
Committed revision 1431038.
Regards,
KAM
Re: 3.4.0-pre1 available for Testing, Review & Input
Posted by Mark Martinec <Ma...@ijs.si>.
Kevin A. McGrail wrote:
> 1 - Anyone know what the made-doc-stamp file does?
no idea
> 2 - Should a prelease version still include the svn revision?
> SpamAssassin 3.4.0-pre1-r1406273. This is during the testing as part of
> the build process.
Can't hurt to have it, makes it easier to find the corresponding version,
unless one wants to tag the pre1 revision in svn.
> 3 - Is revision 1149751 the right version to use to create the Changes
> file?
Looks about right.
I'd leave out all the 'promotions validated' and 'auto-generated rules'.
> 4 - Should Changes file be word-wrapped or left as-is?
Wrapped would be my choice.
> 5 - Need to add Devel-SawAmpersand installation to the docs or something
> in the Build information
I wouldn't worry much about Devel-SawAmpersand, it was
intended for developers only. Starting with perl 5.17.7
it became irrelevant:
perldelta 5.17.7:
Core Enhancements
$&, $` and $' are no longer slow
These three infamous variables have been redeemed and no longer slow
down your program when used. Hence, the /p regular expression flag
now does nothing.
> 6 - Need to document process to upload new release to Cpan preferably
> tagged as a development release for some testing.
> 7 - There is a task in the build README to run prove -v xt which I've
> never run.
The t/README suggests:
make test TEST_FILES="t/spam*.t"
so this would make a:
make test TEST_FILES="xt/*.t"
> However, it seems to fail with errors.
> For example, I have Devel::SawAmpersand installed but it doesn't work:
> xt/20_saw_ampersand.................cannot open test suite configuration
> file 'config.dist': No such file or directory at ../t/SATest.pm line 827.
> dubious
> Test returned status 2 (wstat 512, 0x200)
Indeed. I also had to make a link in xt to the t/data directory:
cd t; ln -s ../t/data ./
After that it completes successfully here (perl 5.16.2, FreeBSD 9.1),
but not in 5.17.7 where it always returns a value 7 (all three bits set),
probably because nobody cares about it any longer.
> 8 - Run prove -v xt 2>&1 | tee xt-output-2012-12-31.log
>
> Failures are:
> xt/20_saw_ampersand.t 2 512 ?? ?? % ??
> xt/50_dcc.t 4 2 50.00% 2 4
> xt/50_razor2.t 2 1 50.00% 1
>
> Razor2 worked the second time (seen this many times)
> I don't have DCC configured so that's likely the issue for that test.
xt/50_dcc.t and xt/50_razor2.t run successfully here.
> Finally, cd t; prove -v ../xt/20_saw_ampersand.t appeared to allow
> config.dist to be located and the sawampersand xt test to be proven.
> 9 - Fix the jmason hard coding's in xt files?
Perhaps change the:
system('sudo chown -R jmason t/log');
into:
my $uid = (stat("t"))[4];
system("sudo chown -R $uid t/log") if $uid;
Mark
Re: 3.4.0-pre3 available for Testing, Review & Input
Posted by "Kevin A. McGrail" <KM...@PCCC.com>.
On 1/18/2013 6:27 PM, Jeremy Morton wrote:
> Any chance of this (very simple) patch making it in before the RC?
> https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6890
>
I'm leaning towards it, yes. I'll target it for 3.4.0 and make it a
blocker.
So we'll make a decision on it before 3.4.0 is released.
Re: 3.4.0-pre3 available for Testing, Review & Input
Posted by Todd Rinaldo <to...@cpanel.net>.
Sorry to confuse things Jez. I was replying in general to the 3.4.0 release, rather than discussing the patch.
On Jan 19, 2013, at 12:08 PM, Jeremy Morton <ad...@game-point.net> wrote:
> This patch doesn't have anything to do with Perl; it patches spamc, which is a self-contained compiled C program.
>
> --
> Best regards,
> Jeremy Morton (Jez)
>
> On 19/01/2013 17:58, Todd Rinaldo wrote:
>> I haven't gotten a chance to do so, but given the release cycle of SA, I'd say we need to be sure that perl 5.17 passes given the production release will be out in May
>>
>> Todd
>>
>> On Jan 18, 2013, at 5:27 PM, Jeremy Morton<ad...@game-point.net> wrote:
>>
>>> Any chance of this (very simple) patch making it in before the RC?
>>> https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6890
>>>
>>> It's a really useful piece of spamc functionality and it would mean I could update the 'advanced bash script' on this page:
>>> http://wiki.apache.org/spamassassin/IntegratedSpamdInPostfix
>>>
>>> ... so that it didn't require people to patch spamc to get it to work.
>>>
>>> --
>>> Best regards,
>>> Jeremy Morton (Jez)
>>>
>>> On 18/01/2013 22:59, Kevin A. McGrail wrote:
>>>> I am happy to report that 3.4.0-pre2 is available at
>>>> http://people.apache.org/~kmcgrail/devel/
>>>>
>>>> A draft of the announcement is attached.
>>>>
>>>> Please note, pre2 was prepared but I chose to skip posting the
>>>> announcement due to the fairly large number of changes related to perl
>>>> 5.17 compatibility thanks to Mark Martinec.
>>>>
>>>> And now that I am pretty comfortable building releases, hopefully we can
>>>> look to see if there are any blockers to moving on to a release candidate.
>>>>
>>>> Regards,
>>>> KAM
>>
Re: 3.4.0-pre3 available for Testing, Review & Input
Posted by Jeremy Morton <ad...@game-point.net>.
This patch doesn't have anything to do with Perl; it patches spamc,
which is a self-contained compiled C program.
--
Best regards,
Jeremy Morton (Jez)
On 19/01/2013 17:58, Todd Rinaldo wrote:
> I haven't gotten a chance to do so, but given the release cycle of SA, I'd say we need to be sure that perl 5.17 passes given the production release will be out in May
>
> Todd
>
> On Jan 18, 2013, at 5:27 PM, Jeremy Morton<ad...@game-point.net> wrote:
>
>> Any chance of this (very simple) patch making it in before the RC?
>> https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6890
>>
>> It's a really useful piece of spamc functionality and it would mean I could update the 'advanced bash script' on this page:
>> http://wiki.apache.org/spamassassin/IntegratedSpamdInPostfix
>>
>> ... so that it didn't require people to patch spamc to get it to work.
>>
>> --
>> Best regards,
>> Jeremy Morton (Jez)
>>
>> On 18/01/2013 22:59, Kevin A. McGrail wrote:
>>> I am happy to report that 3.4.0-pre2 is available at
>>> http://people.apache.org/~kmcgrail/devel/
>>>
>>> A draft of the announcement is attached.
>>>
>>> Please note, pre2 was prepared but I chose to skip posting the
>>> announcement due to the fairly large number of changes related to perl
>>> 5.17 compatibility thanks to Mark Martinec.
>>>
>>> And now that I am pretty comfortable building releases, hopefully we can
>>> look to see if there are any blockers to moving on to a release candidate.
>>>
>>> Regards,
>>> KAM
>
Re: 3.4.0-pre3 available for Testing, Review & Input
Posted by Todd Rinaldo <to...@cpanel.net>.
I haven't gotten a chance to do so, but given the release cycle of SA, I'd say we need to be sure that perl 5.17 passes given the production release will be out in May
Todd
On Jan 18, 2013, at 5:27 PM, Jeremy Morton <ad...@game-point.net> wrote:
> Any chance of this (very simple) patch making it in before the RC?
> https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6890
>
> It's a really useful piece of spamc functionality and it would mean I could update the 'advanced bash script' on this page:
> http://wiki.apache.org/spamassassin/IntegratedSpamdInPostfix
>
> ... so that it didn't require people to patch spamc to get it to work.
>
> --
> Best regards,
> Jeremy Morton (Jez)
>
> On 18/01/2013 22:59, Kevin A. McGrail wrote:
>> I am happy to report that 3.4.0-pre2 is available at
>> http://people.apache.org/~kmcgrail/devel/
>>
>> A draft of the announcement is attached.
>>
>> Please note, pre2 was prepared but I chose to skip posting the
>> announcement due to the fairly large number of changes related to perl
>> 5.17 compatibility thanks to Mark Martinec.
>>
>> And now that I am pretty comfortable building releases, hopefully we can
>> look to see if there are any blockers to moving on to a release candidate.
>>
>> Regards,
>> KAM
Re: 3.4.0-pre3 available for Testing, Review & Input
Posted by Jeremy Morton <ad...@game-point.net>.
Any chance of this (very simple) patch making it in before the RC?
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6890
It's a really useful piece of spamc functionality and it would mean I
could update the 'advanced bash script' on this page:
http://wiki.apache.org/spamassassin/IntegratedSpamdInPostfix
... so that it didn't require people to patch spamc to get it to work.
--
Best regards,
Jeremy Morton (Jez)
On 18/01/2013 22:59, Kevin A. McGrail wrote:
> I am happy to report that 3.4.0-pre2 is available at
> http://people.apache.org/~kmcgrail/devel/
>
> A draft of the announcement is attached.
>
> Please note, pre2 was prepared but I chose to skip posting the
> announcement due to the fairly large number of changes related to perl
> 5.17 compatibility thanks to Mark Martinec.
>
> And now that I am pretty comfortable building releases, hopefully we can
> look to see if there are any blockers to moving on to a release candidate.
>
> Regards,
> KAM
3.4.0-pre3 available for Testing, Review & Input
Posted by "Kevin A. McGrail" <KM...@PCCC.com>.
I am happy to report that 3.4.0-pre2 is available at
http://people.apache.org/~kmcgrail/devel/
A draft of the announcement is attached.
Please note, pre2 was prepared but I chose to skip posting the
announcement due to the fairly large number of changes related to perl
5.17 compatibility thanks to Mark Martinec.
And now that I am pretty comfortable building releases, hopefully we can
look to see if there are any blockers to moving on to a release candidate.
Regards,
KAM