You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Chris Douglas (JIRA)" <ji...@apache.org> on 2008/07/12 01:36:31 UTC
[jira] Created: (HADOOP-3752) Audit logging fails to record rename
Audit logging fails to record rename
------------------------------------
Key: HADOOP-3752
URL: https://issues.apache.org/jira/browse/HADOOP-3752
Project: Hadoop Core
Issue Type: Bug
Reporter: Chris Douglas
Assignee: Chris Douglas
Priority: Blocker
Fix For: 0.18.0
The audit log (HADOOP-3336) must also record rename events.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3752) Audit logging fails to record
rename
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12613151#action_12613151 ]
Hadoop QA commented on HADOOP-3752:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12385915/3752-2.patch
against trunk revision 676069.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2853/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2853/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2853/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2853/console
This message is automatically generated.
> Audit logging fails to record rename
> ------------------------------------
>
> Key: HADOOP-3752
> URL: https://issues.apache.org/jira/browse/HADOOP-3752
> Project: Hadoop Core
> Issue Type: Bug
> Reporter: Chris Douglas
> Assignee: Chris Douglas
> Priority: Blocker
> Fix For: 0.18.0
>
> Attachments: 3752-0.patch, 3752-1.patch, 3752-2.patch
>
>
> The audit log (HADOOP-3336) must also record rename events.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3752) Audit logging fails to record rename
Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Douglas updated HADOOP-3752:
----------------------------------
Status: Patch Available (was: Open)
> Audit logging fails to record rename
> ------------------------------------
>
> Key: HADOOP-3752
> URL: https://issues.apache.org/jira/browse/HADOOP-3752
> Project: Hadoop Core
> Issue Type: Bug
> Reporter: Chris Douglas
> Assignee: Chris Douglas
> Priority: Blocker
> Fix For: 0.18.0
>
> Attachments: 3752-0.patch
>
>
> The audit log (HADOOP-3336) must also record rename events.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3752) Audit logging fails to record
rename
Posted by "Lohit Vijayarenu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12613026#action_12613026 ]
Lohit Vijayarenu commented on HADOOP-3752:
------------------------------------------
On similar note, would it be helpful to log return status? One could then easily query for all failed renames or similar operations.
> Audit logging fails to record rename
> ------------------------------------
>
> Key: HADOOP-3752
> URL: https://issues.apache.org/jira/browse/HADOOP-3752
> Project: Hadoop Core
> Issue Type: Bug
> Reporter: Chris Douglas
> Assignee: Chris Douglas
> Priority: Blocker
> Fix For: 0.18.0
>
> Attachments: 3752-0.patch
>
>
> The audit log (HADOOP-3336) must also record rename events.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3752) Audit logging fails to record rename
Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Douglas updated HADOOP-3752:
----------------------------------
Attachment: 3752-2.patch
Lohit correctly points out that many of the audit messages ignore the status returned from the \*Internal methods, so the "log iff successful" predicate doesn't hold. This patch observes this policy.
> Audit logging fails to record rename
> ------------------------------------
>
> Key: HADOOP-3752
> URL: https://issues.apache.org/jira/browse/HADOOP-3752
> Project: Hadoop Core
> Issue Type: Bug
> Reporter: Chris Douglas
> Assignee: Chris Douglas
> Priority: Blocker
> Fix For: 0.18.0
>
> Attachments: 3752-0.patch, 3752-1.patch, 3752-2.patch
>
>
> The audit log (HADOOP-3336) must also record rename events.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3752) Audit logging fails to record rename
Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Douglas updated HADOOP-3752:
----------------------------------
Attachment: 3752-1.patch
bq. On similar note, would it be helpful to log return status? One could then easily query for all failed renames or similar operations.
For now, only successful operations are logged.
This patch adds rename, uses {{src=<Path>\tdst=<Path>}} instead of {{path=<Path>[,<Path>]}}, and replaces the call to String.format- which allocates a new Formatter and StringBuilder for each call- with a TheadLocal Formatter that reuses its StringBuilder. It also adds types to most of the args, which was missing from the first version.
> Audit logging fails to record rename
> ------------------------------------
>
> Key: HADOOP-3752
> URL: https://issues.apache.org/jira/browse/HADOOP-3752
> Project: Hadoop Core
> Issue Type: Bug
> Reporter: Chris Douglas
> Assignee: Chris Douglas
> Priority: Blocker
> Fix For: 0.18.0
>
> Attachments: 3752-0.patch, 3752-1.patch
>
>
> The audit log (HADOOP-3336) must also record rename events.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3752) Audit logging fails to record rename
Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Douglas updated HADOOP-3752:
----------------------------------
Attachment: 3752-1.patch
> Audit logging fails to record rename
> ------------------------------------
>
> Key: HADOOP-3752
> URL: https://issues.apache.org/jira/browse/HADOOP-3752
> Project: Hadoop Core
> Issue Type: Bug
> Reporter: Chris Douglas
> Assignee: Chris Douglas
> Priority: Blocker
> Fix For: 0.18.0
>
> Attachments: 3752-0.patch, 3752-1.patch
>
>
> The audit log (HADOOP-3336) must also record rename events.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3752) Audit logging fails to record rename
Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Douglas updated HADOOP-3752:
----------------------------------
Attachment: (was: 3752-1.patch)
> Audit logging fails to record rename
> ------------------------------------
>
> Key: HADOOP-3752
> URL: https://issues.apache.org/jira/browse/HADOOP-3752
> Project: Hadoop Core
> Issue Type: Bug
> Reporter: Chris Douglas
> Assignee: Chris Douglas
> Priority: Blocker
> Fix For: 0.18.0
>
> Attachments: 3752-0.patch, 3752-1.patch
>
>
> The audit log (HADOOP-3336) must also record rename events.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3752) Audit logging fails to record
rename
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12624709#action_12624709 ]
Hudson commented on HADOOP-3752:
--------------------------------
Integrated in Hadoop-trunk #581 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/581/])
> Audit logging fails to record rename
> ------------------------------------
>
> Key: HADOOP-3752
> URL: https://issues.apache.org/jira/browse/HADOOP-3752
> Project: Hadoop Core
> Issue Type: Bug
> Reporter: Chris Douglas
> Assignee: Chris Douglas
> Priority: Blocker
> Fix For: 0.18.0
>
> Attachments: 3752-0.patch, 3752-1.patch, 3752-2.patch
>
>
> The audit log (HADOOP-3336) must also record rename events.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3752) Audit logging fails to record rename
Posted by "Lohit Vijayarenu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lohit Vijayarenu updated HADOOP-3752:
-------------------------------------
Hadoop Flags: [Reviewed]
+1 Looks good.
> Audit logging fails to record rename
> ------------------------------------
>
> Key: HADOOP-3752
> URL: https://issues.apache.org/jira/browse/HADOOP-3752
> Project: Hadoop Core
> Issue Type: Bug
> Reporter: Chris Douglas
> Assignee: Chris Douglas
> Priority: Blocker
> Fix For: 0.18.0
>
> Attachments: 3752-0.patch, 3752-1.patch, 3752-2.patch
>
>
> The audit log (HADOOP-3336) must also record rename events.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3752) Audit logging fails to record rename
Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Douglas updated HADOOP-3752:
----------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
I just committed this.
> Audit logging fails to record rename
> ------------------------------------
>
> Key: HADOOP-3752
> URL: https://issues.apache.org/jira/browse/HADOOP-3752
> Project: Hadoop Core
> Issue Type: Bug
> Reporter: Chris Douglas
> Assignee: Chris Douglas
> Priority: Blocker
> Fix For: 0.18.0
>
> Attachments: 3752-0.patch, 3752-1.patch, 3752-2.patch
>
>
> The audit log (HADOOP-3336) must also record rename events.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3752) Audit logging fails to record rename
Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Douglas updated HADOOP-3752:
----------------------------------
Attachment: 3752-0.patch
Added a log entry for rename.
Since this is the first release with this appender, now would be a good time to object to this fix. The audit format assumes a path, but rename requires a source and destination. This patch just separates the two paths with a comma (a reserved character in the URI RFC, but legal in path segments, among other places). It might be better if the source and destination were separate entries, with the latter set to null where not applicable.
> Audit logging fails to record rename
> ------------------------------------
>
> Key: HADOOP-3752
> URL: https://issues.apache.org/jira/browse/HADOOP-3752
> Project: Hadoop Core
> Issue Type: Bug
> Reporter: Chris Douglas
> Assignee: Chris Douglas
> Priority: Blocker
> Fix For: 0.18.0
>
> Attachments: 3752-0.patch
>
>
> The audit log (HADOOP-3336) must also record rename events.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.