You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2021/03/01 13:41:18 UTC
[GitHub] [bookkeeper] eolivelli commented on a change in pull request #2626: Allow force compact entry log when disabling entrh log compaction
eolivelli commented on a change in pull request #2626:
URL: https://github.com/apache/bookkeeper/pull/2626#discussion_r584718658
##########
File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/ServerConfiguration.java
##########
@@ -1450,6 +1451,27 @@ public ServerConfiguration setStatisticsEnabled(boolean enabled) {
return this;
}
+ /**
+ * Allow manually force compact the entry log or not.
+ *
+ * @param enable
+ * whether allow manually force compact the entry log or not.
+ * @return service configuration.
+ */
+ public ServerConfiguration setIsForceCompactionAllowWhenDisableCompaction(boolean enable) {
Review comment:
can you update this method (setForceAllowCompaction) as well ?
##########
File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/ServerConfiguration.java
##########
@@ -1450,6 +1451,27 @@ public ServerConfiguration setStatisticsEnabled(boolean enabled) {
return this;
}
+ /**
+ * Allow manually force compact the entry log or not.
+ *
+ * @param enable
+ * whether allow manually force compact the entry log or not.
+ * @return service configuration.
+ */
+ public ServerConfiguration setIsForceCompactionAllowWhenDisableCompaction(boolean enable) {
+ setProperty(IS_FORCE_COMPACTION_ALLOW_WHEN_DISABLE_COMPACTION, enable);
+ return this;
+ }
+
+ /**
+ * The force compaction is allowed or not when disabling the entry log compaction.
+ *
+ * @return the force compaction is allowed or not when disabling the entry log compaction.
+ */
+ public boolean isForceCompactionAllowWhenDisableCompaction() {
Review comment:
can you update this method (isForceAllowCompaction) as well ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org