You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "Jefffrey (via GitHub)" <gi...@apache.org> on 2026/10/05 14:22:15 UTC
[PR] New workflow to copy linked issue labels to PRs [arrow-rs]
Jefffrey opened a new pull request, #11386:
URL: https://github.com/apache/arrow-rs/pull/11386
# Which issue does this PR close?
<!--
It is not necessary to raise an issue, but it is encouraged if it is a non-trivial
enhancement/bug.
If this PR relates to an existing issue, but does not fully resolve it, please change
the wording below from "Closes #NNN" to "Relates to #NNN" or "Part of #NNN" to avoid
false closing an issue.
-->
- Closes #10529
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the
issue then this section is not needed. Explaining clearly why changes are proposed
helps reviewers understand your changes and offer better suggestions for fixes.
Please try to explain the problem you are trying to solve in terms of the user-visible
behavior, rather than the implementation.
-->
From issue:
> Our changelog generation relies on categorizing included PRs by their labels, see:
>
> - https://github.com/apache/arrow-rs/pull/10451
>
> That means we should ensure PRs merged to main have labels such as `bug`, `enhancement`, `performance`, `security`, `development-process`, etc.
>
> Whenever we create issues they usually get tagged as either bug or enhancement based on the template, so if a PR is created and links to the issue (`Closes #123`) then it would be good to be able to copy the labels from the issue to the PR so maintainers don't need to manually do this for every PR.
>
> Looks like this project might accomplish this: https://github.com/michalvankodev/copy-issue-labels
>
> Look into introducing this (and ensuring it does what we need).
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
Instead of pulling in another action, just achieve it simply with actions github script. This implementation was drafted by codex and iterated to get the simplest form, then I did some further editing of the code.
New workflow that runs only on PR open, and if PR closes an issue (just linking it doesnt trigger this) then it fetches labels from that issue, and if is one of the 4 whitelisted labels copies it onto the PR
# Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they
covered by existing tests, if so identify these tests)?
If this PR claims a performance improvement, please include evidence such as
benchmark results.
DO NOT simply paste a list of commands ran to verify the code; this is what our
CI is for and it pollutes the PR. ONLY explain if testing was included with this
PR, or why it wasn't.
-->
Tested in my fork:
- https://github.com/Jefffrey/arrow-rs/pull/2
- https://github.com/Jefffrey/arrow-rs/pull/4
- https://github.com/Jefffrey/arrow-rs/pull/6
- https://github.com/Jefffrey/arrow-rs/pull/7
- https://github.com/Jefffrey/arrow-rs/pull/8
- https://github.com/Jefffrey/arrow-rs/pull/9
- https://github.com/Jefffrey/arrow-rs/pull/10
# Are there any significant user-facing changes?
<!--
Significant user-facing changes include:
- Breaking public API change
- Significant change to existing functionality (e.g. function returns something different)
These need to be explicitly called out to ensure we have proper documentation if
required and to ensure we follow proper semantic versioning.
DO NOT restate the changes of this PR; if a bug was fixed and already explained
above, we don't need this to be restated as a user-facing change.
-->
Just dev process changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New workflow to copy linked issue labels to PRs [arrow-rs]
Posted by "Jefffrey (via GitHub)" <gi...@apache.org>.
Jefffrey commented on PR #11386:
URL: https://github.com/apache/arrow-rs/pull/11386#issuecomment-5996715665
reminder to self: if/once this is merged, go back to my fork and clean it up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New workflow to copy linked issue labels to PRs [arrow-rs]
Posted by "Jefffrey (via GitHub)" <gi...@apache.org>.
Jefffrey commented on PR #11386:
URL: https://github.com/apache/arrow-rs/pull/11386#issuecomment-6050647882
> Thanks @Jefffrey. I didn't look at each test, but I assume this works for any of the synonyms of "closes".
it uses a github api to get those issues, so as long as github itself recognizes the issues as being linked to the PR in that way the solution will work
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New workflow to copy linked issue labels to PRs [arrow-rs]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #11386:
URL: https://github.com/apache/arrow-rs/pull/11386#issuecomment-6044940904
Makes sense to me -- thank you @Jefffrey and @etseidl
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New workflow to copy linked issue labels to PRs [arrow-rs]
Posted by "Jefffrey (via GitHub)" <gi...@apache.org>.
Jefffrey commented on code in PR #11386:
URL: https://github.com/apache/arrow-rs/pull/11386#discussion_r4185065603
##########
.github/workflows/dev_pr.yml:
##########
@@ -18,7 +18,7 @@
name: dev_pr
concurrency:
- group: ${{ github.repository }}-${{ github.head_ref || github.sha }}-${{ github.workflow }}
+ group: ${{ github.repository }}-${{ github.event.pull_request.number }}-${{ github.workflow }}
Review Comment:
this was something identified by codex on the side; if PRs from different forks have same name it can cause issues, so we rely on PR number to avoid conflicts. this follows what we do in other workflows:
https://github.com/apache/arrow-rs/blob/103ebe7548db35c37e8ff35fcb02438bcd182fa7/.github/workflows/ci.yml#L27-L29
since this runs only on PRs, we dont need a fallback to `github.sha`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New workflow to copy linked issue labels to PRs [arrow-rs]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #11386:
URL: https://github.com/apache/arrow-rs/pull/11386
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org